cafe-grader-web Commit - r875:567f1ebe063b

cafe-grader-web

Commit `r875:567f1ebe063b` public

parent | child

Description:

user admin

Commit status:

[Not Reviewed]

References:

default

Diff options:

| | | |

Comments:

0 Commit comments 0 Inline Comments

Unresolved TODOs:

There are no unresolved TODOs

Add another comment

r875:567f1ebe063b - Mon, 26 Sep 2022 21:05:12 - 8 files changed: 80 inserted, 78 deleted

app/controllers/user_admin_controller.rb ¶ +1

                   @users = User.all
                   @hidden_columns = ['hashed_password', 'salt', 'created_at', 'updated_at']
                   @contests = Contest.enabled
+            +     @user = User.new
                 end
                 def active

app/helpers/application_helper.rb ¶ -10

                   BOOTSTRAP_FLASH_MSG.fetch(flash_type.to_sym, flash_type.to_s)
                 end
-            -   def flash_messages
-            -     flash.each do |msg_type, message|
-            -       concat(content_tag(:div, message, class: "alert #{bootstrap_class_for(msg_type)} fade in") do
-            -               concat content_tag(:button, 'x', class: "close", data: { dismiss: 'alert' })
-            -               concat message
-            -             end)
-            -     end
-            -     nil
-            -   end
+            -
               end

app/javascript/application.js ¶ +4 -1

               import 'custom'
+            + //trigger import map ready
               console.log('application.js ready')
+            -
+            + window.importmapScriptsLoaded = true
+            + const import_map_loaded = new CustomEvent('import-map-loaded', { });
+            + document.dispatchEvent(import_map_loaded);

app/views/layouts/application.html.haml ¶ +4 -1

                 /= content_tag(:p,flash[:notice],class: 'alert alert-success') if flash[:notice]!=nil
                 .container-fluid
-            -     = flash_messages
+            +     - flash.each do |msg_type, message|
+            +       .alert.alert-dismissible.fade.show{class: bootstrap_class_for(msg_type)}
+            +         = message
+            +         %button.btn-close{type: 'button', 'data-bs-dismiss': :alert}
                   = yield

app/views/user_admin/_form.html.haml ¶ +17 -9

		@@ -1,12 +1,20
1	1	= simple_form_for(@user) do \|f\|
2	2	= f.error_notification
3		- = f.input :login, label: 'Login'
4		- = f.input :~~full_name~~, label: '~~Full name~~'
5		- = f.input :password
6		- = f.input :password_confirmation
7		- = f.input :email
8		- = f.input :~~alias~~
9		- = f.input :remark
10		- = f.button :submit, class: 'btn btn-primary'
11		- = link_to 'Cancel', :back, class: 'btn btn-default'
	3	+ .mb-2
	4	+ = f.input :login, label: 'Login'
	5	+ .mb-2
	6	+ = f.input :full_name, label: 'Full name'
	7	+ .mb-2
	8	+ = f.input :password
	9	+ .mb-2
	10	+ = f.input :password_confirmation
	11	+ .mb-2
	12	+ = f.input :email
	13	+ .mb-2
	14	+ = f.input :alias
	15	+ .mb-2
	16	+ = f.input :remark
	17	+ .mb-2
	18	+ = f.button :submit, class: 'btn btn-primary'
	19	+ = link_to 'Cancel', :back, class: 'btn btn-secondary'
12	20

app/views/user_admin/index.html.haml ¶ +30 -35

               %h1 Users
-            - .card.border-primary
-            -   .card-header.text-bg-primary.border-primary
+            + .card.border-success.mb-3
+            +   .card-header.text-bg-success.border-success
                   Quick Add
                 .card-body
-            -     = form_with url: 'asd', class: 'row row-cols-lg-auto g-3 align-items-center'  do |f|
+            +     = form_with url: user_admin_index_path, scope: :user,  class: 'row row-cols-lg-auto g-3 align-items-center'  do |f|
                     .col-12
-            -         = f.label 'user_login', 'Login'
-            -         = f.text_field 'login', :size => 10,class: 'form-control'
+            +         = f.text_field 'login', :size => 10,class: 'form-control', placeholder: 'login'
                     .form-group
-            -         = f.label 'user_full_name', 'Full Name'
-            -         = f.text_field 'full_name', :size => 10,class: 'form-control'
+            +         = f.text_field 'full_name', :size => 10,class: 'form-control', placeholder: 'full name'
                     .form-group
-            -         = f.label 'user_password', 'Password'
-            -         = f.text_field 'password', :size => 10,class: 'form-control'
+            +         = f.password_field 'password', :size => 10,class: 'form-control', placeholder: 'password'
                     .form-group
-            -         = f.label 'user_password_confirmation', 'Confirm'
-            -         = f.text_field 'password_confirmation', :size => 10,class: 'form-control'
+            +         = f.password_field 'password_confirmation', :size => 10,class: 'form-control', placeholder: 'password confirmation'
                     .form-group
-            -         = f.label 'user_email', 'email'
-            -         = f.text_field 'email', :size => 10,class: 'form-control'
-            -       =submit_tag "Create", class: 'btn btn-primary align-items-bottom'
+            +         = f.text_field 'email', :size => 10,class: 'form-control', placeholder: 'email'
+            +       =submit_tag "Create", class: 'btn btn-success align-items-bottom'
-            - .panel.panel-primary
-            -   .panel-title.panel-heading
+            + .card.border-success.mb-3
+            +   .card-header.text-bg-success.border-success
                   Import from site management
-            -   .panel-body
-            -     = form_tag({:action => 'import'}, :multipart => true,class: 'form form-inline') do
-            -       .form-group
-            -         = label_tag :file, 'File:'
-            -         .input-group
-            -           %span.input-group-btn
-            -             %span.btn.btn-default.btn-file
-            -               Browse
-            -               = file_field_tag 'file'
-            -           = text_field_tag '' , nil, {readonly: true, class: 'form-control'}
-            -       = submit_tag 'Submit', class: 'btn btn-default'
+            +   .card-body
+            +     = form_with url: import_user_admin_index_path, :multipart => true do |f|
+            +       .row
+            +         .col-auto
+            +           = f.label :file, 'File:', class: 'col-form-label'
+            +         .col-auto
+            +           = f.file_field :file, class: 'form-control'
+            +         .col-auto
+            +           = f.submit 'Submit', class: 'btn btn-secondary'
               %p
                 = link_to '+ New user', { :action => 'new' }, { class: 'btn btn-success '}
                 = link_to '+ New list of users', { :action => 'new_list' }, { class: 'btn btn-success '}
-            -   = link_to 'Bulk Manage', { action: :bulk_manage} , { class: 'btn btn-default btn-info'}
-            -   = link_to 'View administrators',{ :action => 'admin'}, { class: 'btn btn-default '}
-            -   = link_to 'Random passwords',{ :action => 'random_all_passwords'}, { class: 'btn btn-default '}
-            -   = link_to 'View active users',{ :action => 'active'}, { class: 'btn btn-default '}
-            -   = link_to 'Mass mailing',{ :action => 'mass_mailing'}, { class: 'btn btn-default '}
+            +   = link_to 'Bulk Manage', { action: :bulk_manage} , { class: 'btn btn-secondary btn-info'}
+            +   = link_to 'View administrators',{ :action => 'admin'}, { class: 'btn btn-secondary '}
+            +   = link_to 'Random passwords',{ :action => 'random_all_passwords'}, { class: 'btn btn-secondary '}
+            +   = link_to 'View active users',{ :action => 'active'}, { class: 'btn btn-secondary '}
+            +   = link_to 'Mass mailing',{ :action => 'mass_mailing'}, { class: 'btn btn-secondary '}
               - if GraderConfiguration.multicontests?
                 %br/
               = link_to '+ New list of users', { :action => 'new_list' }, { class: 'btn btn-success '}
               :javascript
-            -   $('.datatable').DataTable({
-            -     'pageLength': 50
-            -   });
+            +   $(document).on('import-map-loaded',(e) => {
+            +     $('.datatable').DataTable({
+            +       'pageLength': 50
+            +     });
+            +   })

app/views/user_admin/new_list.html.haml ¶ +23 -21

		@@ -2,12 +2,26
2	2	.row
3	3	.col-md-6
4	4	%h1 Adding list of users
5		- .row
	5	+ .row.my-3
6	6	.col-md-6
7		- .panel.panel-default
8		- .panel-heading
9		- .~~panel-title~~ ~~Inf~~o
10		- .panel-body
	7	+ = form_with url: create_from_list_user_admin_index_path do \|f\|
	8	+ .row.align-items-center.mb-3
	9	+ .col-auto
	10	+ = f.submit 'Create following users',class: 'btn btn-success'
	11	+ .col-auto
	12	+ .form-check
	13	+ = f.check_box :add_to_group, class: 'form-check-input'
	14	+ = f.label :add_to_group, 'Also add these users to the following group', class: 'form-check-label'
	15	+ .col-4
	16	+ = f.select "group_id", options_from_collection_for_select( Group.all, 'id','name',params[:group_name]), {}, class: 'select2 form-control'
	17	+ .row.mb-3
	18	+ .col-12
	19	+ = f.text_area :user_list, value: nil, class: 'form-control', style: 'height: 30rem'
	20	+ .col-md-6
	21	+ .card.card-default
	22	+ .card-header
	23	+ .card-title Info
	24	+ .card-body
11	25	%ul
12	26	%li
13	27	List of user information in this format:
		@@ -35,20 +49,8
35	49	%pre user1,Somchai Jaidee,
36	50	will create (or update) a user with login "user1" and and setting the fullname "Somchai Jaidee". No change is made to the password unless this is a new user. If this is a new user, a random password will be generated.
37	51
	52	+ :javascript
	53	+ $(document).on('import-map-loaded',(e) => {
	54	+ $('.select2').select2()
	55	+ });
38	56
39		- .row
40		- .col-md-6
41		- = form_tag :action => 'create_from_list' do
42		- .form-group
43		- = submit_tag 'Create following users',class: 'btn btn-success'
44		- .form-group
45		- .div.checkbox
46		- %label
47		- = check_box_tag :add_to_group
48		- Also add these users to the following group
49		- = select_tag "group_id", options_from_collection_for_select( Group.all, 'id','name',params[:group_name]), id: 'group_name',class: 'select2'
50		- .form-group
51		- = text_area_tag 'user_list', nil, :rows => 50, :cols => 80
52		- .col-md-6
53		-
54		-

config/initializers/new_framework_defaults_5_2.rb ¶ +1 -1

               # Rails.application.config.active_support.use_sha1_digests = true
               # Make `form_with` generate id attributes for any generated HTML tags.
-            - # Rails.application.config.action_view.form_with_generates_ids = true
+            + Rails.application.config.action_view.form_with_generates_ids = true

Write
Preview

You need to be logged in to leave comments. Login now

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository permissions settings

Sign in to your account

Author

r875:567f1ebe063b - Mon, 26 Sep 2022 21:05:12 - 8 files changed: 80 inserted, 78 deleted

Sign in to your account

Commit r875:567f1ebe063b public

Author

r875:567f1ebe063b - Mon, 26 Sep 2022 21:05:12 - 8 files changed: 80 inserted, 78 deleted

Commit `r875:567f1ebe063b` public