cafe-grader-web Commit - r680:4ce0b8696d06

cafe-grader-web

Commit `r680:4ce0b8696d06` public

parent | child

Description:

add remove_all in groups consolidate submissions viewing from grader/task

Commit status:

[Not Reviewed]

References:

java

Diff options:

| | | |

Comments:

0 Commit comments 0 Inline Comments

Unresolved TODOs:

There are no unresolved TODOs

Add another comment

r680:4ce0b8696d06 - Thu, 14 Sep 2017 14:45:10 - 9 files changed: 35 inserted, 138 deleted

app/controllers/graders_controller.rb ¶ +1 -36

               class GradersController < ApplicationController
-            -   before_filter :admin_authorization, except: [ :submission ]
-            -   before_filter(only: [:submission]) {
-            -     #check if authenticated
-            -     return false unless authenticate
+            -
-            -     #admin always has privileged
-            -     if @current_user.admin?
-            -       return true
-            -     end
+            -
-            -     if GraderConfiguration["right.user_view_submission"] and Submission.find(params[:id]).problem.available?
-            -       return true
-            -     else
-            -       unauthorized_redirect
-            -       return false
-            -     end
-            -   }
+            +   before_filter :admin_authorization
                 verify :method => :post, :only => ['clear_all',
                                                    'start_exam',
                   @task = Task.find(params[:id])
                 end
-            -   def submission
-            -     @submission = Submission.find(params[:id])
-            -     formatter = Rouge::Formatters::HTML.new(css_class: 'highlight', line_numbers: true )
-            -     lexer = case @submission.language.name
-            -       when "c"      then Rouge::Lexers::C.new
-            -       when "cpp"    then Rouge::Lexers::Cpp.new
-            -       when "pas"    then Rouge::Lexers::Pas.new
-            -       when "ruby"   then Rouge::Lexers::Ruby.new
-            -       when "python" then Rouge::Lexers::Python.new
-            -       when "java"   then Rouge::Lexers::Java.new
-            -       when "php"    then Rouge::Lexers::PHP.new
-            -     end
-            -     @formatted_code = formatter.format(lexer.lex(@submission.source))
-            -     @css_style = Rouge::Themes::ThankfulEyes.render(scope: '.highlight')
+            -
-            -     user = User.find(session[:user_id])
-            -     SubmissionViewLog.create(user_id: session[:user_id],submission_id: @submission.id) unless user.admin?
+            -
-            -   end
                 # various grader controls

app/controllers/groups_controller.rb ¶ +12 -2

               class GroupsController < ApplicationController
                 before_action :set_group, only: [:show, :edit, :update, :destroy,
-            -                                    :add_user, :remove_user,
-            -                                    :add_problem, :remove_problem,
+            +                                    :add_user, :remove_user,:remove_all_user,
+            +                                    :add_problem, :remove_problem,:remove_all_problem,
                                                 ]
                 before_action :authenticate, :admin_authorization
                   redirect_to group_path(@group), flash: {success: "User #{user.login} was removed from the group #{@group.name}"}
                 end
+            +   def remove_all_user
+            +     @group.users.clear
+            +     redirect_to group_path(@group), alert: 'All users removed'
+            +   end
+            +
+            +   def remove_all_problem
+            +     @group.problems.clear
+            +     redirect_to group_path(@group), alert: 'All problems removed'
+            +   end
+            +
                 def add_user
                   user = User.find(params[:user_id])
                   begin

app/controllers/tasks_controller.rb ¶ +1 -1

                 # this has problem-level access control
                 def download
                   problem = Problem.find(params[:id])
-            -     if !problem or !problem.available or !@user.can_view_problem? problem
+            +     unless @current_user.can_view_problem? problem
                     redirect_to :action => 'index' and return
                   end

app/models/user.rb ¶ +2 -5

                 end
                 def can_view_problem?(problem)
-            -     if not GraderConfiguration.multicontests?
-            -       return problem.available
-            -     else
-            -       return problem_in_user_contests? problem
-            -     end
+            +     return true if admin?
+            +     return available_problems.include? problem
                 end
                 def self.clear_last_login

app/views/graders/task.html.haml ¶ +1 -1

                 %br/
                 = "Submission: #{@task.submission_id}"
                 - if @task.submission !=nil
-            -     = link_to '[view submission]', :action => 'submission', :id => @task.submission.id
+            +     = link_to '[view submission]', submission_path( @task.submission.id )
                 %br/
                 = "Submitted at: #{format_short_time(@task.created_at)}"
                 %br/

app/views/groups/show.html.haml ¶ +6 -5

               = link_to 'Back', groups_path
               .row
-            -   %h1 Group details
+            +   .col-md-12
+            +     %h1 Group details
               .row
                 .col-md-6
                   .panel.panel-default
                             %th Login
                             %th Full name
                             %th Remark
-            -               %th
+            +               %th= link_to 'Remove All', remove_all_user_group_path(@group), method: :delete, :data => { :confirm => "Remove ALL USERS from group?" }, class: 'btn btn-danger btn-sm'
                         %tbody
                           - @group.users.each do |user|
                               %td= user.login
                               %td= user.full_name
                               %td= user.remark
-            -                 %td= link_to 'Remove', remove_user_group_path(@group,user), :method => :delete, :data => { :confirm => "Remove #{user.full_name}?" }, class: 'btn btn-danger'
+            +                 %td= link_to 'Remove', remove_user_group_path(@group,user), :method => :delete, :data => { :confirm => "Remove #{user.full_name}?" }, class: 'btn btn-danger btn-sm'
                 .col-md-6
                   .panel.panel-default
                     .panel-heading
                             %th name
                             %th Full name
                             %th Full score
-            -               %th
+            +               %th= link_to 'Remove All', remove_all_problem_group_path(@group), method: :delete, :data => { :confirm => "Remove ALL PROBLEMS from group?" }, class: 'btn btn-danger btn-sm'
                         %tbody
                           - @group.problems.each do |problem|
                               %td= problem.name
                               %td= problem.full_name
                               %td= problem.full_score
-            -                 %td= link_to 'Remove', remove_problem_group_path(@group,problem), :method => :delete, :data => { :confirm => "Remove #{problem.full_name}?" }, class: 'btn btn-danger'
+            +                 %td= link_to 'Remove', remove_problem_group_path(@group,problem), :method => :delete, :data => { :confirm => "Remove #{problem.full_name}?" }, class: 'btn btn-danger btn-sm'

app/views/problems/index.html.haml ¶ +7 -1

                   %th Name
                   %th Full name
                   %th.text-right Full score
+            +     %th
+            +       Submit
+            +       %sup{class: 'text-primary',data: {toggle: 'tooltip'}, title: 'Admin can always submit to any problem' } [?]
                   %th Date added
                   %th.text-center
                     Avail?
                   %tr{:class => "#{(problem.available) ? "success" : "danger"}", :id => "prob-#{problem.id}", :name => "prob-#{problem.id}"}
                     - @problem=problem
                     %td= problem.name #in_place_editor_field :problem, :name, {}, :rows=>1
-            -       %td= problem.full_name #in_place_editor_field :problem, :full_name, {}, :rows=>1
+            +       %td
+            +         = problem.full_name #in_place_editor_field :problem, :full_name, {}, :rows=>1
+            +         = link_to_description_if_any "[#{t 'main.problem_desc'}] <span class='glyphicon glyphicon-file'></span>".html_safe, problem
                     %td.text-right= problem.full_score #in_place_editor_field :problem, :full_score, {}, :rows=>1
+            +       %td= link_to "Submit", direct_edit_problem_submissions_path(problem), class: 'btn btn-xs btn-primary'
                     %td= problem.date_added
                     %td= toggle_button(@problem.available?, toggle_problem_path(@problem), "problem-avail-#{@problem.id}")
                     %td= toggle_button(@problem.view_testcase?, toggle_view_testcase_problem_path(@problem), "problem-view-testcase-#{@problem.id}")

config/routes.rb ¶ +5

                   member do
                     post 'add_user', to: 'groups#add_user', as: 'add_user'
                     delete 'remove_user/:user_id', to: 'groups#remove_user', as: 'remove_user'
+            +       delete 'remove_all_user', to: 'groups#remove_all_user', as: 'remove_all_user'
                     post 'add_problem', to: 'groups#add_problem', as: 'add_problem'
                     delete 'remove_problem/:problem_id', to: 'groups#remove_problem', as: 'remove_problem'
+            +       delete 'remove_all_problem', to: 'groups#remove_all_problem', as: 'remove_all_problem'
+            +     end
+            +     collection do
+            +
                   end
                 end

app/views/graders/submission.html.haml removed ¶ -87

deleted file

Write
Preview

You need to be logged in to leave comments. Login now

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository permissions settings

Sign in to your account

Author

r680:4ce0b8696d06 - Thu, 14 Sep 2017 14:45:10 - 9 files changed: 35 inserted, 138 deleted

Sign in to your account

Commit r680:4ce0b8696d06 public

Author

r680:4ce0b8696d06 - Thu, 14 Sep 2017 14:45:10 - 9 files changed: 35 inserted, 138 deleted

Commit `r680:4ce0b8696d06` public