cafe-grader-web Commit - r210:0c551aa1f64a

cafe-grader-web

Commit `r210:0c551aa1f64a` public

parent | child

Description:

imports test pairs

Commit status:

[Not Reviewed]

References:

default

Diff options:

| | | |

Comments:

0 Commit comments 0 Inline Comments

Unresolved TODOs:

There are no unresolved TODOs

Add another comment

r210:0c551aa1f64a - Sun, 17 Jan 2010 22:49:43 - 4 files changed: 77 inserted, 35 deleted

app/controllers/problems_controller.rb ¶ +3 -7

                 end
                 def do_import
-            -     @problem, import_log = Problem.new_from_import_form_params(params)
+            +     old_problem = Problem.find_by_name(params[:name])
+            +     @problem, import_log = Problem.create_from_import_form_params(params,
+            +                                                                   old_problem)
                   if @problem.errors.length != 0
                     render :action => 'import' and return
                   end
-            -     old_problem = Problem.find_by_name(@problem.name)
                   if old_problem!=nil
-            -       old_problem.full_name = @problem.full_name
-            -       @problem = old_problem
                     flash[:notice] = "The test data has been replaced for problem #{@problem.name}"
                   end
-            -     @problem.save
                   @log = import_log
                 end

app/models/problem.rb ¶ +20 -13

               class Problem < ActiveRecord::Base
                 belongs_to :description
-            -   has_many :test_pairs
+            +   has_many :test_pairs, :dependent => :delete_all
                 validates_presence_of :name
                 validates_format_of :name, :with => /^\w+$/
                   find(:all, :conditions => {:available => true}, :order => "date_added DESC")
                 end
-            -   def self.new_from_import_form_params(params)
+            +   def self.create_from_import_form_params(params, old_problem=nil)
-            -     problem = Problem.new
+            +     problem = old_problem || Problem.new
                   import_params = Problem.extract_params_and_check(params, problem)
                   if not problem.valid?
-            -       return problem
+            +       return problem, 'Error importing'
-            -     end
-            -     importer = TestdataImporter.new
-            -     if not importer.import_from_file(problem.name,
-            -                                      import_params[:file],
-            -                                      import_params[:time_limit],
-            -                                      import_params[:memory_limit])
-            -       problem.errors.add_to_base('Import error.')
                   end
                   problem.full_score = 100
                   problem.test_allowed = true
                   problem.output_only = false
                   problem.available = false
+            +
+            +     if not problem.save
+            +       return problem, 'Error importing'
+            +     end
+            +
+            +     import_to_db = params.has_key? :import_to_db
+            +
+            +     importer = TestdataImporter.new(problem)
+            +
+            +     if not importer.import_from_file(import_params[:file],
+            +                                      import_params[:time_limit],
+            +                                      import_params[:memory_limit],
+            +                                      import_to_db)
+            +       problem.errors.add_to_base('Import error.')
+            +     end
+            +
                   return problem, importer.log_msg
                 end

app/views/problems/import.html.haml ¶ +7 -1

                         %span{:class => 'help'} Leave blank to use the same value as the name above.
                     %tr
                       %td Testdata file:
-            -         %td= file_field_tag 'file'
+            +         %td
+            +           = file_field_tag 'file'
+            +       %tr
+            +         %td
+            +         %td
+            +           = check_box_tag 'import_to_db'
+            +           Import test data to database (for a test-pair task)
                     %tr
                       %td Time limit:
                       %td

lib/testdata_importer.rb ¶ +47 -14

@@ -4,17 +4,33
4		4
5	attr :log_msg	5	attr :log_msg
6		6
7	- def i~~mport_from_fil~~e(problem~~_name~~,	7	+ def initialize(problem)
8	- tempfile,	8	+ @problem = problem
		9	+ end
		10	+
		11	+ def import_from_file(tempfile,
9	time_limit,	12	time_limit,
10	- memory_limit)	13	+ memory_limit,
		14	+ import_to_db=false)
11		15
12	- dirname = ~~TestdataImporter~~.extract(~~problem_name~~, tempfile)	16	+ dirname = extract(tempfile)
13	return false if not dirname	17	return false if not dirname
14	- @log_msg = GraderScript.call_import_problem(problem_name,	18	+ if not import_to_db
15	- dirname,	19	+ @log_msg = GraderScript.call_import_problem(@problem.name,
16	- ~~time_limit~~,	20	+ dirname,
17	- me~~mory~~_limit)	21	+ time_limit,
		22	+ memory_limit)
		23	+ else
		24	+ # Import test data to test pairs.
		25	+
		26	+ @problem.test_pairs.clear
		27	+ if import_test_pairs(dirname)
		28	+ test_pair_count = TestPair.count :conditions => "problem_id = #{@problem.id}"
		29	+ @log_msg = "Importing test pair successful. (#{test_pair_count} test pairs imported)"
		30	+ else
		31	+ @log_msg = "Importing test pair failed. (0 test pairs imported)"
		32	+ end
		33	+ end
18	return true	34	return true
19	end	35	end
20		36
@@ -26,12 +42,11
26	return filename.slice(i..len)	42	return filename.slice(i..len)
27	end	43	end
28		44
29	- def ~~self~~.extract(~~problem_name~~, tempfile)	45	+ def extract(tempfile)
30	- testdata_filename = ~~TestdataImporter~~.save_testdata_file(~~problem_name~~,	46	+ testdata_filename = save_testdata_file(tempfile)
31	- tempfile)
32	ext = TestdataImporter.long_ext(tempfile.original_filename)	47	ext = TestdataImporter.long_ext(tempfile.original_filename)
33		48
34	- extract_dir = File.join(GraderScript.raw_dir, problem_name)	49	+ extract_dir = File.join(GraderScript.raw_dir, @problem.name)
35	begin	50	begin
36	Dir.mkdir extract_dir	51	Dir.mkdir extract_dir
37	rescue Errno::EEXIST	52	rescue Errno::EEXIST
@@ -55,9 +70,9
55	return File.dirname(files[0])	70	return File.dirname(files[0])
56	end	71	end
57		72
58	- def ~~self~~.save_testdata_file(~~problem_name~~, tempfile)	73	+ def save_testdata_file(tempfile)
59	ext = TestdataImporter.long_ext(tempfile.original_filename)	74	ext = TestdataImporter.long_ext(tempfile.original_filename)
60	- testdata_filename = File.join(Dir.tmpdir,"#{problem_name}#{ext}")	75	+ testdata_filename = File.join(Dir.tmpdir,"#{@problem.name}#{ext}")
61		76
62	return nil if tempfile==""	77	return nil if tempfile==""
63		78
@@ -73,4 +88,22
73	return testdata_filename	88	return testdata_filename
74	end	89	end
75		90
		91	+ def import_test_pairs(dirname)
		92	+ test_num = 1
		93	+ while FileTest.exists? "#{dirname}/#{test_num}.in"
		94	+ in_filename = "#{dirname}/#{test_num}.in"
		95	+ sol_filename = "#{dirname}/#{test_num}.sol"
		96	+
		97	+ break if not FileTest.exists? sol_filename
		98	+
		99	+ test_pair = TestPair.new(:input => open(in_filename).read,
		100	+ :solution => open(sol_filename).read,
		101	+ :problem => @problem)
		102	+ break if not test_pair.save
		103	+
		104	+ test_num += 1
		105	+ end
		106	+ return test_num > 1
		107	+ end
		108	+
76	end	109	end

Write
Preview

You need to be logged in to leave comments. Login now

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository permissions settings

Sign in to your account

Author

r210:0c551aa1f64a - Sun, 17 Jan 2010 22:49:43 - 4 files changed: 77 inserted, 35 deleted

Sign in to your account

Commit r210:0c551aa1f64a public

Author

r210:0c551aa1f64a - Sun, 17 Jan 2010 22:49:43 - 4 files changed: 77 inserted, 35 deleted

Commit `r210:0c551aa1f64a` public