cafe-grader-web Commit - r448:f7ee3d7bf71a

cafe-grader-web

Commit `r448:f7ee3d7bf71a` public

parent | child

Description:

update problem stat to show all submissions change view to haml

Commit status:

[Not Reviewed]

References:

algo

Diff options:

| | | |

Comments:

0 Commit comments 0 Inline Comments

Unresolved TODOs:

There are no unresolved TODOs

Add another comment

r448:f7ee3d7bf71a - Sat, 20 Sep 2014 06:32:42 - 4 files changed: 36 inserted, 31 deleted

app/views/problems/stat.html.haml created 644 ¶ +34

@@ -0,0 +1,34
	1	+ :css
	2	+ .fix-width {
	3	+ font-family: "Consolas, Monaco, Droid Sans Mono,Mono, Monospace,Courier"
	4	+ }
	5	+
	6	+ %h1 Problem stat: #{@problem.name}
	7	+ %h2 Overview
	8	+
	9	+ %h2 Submissions
	10	+ - if @submissions and @submissions.count > 0
	11	+ %table.info#main_table
	12	+ %thead
	13	+ %tr.info-head
	14	+ %th ID
	15	+ %th Login
	16	+ %th Name
	17	+ %th Submitted_at
	18	+ %th Points
	19	+ %th comment
	20	+ %tbody
	21	+ - row_odd,curr = true,''
	22	+ - @submissions.each do \|sub\|
	23	+ - next unless sub.user
	24	+ - row_odd,curr = !row_odd, sub.user if curr != sub.user
	25	+ %tr{class: row_odd ? "info-odd" : "info-even"}
	26	+ %td= link_to sub.id, controller: 'graders', action: 'submission', id: sub.id
	27	+ %td= link_to sub.user.login, controller: :users, action: :profile, id: sub.user.id
	28	+ %td= sub.user.full_name
	29	+ %td= time_ago_in_words(sub.submitted_at) + " ago"
	30	+ %td= sub.points
	31	+ %td.fix-width= sub.grader_comment
	32	+ - else
	33	+ No submission
	34	+

app/controllers/problems_controller.rb ¶ +1 -1

                   elsif @description!=nil
                     if !@description.update_attributes(params[:description])
                       flash[:notice] = 'Error saving description'
                       render :action => 'edit' and return
                     end
                   end
                   if @problem.update_attributes(params[:problem])
                     flash[:notice] = 'Problem was successfully updated.'
                     redirect_to :action => 'show', :id => @problem
                   else
                     render :action => 'edit'
                   end
                 end
                 def destroy
                   Problem.find(params[:id]).destroy
                   redirect_to :action => 'list'
                 end
                 def toggle
                   @problem = Problem.find(params[:id])
                   @problem.available = !(@problem.available)
                   @problem.save
                 end
                 def turn_all_off
                   Problem.find(:all,
                                :conditions => "available = 1").each do |problem|
                     problem.available = false
                     problem.save
                   end
                   redirect_to :action => 'list'
                 end
                 def turn_all_on
                   Problem.find(:all,
                                :conditions => "available = 0").each do |problem|
                     problem.available = true
                     problem.save
                   end
                   redirect_to :action => 'list'
                 end
                 def stat
                   @problem = Problem.find(params[:id])
                   if !@problem.available
                     redirect_to :controller => 'main', :action => 'list'
                   else
-            -       @submissions = Submission.find_all_last_by_problem(params[:id])
+            +       @submissions = Submission.includes(:user).where(problem_id: params[:id]).order(:user_id,:id)
                   end
                 end
                 def manage
                   @problems = Problem.find(:all, :order => 'date_added DESC')
                 end
                 def do_manage
                   if params.has_key? 'change_date_added'
                     change_date_added
                   else params.has_key? 'add_to_contest'
                     add_to_contest
                   end
                   redirect_to :action => 'manage'
                 end
                 def import
                   @allow_test_pair_import = allow_test_pair_import?
                 end
                 def do_import
                   old_problem = Problem.find_by_name(params[:name])
                   if !allow_test_pair_import? and params.has_key? :import_to_db
                     params.delete :import_to_db
                   end
                   @problem, import_log = Problem.create_from_import_form_params(params,
                                                                                 old_problem)
                   if !@problem.errors.empty?
                     render :action => 'import' and return
                   end
                   if old_problem!=nil
                     flash[:notice] = "The test data has been replaced for problem #{@problem.name}"
                   end
                   @log = import_log
                 end
                 def remove_contest
                   problem = Problem.find(params[:id])
                   contest = Contest.find(params[:contest_id])
                   if problem!=nil and contest!=nil
                     problem.contests.delete(contest)
                   end
                   redirect_to :action => 'manage'
                 end
                 ##################################

app/models/submission.rb ¶ +1 -1

               class Submission < ActiveRecord::Base
                 belongs_to :language
                 belongs_to :problem
                 belongs_to :user
                 before_validation :assign_problem
                 before_validation :assign_language
                 validates_presence_of :source
                 validates_length_of :source, :maximum => 100_000, :allow_blank => true, :message => 'too long'
                 validates_length_of :source, :minimum => 1, :allow_blank => true, :message => 'too short'
                 validate :must_have_valid_problem
                 validate :must_specify_language
                 before_save :assign_latest_number_if_new_recond
                 def self.find_last_by_user_and_problem(user_id, problem_id)
                   last_sub = find(:first,
                                   :conditions => {:user_id => user_id,
                                     :problem_id => problem_id},
                                   :order => 'number DESC')
                   return last_sub
                 end
                 def self.find_all_last_by_problem(problem_id)
                   # need to put in SQL command, maybe there's a better way
-            -     Submission.find_by_sql("SELECT * FROM submissions " +
+            +     Submission.includes(:user).find_by_sql("SELECT * FROM submissions " +
               			   "WHERE id = " +
               			   "(SELECT MAX(id) FROM submissions AS subs " +
               			   "WHERE subs.user_id = submissions.user_id AND " +
                                          "problem_id = " + problem_id.to_s + " " +
               			   "GROUP BY user_id) " +
                                          "ORDER BY user_id")
                 end
                 def self.find_in_range_by_user_and_problem(user_id, problem_id,since_id,until_id)
                   records = Submission.where(problem_id: problem_id,user_id: user_id)
                   records = records.where('id >= ?',since_id) if since_id > 0
                   records = records.where('id <= ?',until_id) if until_id > 0
                   records.all
                 end
                 def self.find_last_for_all_available_problems(user_id)
                   submissions = Array.new
                   problems = Problem.find_available_problems
                   problems.each do |problem|
                     sub = Submission.find_last_by_user_and_problem(user_id, problem.id)
                     submissions << sub if sub!=nil
                   end
                   submissions
                 end
                 def self.find_by_user_problem_number(user_id, problem_id, number)
                   Submission.find(:first,
                                   :conditions => {
                                     :user_id => user_id,
                                     :problem_id => problem_id,
                                     :number => number
                                   })
                 end
                 def self.find_all_by_user_problem(user_id, problem_id)
                   Submission.find(:all,
                                   :conditions => {
                                     :user_id => user_id,
                                     :problem_id => problem_id,
                                   })
                 end
                 def download_filename
                   if self.problem.output_only
                     return self.source_filename
                   else
                     timestamp = self.submitted_at.localtime.strftime("%H%M%S")
                     return "#{self.problem.name}-#{timestamp}.#{self.language.ext}"

app/views/problems/stat.html.erb removed ¶ -29

deleted file

Write
Preview

You need to be logged in to leave comments. Login now

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository permissions settings

Sign in to your account

Author

r448:f7ee3d7bf71a - Sat, 20 Sep 2014 06:32:42 - 4 files changed: 36 inserted, 31 deleted

Sign in to your account

Commit r448:f7ee3d7bf71a public

Author

r448:f7ee3d7bf71a - Sat, 20 Sep 2014 06:32:42 - 4 files changed: 36 inserted, 31 deleted

Commit `r448:f7ee3d7bf71a` public