Description:
fixed form_tag bug in views
Commit status:
[Not Reviewed]
References:
Diff options:
Comments:
0 Commit comments
0 Inline Comments
Unresolved TODOs:
There are no unresolved TODOs
r340:f512a445945b - - 2 files changed: 3 inserted, 3 deleted
@@ -1,348 +1,348 | |||
|
1 | 1 | class UserAdminController < ApplicationController |
|
2 | 2 | |
|
3 | 3 | include MailHelperMethods |
|
4 | 4 | |
|
5 | 5 | before_filter :admin_authorization |
|
6 | 6 | |
|
7 | 7 | # GETs should be safe (see http://www.w3.org/2001/tag/doc/whenToUseGet.html) |
|
8 | 8 | verify :method => :post, :only => [ :destroy, |
|
9 | 9 | :create, :create_from_list, |
|
10 | 10 | :update, |
|
11 | 11 | :manage_contest, |
|
12 | 12 | :bulk_mail |
|
13 | 13 | ], |
|
14 | 14 | :redirect_to => { :action => :list } |
|
15 | 15 | |
|
16 | 16 | def index |
|
17 | 17 | list |
|
18 | 18 | render :action => 'list' |
|
19 | 19 | end |
|
20 | 20 | |
|
21 | 21 | def list |
|
22 | 22 | @user_count = User.count |
|
23 | 23 | if params[:page] == 'all' |
|
24 | 24 | @users = User.all |
|
25 | 25 | @paginated = false |
|
26 | 26 | else |
|
27 | 27 | @users = User.paginate :page => params[:page] |
|
28 | 28 | @paginated = true |
|
29 | 29 | end |
|
30 | 30 | @hidden_columns = ['hashed_password', 'salt', 'created_at', 'updated_at'] |
|
31 | 31 | @contests = Contest.enabled |
|
32 | 32 | end |
|
33 | 33 | |
|
34 | 34 | def active |
|
35 | 35 | sessions = ActiveRecord::SessionStore::Session.find(:all, :conditions => ["updated_at >= ?", 60.minutes.ago]) |
|
36 | 36 | @users = [] |
|
37 | 37 | sessions.each do |session| |
|
38 | 38 | if session.data[:user_id] |
|
39 | 39 | @users << User.find(session.data[:user_id]) |
|
40 | 40 | end |
|
41 | 41 | end |
|
42 | 42 | end |
|
43 | 43 | |
|
44 | 44 | def show |
|
45 | 45 | @user = User.find(params[:id]) |
|
46 | 46 | end |
|
47 | 47 | |
|
48 | 48 | def new |
|
49 | 49 | @user = User.new |
|
50 | 50 | end |
|
51 | 51 | |
|
52 | 52 | def create |
|
53 | 53 | @user = User.new(params[:user]) |
|
54 | 54 | @user.activated = true |
|
55 | 55 | if @user.save |
|
56 | 56 | flash[:notice] = 'User was successfully created.' |
|
57 | 57 | redirect_to :action => 'list' |
|
58 | 58 | else |
|
59 | 59 | render :action => 'new' |
|
60 | 60 | end |
|
61 | 61 | end |
|
62 | 62 | |
|
63 | 63 | def create_from_list |
|
64 | 64 | lines = params[:user_list] |
|
65 | 65 | |
|
66 | 66 | note = [] |
|
67 | 67 | |
|
68 | 68 | lines.split("\n").each do |line| |
|
69 | 69 | items = line.chomp.split(',') |
|
70 | 70 | if items.length>=2 |
|
71 | 71 | login = items[0] |
|
72 | 72 | full_name = items[1] |
|
73 | 73 | |
|
74 | 74 | added_random_password = false |
|
75 | 75 | if items.length>=3 |
|
76 | 76 | password = items[2].chomp(" ") |
|
77 | 77 | user_alias = (items.length>=4) ? items[3] : login |
|
78 | 78 | else |
|
79 | 79 | password = random_password |
|
80 | 80 | user_alias = (items.length>=4) ? items[3] : login |
|
81 | 81 | added_random_password = true |
|
82 | 82 | end |
|
83 | 83 | |
|
84 | 84 | user = User.new({:login => login, |
|
85 | 85 | :full_name => full_name, |
|
86 | 86 | :password => password, |
|
87 | 87 | :password_confirmation => password, |
|
88 | 88 | :alias => user_alias}) |
|
89 | 89 | user.activated = true |
|
90 | 90 | user.save |
|
91 | 91 | |
|
92 | 92 | if added_random_password |
|
93 | 93 | note << "'#{login}' (+)" |
|
94 | 94 | else |
|
95 | 95 | note << login |
|
96 | 96 | end |
|
97 | 97 | end |
|
98 | 98 | end |
|
99 | 99 | flash[:notice] = 'User(s) ' + note.join(', ') + |
|
100 | 100 | ' were successfully created. ' + |
|
101 | 101 | '( (+) - created with random passwords.)' |
|
102 | 102 | redirect_to :action => 'list' |
|
103 | 103 | end |
|
104 | 104 | |
|
105 | 105 | def edit |
|
106 | 106 | @user = User.find(params[:id]) |
|
107 | 107 | end |
|
108 | 108 | |
|
109 | 109 | def update |
|
110 | 110 | @user = User.find(params[:id]) |
|
111 | 111 | if @user.update_attributes(params[:user]) |
|
112 | 112 | flash[:notice] = 'User was successfully updated.' |
|
113 | 113 | redirect_to :action => 'show', :id => @user |
|
114 | 114 | else |
|
115 | 115 | render :action => 'edit' |
|
116 | 116 | end |
|
117 | 117 | end |
|
118 | 118 | |
|
119 | 119 | def destroy |
|
120 | 120 | User.find(params[:id]).destroy |
|
121 | 121 | redirect_to :action => 'list' |
|
122 | 122 | end |
|
123 | 123 | |
|
124 | 124 | def user_stat |
|
125 | 125 | @problems = Problem.find_available_problems |
|
126 | 126 | @users = User.find(:all, :include => [:contests, :contest_stat]) |
|
127 | 127 | @scorearray = Array.new |
|
128 | 128 | @users.each do |u| |
|
129 | 129 | ustat = Array.new |
|
130 | 130 | ustat[0] = u |
|
131 | 131 | @problems.each do |p| |
|
132 | 132 | sub = Submission.find_last_by_user_and_problem(u.id,p.id) |
|
133 | 133 | if (sub!=nil) and (sub.points!=nil) |
|
134 | 134 | ustat << [(sub.points.to_f*100/p.full_score).round, (sub.points>=p.full_score)] |
|
135 | 135 | else |
|
136 | 136 | ustat << [0,false] |
|
137 | 137 | end |
|
138 | 138 | end |
|
139 | 139 | @scorearray << ustat |
|
140 | 140 | end |
|
141 | 141 | end |
|
142 | 142 | |
|
143 | 143 | def import |
|
144 | 144 | if params[:file]=='' |
|
145 | 145 | flash[:notice] = 'Error importing no file' |
|
146 | 146 | redirect_to :action => 'list' and return |
|
147 | 147 | end |
|
148 | 148 | import_from_file(params[:file]) |
|
149 | 149 | end |
|
150 | 150 | |
|
151 | 151 | def random_all_passwords |
|
152 | 152 | users = User.find(:all) |
|
153 | 153 | @prefix = params[:prefix] || '' |
|
154 | 154 | @non_admin_users = User.find_non_admin_with_prefix(@prefix) |
|
155 | 155 | @changed = false |
|
156 |
- if request.request_method == |
|
|
156 | + if request.request_method == 'POST' | |
|
157 | 157 | @non_admin_users.each do |user| |
|
158 | 158 | password = random_password |
|
159 | 159 | user.password = password |
|
160 | 160 | user.password_confirmation = password |
|
161 | 161 | user.save |
|
162 | 162 | end |
|
163 | 163 | @changed = true |
|
164 | 164 | end |
|
165 | 165 | end |
|
166 | 166 | |
|
167 | 167 | # contest management |
|
168 | 168 | |
|
169 | 169 | def contests |
|
170 | 170 | @contest, @users = find_contest_and_user_from_contest_id(params[:id]) |
|
171 | 171 | @contests = Contest.enabled |
|
172 | 172 | end |
|
173 | 173 | |
|
174 | 174 | def assign_from_list |
|
175 | 175 | contest_id = params[:users_contest_id] |
|
176 | 176 | org_contest, users = find_contest_and_user_from_contest_id(contest_id) |
|
177 | 177 | contest = Contest.find(params[:new_contest][:id]) |
|
178 | 178 | if !contest |
|
179 | 179 | flash[:notice] = 'Error: no contest' |
|
180 | 180 | redirect_to :action => 'contests', :id =>contest_id |
|
181 | 181 | end |
|
182 | 182 | |
|
183 | 183 | note = [] |
|
184 | 184 | users.each do |u| |
|
185 | 185 | u.contests = [contest] |
|
186 | 186 | note << u.login |
|
187 | 187 | end |
|
188 | 188 | flash[:notice] = 'User(s) ' + note.join(', ') + |
|
189 | 189 | " were successfully reassigned to #{contest.title}." |
|
190 | 190 | redirect_to :action => 'contests', :id =>contest.id |
|
191 | 191 | end |
|
192 | 192 | |
|
193 | 193 | def add_to_contest |
|
194 | 194 | user = User.find(params[:id]) |
|
195 | 195 | contest = Contest.find(params[:contest_id]) |
|
196 | 196 | if user and contest |
|
197 | 197 | user.contests << contest |
|
198 | 198 | end |
|
199 | 199 | redirect_to :action => 'list' |
|
200 | 200 | end |
|
201 | 201 | |
|
202 | 202 | def remove_from_contest |
|
203 | 203 | user = User.find(params[:id]) |
|
204 | 204 | contest = Contest.find(params[:contest_id]) |
|
205 | 205 | if user and contest |
|
206 | 206 | user.contests.delete(contest) |
|
207 | 207 | end |
|
208 | 208 | redirect_to :action => 'list' |
|
209 | 209 | end |
|
210 | 210 | |
|
211 | 211 | def contest_management |
|
212 | 212 | end |
|
213 | 213 | |
|
214 | 214 | def manage_contest |
|
215 | 215 | contest = Contest.find(params[:contest][:id]) |
|
216 | 216 | if !contest |
|
217 | 217 | flash[:notice] = 'You did not choose the contest.' |
|
218 | 218 | redirect_to :action => 'contest_management' and return |
|
219 | 219 | end |
|
220 | 220 | |
|
221 | 221 | operation = params[:operation] |
|
222 | 222 | |
|
223 | 223 | if not ['add','remove','assign'].include? operation |
|
224 | 224 | flash[:notice] = 'You did not choose the operation to perform.' |
|
225 | 225 | redirect_to :action => 'contest_management' and return |
|
226 | 226 | end |
|
227 | 227 | |
|
228 | 228 | lines = params[:login_list] |
|
229 | 229 | if !lines or lines.blank? |
|
230 | 230 | flash[:notice] = 'You entered an empty list.' |
|
231 | 231 | redirect_to :action => 'contest_management' and return |
|
232 | 232 | end |
|
233 | 233 | |
|
234 | 234 | note = [] |
|
235 | 235 | users = [] |
|
236 | 236 | lines.split("\n").each do |line| |
|
237 | 237 | user = User.find_by_login(line.chomp) |
|
238 | 238 | if user |
|
239 | 239 | if operation=='add' |
|
240 | 240 | if ! user.contests.include? contest |
|
241 | 241 | user.contests << contest |
|
242 | 242 | end |
|
243 | 243 | elsif operation=='remove' |
|
244 | 244 | user.contests.delete(contest) |
|
245 | 245 | else |
|
246 | 246 | user.contests = [contest] |
|
247 | 247 | end |
|
248 | 248 | |
|
249 | 249 | if params[:reset_timer] |
|
250 | 250 | user.contest_stat.forced_logout = true |
|
251 | 251 | user.contest_stat.reset_timer_and_save |
|
252 | 252 | end |
|
253 | 253 | |
|
254 | 254 | if params[:notification_emails] |
|
255 | 255 | send_contest_update_notification_email(user, contest) |
|
256 | 256 | end |
|
257 | 257 | |
|
258 | 258 | note << user.login |
|
259 | 259 | users << user |
|
260 | 260 | end |
|
261 | 261 | end |
|
262 | 262 | |
|
263 | 263 | if params[:reset_timer] |
|
264 | 264 | logout_users(users) |
|
265 | 265 | end |
|
266 | 266 | |
|
267 | 267 | flash[:notice] = 'User(s) ' + note.join(', ') + |
|
268 | 268 | ' were successfully modified. ' |
|
269 | 269 | redirect_to :action => 'contest_management' |
|
270 | 270 | end |
|
271 | 271 | |
|
272 | 272 | # admin management |
|
273 | 273 | |
|
274 | 274 | def admin |
|
275 | 275 | @admins = User.find(:all).find_all {|user| user.admin? } |
|
276 | 276 | end |
|
277 | 277 | |
|
278 | 278 | def grant_admin |
|
279 | 279 | login = params[:login] |
|
280 | 280 | user = User.find_by_login(login) |
|
281 | 281 | if user!=nil |
|
282 | 282 | admin_role = Role.find_by_name('admin') |
|
283 | 283 | user.roles << admin_role |
|
284 | 284 | else |
|
285 | 285 | flash[:notice] = 'Unknown user' |
|
286 | 286 | end |
|
287 | 287 | flash[:notice] = 'User added as admins' |
|
288 | 288 | redirect_to :action => 'admin' |
|
289 | 289 | end |
|
290 | 290 | |
|
291 | 291 | def revoke_admin |
|
292 | 292 | user = User.find(params[:id]) |
|
293 | 293 | if user==nil |
|
294 | 294 | flash[:notice] = 'Unknown user' |
|
295 | 295 | redirect_to :action => 'admin' and return |
|
296 | 296 | elsif user.login == 'root' |
|
297 | 297 | flash[:notice] = 'You cannot revoke admisnistrator permission from root.' |
|
298 | 298 | redirect_to :action => 'admin' and return |
|
299 | 299 | end |
|
300 | 300 | |
|
301 | 301 | admin_role = Role.find_by_name('admin') |
|
302 | 302 | user.roles.delete(admin_role) |
|
303 | 303 | flash[:notice] = 'User permission revoked' |
|
304 | 304 | redirect_to :action => 'admin' |
|
305 | 305 | end |
|
306 | 306 | |
|
307 | 307 | # mass mailing |
|
308 | 308 | |
|
309 | 309 | def mass_mailing |
|
310 | 310 | end |
|
311 | 311 | |
|
312 | 312 | def bulk_mail |
|
313 | 313 | lines = params[:login_list] |
|
314 | 314 | if !lines or lines.blank? |
|
315 | 315 | flash[:notice] = 'You entered an empty list.' |
|
316 | 316 | redirect_to :action => 'mass_mailing' and return |
|
317 | 317 | end |
|
318 | 318 | |
|
319 | 319 | mail_subject = params[:subject] |
|
320 | 320 | if !mail_subject or mail_subject.blank? |
|
321 | 321 | flash[:notice] = 'You entered an empty mail subject.' |
|
322 | 322 | redirect_to :action => 'mass_mailing' and return |
|
323 | 323 | end |
|
324 | 324 | |
|
325 | 325 | mail_body = params[:email_body] |
|
326 | 326 | if !mail_body or mail_body.blank? |
|
327 | 327 | flash[:notice] = 'You entered an empty mail body.' |
|
328 | 328 | redirect_to :action => 'mass_mailing' and return |
|
329 | 329 | end |
|
330 | 330 | |
|
331 | 331 | note = [] |
|
332 | 332 | users = [] |
|
333 | 333 | lines.split("\n").each do |line| |
|
334 | 334 | user = User.find_by_login(line.chomp) |
|
335 | 335 | if user |
|
336 | 336 | send_mail(user.email, mail_subject, mail_body) |
|
337 | 337 | note << user.login |
|
338 | 338 | end |
|
339 | 339 | end |
|
340 | 340 | |
|
341 | 341 | flash[:notice] = 'User(s) ' + note.join(', ') + |
|
342 | 342 | ' were successfully modified. ' |
|
343 | 343 | redirect_to :action => 'mass_mailing' |
|
344 | 344 | end |
|
345 | 345 | |
|
346 | 346 | protected |
|
347 | 347 | |
|
348 | 348 | def random_password(length=5) |
@@ -1,39 +1,39 | |||
|
1 | 1 | %h1 Random user passwords |
|
2 | 2 | |
|
3 | 3 | -if @changed |
|
4 | 4 | %p |
|
5 | 5 | %b Done! |
|
6 | 6 | Here's a new password list. |
|
7 | 7 | Go back to |
|
8 | 8 | = (link_to '[user list]', :action => 'index') + '.' |
|
9 | 9 | %br/ |
|
10 | 10 | %table |
|
11 | 11 | %tr |
|
12 | 12 | %th Login |
|
13 | 13 | %th Fullname |
|
14 | 14 | %th Password |
|
15 | 15 | -for u in @non_admin_users |
|
16 | 16 | %tr |
|
17 | 17 | %td= u.login |
|
18 | 18 | %td= u.full_name |
|
19 | 19 | %td |
|
20 | 20 | %tt= u.password |
|
21 | 21 | |
|
22 | 22 | -else |
|
23 | 23 | -if @prefix!='' |
|
24 | 24 | Current prefix: |
|
25 | 25 | = @prefix |
|
26 |
- |
|
|
26 | + = form_tag((url_for :action => 'random_all_passwords'), :method => 'get') do | |
|
27 | 27 | Change prefix |
|
28 | 28 | =text_field_tag 'prefix' |
|
29 | 29 | =submit_tag 'Change' |
|
30 | 30 | |
|
31 | 31 | This will change passwords of the following users. |
|
32 | 32 | %ul |
|
33 | 33 | -for u in @non_admin_users |
|
34 | 34 | %li= u.login |
|
35 | 35 | |
|
36 |
- |
|
|
36 | + = form_tag((url_for :action => 'random_all_passwords'), :method => 'post') do | |
|
37 | 37 | =hidden_field_tag 'prefix', @prefix |
|
38 | 38 | Are you sure? |
|
39 | 39 | =submit_tag 'Go ahead' |
You need to be logged in to leave comments.
Login now