cafe-grader-web Commit - r523:e5c66a78e3f9

cafe-grader-web

Commit `r523:e5c66a78e3f9` public

parent | child

Description:

fix error when problem.full_score is nil. More has to be done to prevent problem.full_score being nil

Commit status:

[Not Reviewed]

References:

java

Diff options:

| | | |

Comments:

0 Commit comments 0 Inline Comments

Unresolved TODOs:

There are no unresolved TODOs

Add another comment

r523:e5c66a78e3f9 - Sat, 20 Jun 2015 03:30:02 - 2 files changed: 13 inserted, 12 deleted

app/controllers/user_admin_controller.rb ¶ +1 -1

                     ustat[0] = u
                     @problems.each do |p|
                       sub = Submission.find_last_by_user_and_problem(u.id,p.id)
-            -         if (sub!=nil) and (sub.points!=nil)
+            +         if (sub!=nil) and (sub.points!=nil) and p and p.full_score
                         ustat << [(sub.points.to_f*100/p.full_score).round, (sub.points>=p.full_score)]
                       else
                         ustat << [0,false]

db/schema.rb ¶ +12 -11

                 create_table "announcements", :force => true do |t|
                   t.string   "author"
-            -     t.text     "body"
+            +     t.text     "body",         :limit => 16777215
                   t.boolean  "published"
                   t.datetime "created_at",                      :null => false
                   t.datetime "updated_at",                      :null => false
                 end
                 create_table "descriptions", :force => true do |t|
-            -     t.text     "body"
+            +     t.text     "body",       :limit => 16777215
                   t.boolean  "markdowned"
                   t.datetime "created_at", :null => false
                   t.datetime "updated_at", :null => false
                   t.string   "value"
                   t.datetime "created_at",  :null => false
                   t.datetime "updated_at",  :null => false
-            -     t.text     "description"
+            +     t.text     "description", :limit => 16777215
                 end
                 create_table "grader_processes", :force => true do |t|
                   t.integer  "sender_id"
                   t.integer  "receiver_id"
                   t.integer  "replying_message_id"
-            -     t.text     "body"
+            +     t.text     "body",                :limit => 16777215
                   t.boolean  "replied"
                   t.datetime "created_at",          :null => false
                   t.datetime "updated_at",          :null => false
                 create_table "sessions", :force => true do |t|
                   t.string   "session_id"
-            -     t.text     "data"
+            +     t.text     "data",       :limit => 16777215
                   t.datetime "updated_at"
                 end
                   t.integer  "user_id"
                   t.integer  "problem_id"
                   t.integer  "language_id"
-            -     t.text     "source"
+            +     t.text     "source",                :limit => 16777215
                   t.binary   "binary"
                   t.datetime "submitted_at"
                   t.datetime "compiled_at"
-            -     t.text     "compiler_message"
+            +     t.text     "compiler_message",      :limit => 16777215
                   t.datetime "graded_at"
                   t.integer  "points"
-            -     t.text     "grader_comment"
+            +     t.text     "grader_comment",        :limit => 16777215
                   t.integer  "number"
                   t.string   "source_filename"
                   t.float    "max_runtime"
                 create_table "test_pairs", :force => true do |t|
                   t.integer  "problem_id"
-            -     t.text     "input",      :limit => 16777215
-            -     t.text     "solution",   :limit => 16777215
+            +     t.text     "input",      :limit => 2147483647
+            +     t.text     "solution",   :limit => 2147483647
                   t.datetime "created_at",                     :null => false
                   t.datetime "updated_at",                     :null => false
                 end
                   t.datetime "updated_at",       :null => false
                   t.datetime "submitted_at"
                   t.datetime "compiled_at"
-            -     t.text     "compiler_message"
+            +     t.text     "compiler_message", :limit => 16777215
                   t.datetime "graded_at"
                   t.string   "grader_comment"
                   t.datetime "created_at",       :null => false
                   t.boolean  "activated",                     :default => false
                   t.datetime "created_at"
                   t.datetime "updated_at"
+            +     t.string   "section"
                   t.boolean  "enabled",                       :default => true
                   t.string   "remark"
                 end

Write
Preview

You need to be logged in to leave comments. Login now

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository permissions settings

Sign in to your account

Author

r523:e5c66a78e3f9 - Sat, 20 Jun 2015 03:30:02 - 2 files changed: 13 inserted, 12 deleted

Sign in to your account

Commit r523:e5c66a78e3f9 public

Author

r523:e5c66a78e3f9 - Sat, 20 Jun 2015 03:30:02 - 2 files changed: 13 inserted, 12 deleted

Commit `r523:e5c66a78e3f9` public