cafe-grader-web

Commit r812:e2597379728c public

parent | child
Description:
fix bugs when user creation error
Commit status:
[Not Reviewed]
References:
default
Diff options:
Raw Diff | Patch Diff | Download Diff | Ignore whitespace | Increase context
Comments:
0 Commit comments 0 Inline Comments
Unresolved TODOs:
There are no unresolved TODOs
Side by Side Unified
Expand All Files Collapse All Files Wide Mode Diff
Add another comment
Browse Files

r812:e2597379728c - - 1 file changed: 1 inserted, 1 deleted

Show file before | Show file after | Raw diff | Download diff | Ignore whitespace Increase context Show commentsHide comments
@@ -1,557 +1,557
1 1 require 'csv'
2 2
3 3 class UserAdminController < ApplicationController
4 4
5 5 include MailHelperMethods
6 6
7 7 before_action :admin_authorization
8 8
9 9 def index
10 10 @user_count = User.count
11 11 @users = User.all
12 12 @hidden_columns = ['hashed_password', 'salt', 'created_at', 'updated_at']
13 13 @contests = Contest.enabled
14 14 end
15 15
16 16 def active
17 17 sessions = ActiveRecord::SessionStore::Session.where("updated_at >= ?", 60.minutes.ago)
18 18 @users = []
19 19 sessions.each do |session|
20 20 if session.data[:user_id]
21 21 @users << User.find(session.data[:user_id])
22 22 end
23 23 end
24 24 end
25 25
26 26 def show
27 27 @user = User.find(params[:id])
28 28 end
29 29
30 30 def new
31 31 @user = User.new
32 32 end
33 33
34 34 def create
35 35 @user = User.new(user_params)
36 36 @user.activated = true
37 37 if @user.save
38 38 flash[:notice] = 'User was successfully created.'
39 39 redirect_to :action => 'index'
40 40 else
41 41 render :action => 'new'
42 42 end
43 43 end
44 44
45 45 def clear_last_ip
46 46 @user = User.find(params[:id])
47 47 @user.last_ip = nil
48 48 @user.save
49 49 redirect_to action: 'index', page: params[:page]
50 50 end
51 51
52 52 def create_from_list
53 53 lines = params[:user_list]
54 54
55 55
56 56 res = User.create_from_list(lines)
57 57 error_logins = res[:error_logins]
58 58 error_msg = res[:first_error]
59 59 ok_user = res[:created_users]
60 60
61 61
62 62 #add to group
63 63 if params[:add_to_group]
64 64 group = Group.find_by(id: params[:group_id])&.add_users_skip_existing(ok_user)
65 65 end
66 66
67 67 # show flash
68 68 if ok_user.count > 0
69 69 flash[:success] = "#{ok_user.count} user(s) was created or updated successfully"
70 70 end
71 71 if error_logins.size > 0
72 - flash[:error] = "Following user(s) failed to be created: " + error_note.join(', ') + ". The error of the first failed one are: " + error_msg;
72 + flash[:error] = "Following user(s) failed to be created: " + error_logins.join(', ') + ". The error of the first failed one are: " + error_msg;
73 73 end
74 74 redirect_to :action => 'index'
75 75 end
76 76
77 77 def edit
78 78 @user = User.find(params[:id])
79 79 end
80 80
81 81 def update
82 82 @user = User.find(params[:id])
83 83 if @user.update_attributes(user_params)
84 84 flash[:notice] = 'User was successfully updated.'
85 85 redirect_to :action => 'show', :id => @user
86 86 else
87 87 render :action => 'edit'
88 88 end
89 89 end
90 90
91 91 def destroy
92 92 User.find(params[:id]).destroy
93 93 redirect_to :action => 'index'
94 94 end
95 95
96 96 def user_stat
97 97 if params[:commit] == 'download csv'
98 98 @problems = Problem.all
99 99 else
100 100 @problems = Problem.available_problems
101 101 end
102 102 @users = User.includes(:contests, :contest_stat).where(enabled: true)
103 103 @scorearray = Array.new
104 104 @users.each do |u|
105 105 ustat = Array.new
106 106 ustat[0] = u
107 107 @problems.each do |p|
108 108 sub = Submission.find_last_by_user_and_problem(u.id,p.id)
109 109 if (sub!=nil) and (sub.points!=nil) and p and p.full_score
110 110 ustat << [(sub.points.to_f*100/p.full_score).round, (sub.points>=p.full_score)]
111 111 else
112 112 ustat << [0,false]
113 113 end
114 114 end
115 115 @scorearray << ustat
116 116 end
117 117 if params[:commit] == 'download csv' then
118 118 csv = gen_csv_from_scorearray(@scorearray,@problems)
119 119 send_data csv, filename: 'last_score.csv'
120 120 else
121 121 render template: 'user_admin/user_stat'
122 122 end
123 123 end
124 124
125 125 def user_stat_max
126 126 if params[:commit] == 'download csv'
127 127 @problems = Problem.all
128 128 else
129 129 @problems = Problem.available_problems
130 130 end
131 131 @users = User.includes(:contests).includes(:contest_stat).all
132 132 @scorearray = Array.new
133 133 #set up range from param
134 134 since_id = params.fetch(:since_id, 0).to_i
135 135 until_id = params.fetch(:until_id, 0).to_i
136 136 @users.each do |u|
137 137 ustat = Array.new
138 138 ustat[0] = u
139 139 @problems.each do |p|
140 140 max_points = 0
141 141 Submission.find_in_range_by_user_and_problem(u.id,p.id,since_id,until_id).each do |sub|
142 142 max_points = sub.points if sub and sub.points and (sub.points > max_points)
143 143 end
144 144 ustat << [(max_points.to_f*100/p.full_score).round, (max_points>=p.full_score)]
145 145 end
146 146 @scorearray << ustat
147 147 end
148 148
149 149 if params[:commit] == 'download csv' then
150 150 csv = gen_csv_from_scorearray(@scorearray,@problems)
151 151 send_data csv, filename: 'max_score.csv'
152 152 else
153 153 render template: 'user_admin/user_stat'
154 154 end
155 155 end
156 156
157 157 def import
158 158 if params[:file]==''
159 159 flash[:notice] = 'Error importing no file'
160 160 redirect_to :action => 'index' and return
161 161 end
162 162 import_from_file(params[:file])
163 163 end
164 164
165 165 def random_all_passwords
166 166 users = User.all
167 167 @prefix = params[:prefix] || ''
168 168 @non_admin_users = User.find_non_admin_with_prefix(@prefix)
169 169 @changed = false
170 170 if params[:commit] == 'Go ahead'
171 171 @non_admin_users.each do |user|
172 172 password = random_password
173 173 user.password = password
174 174 user.password_confirmation = password
175 175 user.save
176 176 end
177 177 @changed = true
178 178 end
179 179 end
180 180
181 181 # contest management
182 182
183 183 def contests
184 184 @contest, @users = find_contest_and_user_from_contest_id(params[:id])
185 185 @contests = Contest.enabled
186 186 end
187 187
188 188 def assign_from_list
189 189 contest_id = params[:users_contest_id]
190 190 org_contest, users = find_contest_and_user_from_contest_id(contest_id)
191 191 contest = Contest.find(params[:new_contest][:id])
192 192 if !contest
193 193 flash[:notice] = 'Error: no contest'
194 194 redirect_to :action => 'contests', :id =>contest_id
195 195 end
196 196
197 197 note = []
198 198 users.each do |u|
199 199 u.contests = [contest]
200 200 note << u.login
201 201 end
202 202 flash[:notice] = 'User(s) ' + note.join(', ') +
203 203 " were successfully reassigned to #{contest.title}."
204 204 redirect_to :action => 'contests', :id =>contest.id
205 205 end
206 206
207 207 def add_to_contest
208 208 user = User.find(params[:id])
209 209 contest = Contest.find(params[:contest_id])
210 210 if user and contest
211 211 user.contests << contest
212 212 end
213 213 redirect_to :action => 'index'
214 214 end
215 215
216 216 def remove_from_contest
217 217 user = User.find(params[:id])
218 218 contest = Contest.find(params[:contest_id])
219 219 if user and contest
220 220 user.contests.delete(contest)
221 221 end
222 222 redirect_to :action => 'index'
223 223 end
224 224
225 225 def contest_management
226 226 end
227 227
228 228 def manage_contest
229 229 contest = Contest.find(params[:contest][:id])
230 230 if !contest
231 231 flash[:notice] = 'You did not choose the contest.'
232 232 redirect_to :action => 'contest_management' and return
233 233 end
234 234
235 235 operation = params[:operation]
236 236
237 237 if not ['add','remove','assign'].include? operation
238 238 flash[:notice] = 'You did not choose the operation to perform.'
239 239 redirect_to :action => 'contest_management' and return
240 240 end
241 241
242 242 lines = params[:login_list]
243 243 if !lines or lines.blank?
244 244 flash[:notice] = 'You entered an empty list.'
245 245 redirect_to :action => 'contest_management' and return
246 246 end
247 247
248 248 note = []
249 249 users = []
250 250 lines.split("\n").each do |line|
251 251 user = User.find_by_login(line.chomp)
252 252 if user
253 253 if operation=='add'
254 254 if ! user.contests.include? contest
255 255 user.contests << contest
256 256 end
257 257 elsif operation=='remove'
258 258 user.contests.delete(contest)
259 259 else
260 260 user.contests = [contest]
261 261 end
262 262
263 263 if params[:reset_timer]
264 264 user.contest_stat.forced_logout = true
265 265 user.contest_stat.reset_timer_and_save
266 266 end
267 267
268 268 if params[:notification_emails]
269 269 send_contest_update_notification_email(user, contest)
270 270 end
271 271
272 272 note << user.login
273 273 users << user
274 274 end
275 275 end
276 276
277 277 if params[:reset_timer]
278 278 logout_users(users)
279 279 end
280 280
281 281 flash[:notice] = 'User(s) ' + note.join(', ') +
282 282 ' were successfully modified. '
283 283 redirect_to :action => 'contest_management'
284 284 end
285 285
286 286 # admin management
287 287
288 288 def admin
289 289 @admins = Role.where(name: 'admin').take.users
290 290 @tas = Role.where(name: 'ta').take.users
291 291 end
292 292
293 293 def modify_role
294 294 user = User.find_by_login(params[:login])
295 295 role = Role.find_by_name(params[:role])
296 296 unless user && role
297 297 flash[:error] = 'Unknown user or role'
298 298 redirect_to admin_user_admin_index_path
299 299 return
300 300 end
301 301 if params[:commit] == 'Grant'
302 302 #grant role
303 303 user.roles << role
304 304 flash[:notice] = "User '#{user.login}' has been granted the role '#{role.name}'"
305 305 else
306 306 #revoke role
307 307 if user.login == 'root' && role.name == 'admin'
308 308 flash[:error] = 'You cannot revoke admisnistrator permission from root.'
309 309 redirect_to admin_user_admin_index_path
310 310 return
311 311 end
312 312 user.roles.delete(role)
313 313 flash[:notice] = "The role '#{role.name}' has been revoked from User '#{user.login}'"
314 314 end
315 315 redirect_to admin_user_admin_index_path
316 316 end
317 317
318 318 # mass mailing
319 319
320 320 def mass_mailing
321 321 end
322 322
323 323 def bulk_mail
324 324 lines = params[:login_list]
325 325 if !lines or lines.blank?
326 326 flash[:notice] = 'You entered an empty list.'
327 327 redirect_to :action => 'mass_mailing' and return
328 328 end
329 329
330 330 mail_subject = params[:subject]
331 331 if !mail_subject or mail_subject.blank?
332 332 flash[:notice] = 'You entered an empty mail subject.'
333 333 redirect_to :action => 'mass_mailing' and return
334 334 end
335 335
336 336 mail_body = params[:email_body]
337 337 if !mail_body or mail_body.blank?
338 338 flash[:notice] = 'You entered an empty mail body.'
339 339 redirect_to :action => 'mass_mailing' and return
340 340 end
341 341
342 342 note = []
343 343 users = []
344 344 lines.split("\n").each do |line|
345 345 user = User.find_by_login(line.chomp)
346 346 if user
347 347 send_mail(user.email, mail_subject, mail_body)
348 348 note << user.login
349 349 end
350 350 end
351 351
352 352 flash[:notice] = 'User(s) ' + note.join(', ') +
353 353 ' were successfully modified. '
354 354 redirect_to :action => 'mass_mailing'
355 355 end
356 356
357 357 #bulk manage
358 358 def bulk_manage
359 359
360 360 begin
361 361 if params[:filter_group]
362 362 @users = Group.find_by(id: params[:filter_group_id]).users
363 363 else
364 364 @users = User.all
365 365 end
366 366 @users = @users.where('(login REGEXP ?) OR (remark REGEXP ?)',params[:regex],params[:regex]) unless params[:regex].blank?
367 367 @users.count if @users #test the sql
368 368 rescue Exception
369 369 flash[:error] = 'Regular Expression is malformed'
370 370 @users = nil
371 371 end
372 372
373 373 if params[:commit]
374 374 @action = {}
375 375 @action[:set_enable] = params[:enabled]
376 376 @action[:enabled] = params[:enable] == "1"
377 377 @action[:gen_password] = params[:gen_password]
378 378 @action[:add_group] = params[:add_group]
379 379 @action[:group_name] = params[:group_name]
380 380 end
381 381
382 382 if params[:commit] == "Perform"
383 383 if @action[:set_enable]
384 384 @users.update_all(enabled: @action[:enabled])
385 385 end
386 386 if @action[:gen_password]
387 387 @users.each do |u|
388 388 password = random_password
389 389 u.password = password
390 390 u.password_confirmation = password
391 391 u.save
392 392 end
393 393 end
394 394 if @action[:add_group] and @action[:group_name]
395 395 @group = Group.find(@action[:group_name])
396 396 ok = []
397 397 failed = []
398 398 @users.each do |user|
399 399 begin
400 400 @group.users << user
401 401 ok << user.login
402 402 rescue => e
403 403 failed << user.login
404 404 end
405 405 end
406 406 flash[:success] = "The following users are added to the 'group #{@group.name}': " + ok.join(', ') if ok.count > 0
407 407 flash[:alert] = "The following users are already in the 'group #{@group.name}': " + failed.join(', ') if failed.count > 0
408 408 end
409 409 end
410 410 end
411 411
412 412 protected
413 413
414 414 def random_password(length=5)
415 415 chars = 'abcdefghijkmnopqrstuvwxyz23456789'
416 416 newpass = ""
417 417 length.times { newpass << chars[rand(chars.size-1)] }
418 418 return newpass
419 419 end
420 420
421 421 def import_from_file(f)
422 422 data_hash = YAML.load(f)
423 423 @import_log = ""
424 424
425 425 country_data = data_hash[:countries]
426 426 site_data = data_hash[:sites]
427 427 user_data = data_hash[:users]
428 428
429 429 # import country
430 430 countries = {}
431 431 country_data.each_pair do |id,country|
432 432 c = Country.find_by_name(country[:name])
433 433 if c!=nil
434 434 countries[id] = c
435 435 @import_log << "Found #{country[:name]}\n"
436 436 else
437 437 countries[id] = Country.new(:name => country[:name])
438 438 countries[id].save
439 439 @import_log << "Created #{country[:name]}\n"
440 440 end
441 441 end
442 442
443 443 # import sites
444 444 sites = {}
445 445 site_data.each_pair do |id,site|
446 446 s = Site.find_by_name(site[:name])
447 447 if s!=nil
448 448 @import_log << "Found #{site[:name]}\n"
449 449 else
450 450 s = Site.new(:name => site[:name])
451 451 @import_log << "Created #{site[:name]}\n"
452 452 end
453 453 s.password = site[:password]
454 454 s.country = countries[site[:country_id]]
455 455 s.save
456 456 sites[id] = s
457 457 end
458 458
459 459 # import users
460 460 user_data.each_pair do |id,user|
461 461 u = User.find_by_login(user[:login])
462 462 if u!=nil
463 463 @import_log << "Found #{user[:login]}\n"
464 464 else
465 465 u = User.new(:login => user[:login])
466 466 @import_log << "Created #{user[:login]}\n"
467 467 end
468 468 u.full_name = user[:name]
469 469 u.password = user[:password]
470 470 u.country = countries[user[:country_id]]
471 471 u.site = sites[user[:site_id]]
472 472 u.activated = true
473 473 u.email = "empty-#{u.login}@none.com"
474 474 if not u.save
475 475 @import_log << "Errors\n"
476 476 u.errors.each { |attr,msg| @import_log << "#{attr} - #{msg}\n" }
477 477 end
478 478 end
479 479
480 480 end
481 481
482 482 def logout_users(users)
483 483 users.each do |user|
484 484 contest_stat = user.contest_stat(true)
485 485 if contest_stat and !contest_stat.forced_logout
486 486 contest_stat.forced_logout = true
487 487 contest_stat.save
488 488 end
489 489 end
490 490 end
491 491
492 492 def send_contest_update_notification_email(user, contest)
493 493 contest_title_name = GraderConfiguration['contest.name']
494 494 contest_name = contest.name
495 495 mail_subject = t('contest.notification.email_subject', {
496 496 :contest_title_name => contest_title_name,
497 497 :contest_name => contest_name })
498 498 mail_body = t('contest.notification.email_body', {
499 499 :full_name => user.full_name,
500 500 :contest_title_name => contest_title_name,
501 501 :contest_name => contest.name,
502 502 })
503 503
504 504 logger.info mail_body
505 505 send_mail(user.email, mail_subject, mail_body)
506 506 end
507 507
508 508 def find_contest_and_user_from_contest_id(id)
509 509 if id!='none'
510 510 @contest = Contest.find(id)
511 511 else
512 512 @contest = nil
513 513 end
514 514 if @contest
515 515 @users = @contest.users
516 516 else
517 517 @users = User.find_users_with_no_contest
518 518 end
519 519 return [@contest, @users]
520 520 end
521 521
522 522 def gen_csv_from_scorearray(scorearray,problem)
523 523 CSV.generate do |csv|
524 524 #add header
525 525 header = ['User','Name', 'Activated?', 'Logged in', 'Contest']
526 526 problem.each { |p| header << p.name }
527 527 header += ['Total','Passed']
528 528 csv << header
529 529 #add data
530 530 scorearray.each do |sc|
531 531 total = num_passed = 0
532 532 row = Array.new
533 533 sc.each_index do |i|
534 534 if i == 0
535 535 row << sc[i].login
536 536 row << sc[i].full_name
537 537 row << sc[i].activated
538 538 row << (sc[i].try(:contest_stat).try(:started_at).nil? ? 'no' : 'yes')
539 539 row << sc[i].contests.collect {|c| c.name}.join(', ')
540 540 else
541 541 row << sc[i][0]
542 542 total += sc[i][0]
543 543 num_passed += 1 if sc[i][1]
544 544 end
545 545 end
546 546 row << total
547 547 row << num_passed
548 548 csv << row
549 549 end
550 550 end
551 551 end
552 552
553 553 private
554 554 def user_params
555 555 params.require(:user).permit(:login,:password,:password_confirmation,:email, :alias, :full_name,:remark)
556 556 end
557 557 end
You need to be logged in to leave comments. Login now