cafe-grader-web Commit - r241:ce50017c6bce

cafe-grader-web

Commit `r241:ce50017c6bce` public

parent | child

Description:

disabled unused actions from controllers, protected statuses display, more styling

Commit status:

[Not Reviewed]

References:

default

Diff options:

| | | |

Comments:

0 Commit comments 0 Inline Comments

Unresolved TODOs:

There are no unresolved TODOs

Add another comment

r241:ce50017c6bce - Fri, 29 Jan 2010 13:11:58 - 5 files changed: 12 inserted, 2 deleted

app/controllers/main_controller.rb ¶ +3

                 def source
                   submission = Submission.find(params[:id])
                   if submission.user_id == session[:user_id]
                     send_data(submission.source,
               		{:filename => submission.download_filename,
                                 :type => 'text/plain'})
                   else
                     flash[:notice] = 'Error viewing source'
                     redirect_to :action => 'list'
                   end
                 end
                 def compiler_msg
                   @submission = Submission.find(params[:id])
                   if @submission.user_id == session[:user_id]
                     render :action => 'compiler_msg', :layout => 'empty'
                   else
                     flash[:notice] = 'Error viewing source'
                     redirect_to :action => 'list'
                   end
                 end
                 def submission
+            +     # protect the action for Code Jom
+            +     redirect_to :action => 'list'
+            +
                   @user = User.find(session[:user_id])
                   @problems = Problem.find_available_problems
                   if params[:id]==nil
                     @problem = nil
                     @submissions = nil
                   else
                     @problem = Problem.find_by_name(params[:id])
                     if not @problem.available
                       redirect_to :action => 'list'
                       flash[:notice] = 'Error: submissions for that problem are not viewable.'
                       return
                     end
                     @submissions = Submission.find_all_by_user_problem(@user.id, @problem.id)
                   end
                 end
                 def result
                   if !Configuration.show_grading_result
                     redirect_to :action => 'list' and return
                   end
                   @user = User.find(session[:user_id])
                   @submission = Submission.find(params[:id])
                   if @submission.user!=@user
                     flash[:notice] = 'You are not allowed to view result of other users.'

app/controllers/statuses_controller.rb ¶ +3

               class StatusesController < ApplicationController
+            +   # protect the statuses, for now
+            +   before_filter :admin_authorization
+            +
                 def index
                   problem_count = Problem.available_problem_count
                   @dead_users = []
                   @level_users = {}
                   @levels = (0..CODEJOM_MAX_ALIVE_LEVEL)
                   @levels.each { |l| @level_users[l] = [] }
                   User.find(:all).each do |user|
                     if user.codejom_status==nil
                       user.update_codejom_status
                       user.codejom_status(true)  # reload
                     end
                     if not user.codejom_status.alive
                       @dead_users << user
                     else
                       @level_users[user.codejom_level] << user
                     end
                   end
                 end
               end

app/controllers/test_controller.rb ¶ +3

               class TestController < ApplicationController
+            +   # this page is unavailable in Code Jom
+            +   before_filter :admin_authorization
+            +
                 before_filter :authenticate, :check_viewability
               #
               #  COMMENT OUT: filter in each action instead
               #
               #  before_filter :verify_time_limit, :only => [:submit]
                 verify :method => :post, :only => [:submit],
                        :redirect_to => { :action => :index }
                 def index
                   prepare_index_information
                 end
                 def submit
                   @user = User.find(session[:user_id])
                   @submitted_test_request = TestRequest.new_from_form_params(@user,params[:test_request])
                   if @submitted_test_request.errors.length != 0
                     prepare_index_information
                     render :action => 'index' and return
                   end

app/views/main/_problem_title.html.haml ¶ +1 -1

               .problem-bar{:id => "problem-bar-#{problem.id}"}
                 %a{:href => "#", :onclick => "$$('.problem-panel').each(function(elt) {elt.hide();});  $('problem-panel-#{problem.id}').show(); $('problem-panel-filler').hide(); return false;"}
                   %span{:class => 'problem-title'}
-            -       = "#{problem.full_name} (#{problem.name})"
+            +       = "#{problem.full_name}"
                   - if @prob_submissions[problem_title_counter][:count] > 0
                     = "[#{@prob_submissions[problem_title_counter][:count]} trials(s)]"
                   - else
                     [No trials]

app/views/main/list.html.haml ¶ +2 -1

               - content_for :head do
                 = javascript_include_tag :defaults
                 = javascript_include_tag 'announcement_refresh.js'
                 = javascript_include_tag 'codejom_timeout.js'
               = user_title_bar(@user)
               .announcementbox{:style => (@announcements.length==0 ? "display:none" : "")}
                 %span{:class => 'title'}
                   Announcements
                 #announcementbox-body
                   = render :partial => 'announcement', :collection => @announcements
               %hr/
               - if (Configuration.contest_mode?) and (@user.site!=nil) and (@user.site.started!=true)
                 %p=t 'main.start_soon'
               - if Configuration.show_tasks_to?(@user)
                 .problem-list
                   = render :partial => 'problem_title', :collection => @problems, :as => :problem
                 .problem-content
                   %span{:id => "problem-panel-filler", :style => (@current_problem_id!=nil) ? "display:none" : ""}
-            -       %b Welcome to Code Jom
+            +       %h2
+            +         Welcome to Code Jom
                     %br/
                     Choose problems from the list on the right.
                   = render :partial => 'problem', :collection => @problems
               %br{:clear=>'both'}/
               %hr/
               %script{:type => "text/javascript"}
                 Announcement.registerRefreshEventTimer();
                 = render :partial => 'submission_timeouts'
                 CodejomTimeout.updateProblemMessages();
                 CodejomTimeout.registerRefreshEvent();

Write
Preview

You need to be logged in to leave comments. Login now

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository permissions settings

Sign in to your account

Author

r241:ce50017c6bce - Fri, 29 Jan 2010 13:11:58 - 5 files changed: 12 inserted, 2 deleted

Sign in to your account

Commit r241:ce50017c6bce public

Author

r241:ce50017c6bce - Fri, 29 Jan 2010 13:11:58 - 5 files changed: 12 inserted, 2 deleted

Commit `r241:ce50017c6bce` public