cafe-grader-web

Commit r548:ba97cbe38d86 public

parent | child
Description:
Change to better error message when the submitted file has illegal extension Solve issue #4
Commit status:
[Not Reviewed]
References:
default
Diff options:
Raw Diff | Patch Diff | Download Diff | Ignore whitespace | Increase context
Comments:
0 Commit comments 0 Inline Comments
Unresolved TODOs:
There are no unresolved TODOs
Side by Side Unified
Expand All Files Collapse All Files Wide Mode Diff
Add another comment
Browse Files

r548:ba97cbe38d86 - - 1 file changed: 1 inserted, 1 deleted

Show file before | Show file after | Raw diff | Download diff | Ignore whitespace Increase context Show commentsHide comments
@@ -141,25 +141,25
141 self.language = Submission.find_language_in_source(self.source,
141 self.language = Submission.find_language_in_source(self.source,
142 self.source_filename)
142 self.source_filename)
143 end
143 end
144
144
145 # validation codes
145 # validation codes
146 def must_specify_language
146 def must_specify_language
147 return if self.source==nil
147 return if self.source==nil
148
148
149 # for output_only tasks
149 # for output_only tasks
150 return if self.problem!=nil and self.problem.output_only
150 return if self.problem!=nil and self.problem.output_only
151
151
152 if self.language==nil
152 if self.language==nil
153 - errors.add('source',"must specify programming language") unless self.language!=nil
153 + errors.add('source',"Cannot detect language. Did you submit a correct source file?") unless self.language!=nil
154 end
154 end
155 end
155 end
156
156
157 def must_have_valid_problem
157 def must_have_valid_problem
158 return if self.source==nil
158 return if self.source==nil
159 if self.problem==nil
159 if self.problem==nil
160 errors.add('problem',"must be specified.")
160 errors.add('problem',"must be specified.")
161 elsif (!self.problem.available) and (self.new_record?)
161 elsif (!self.problem.available) and (self.new_record?)
162 errors.add('problem',"must be valid.")
162 errors.add('problem',"must be valid.")
163 end
163 end
164 end
164 end
165
165
You need to be logged in to leave comments. Login now