cafe-grader-web Commit - r99:ab383e0b489e

cafe-grader-web

Commit `r99:ab383e0b489e` public

parent | child

Description:

[web] added support for output only problems git-svn-id: http://theory.cpe.ku.ac.th/grader/web/trunk@188 6386c4cd-e34a-4fa8-8920-d93eb39b512e

Commit status:

[Not Reviewed]

References:

default

Diff options:

| | | |

Comments:

0 Commit comments 0 Inline Comments

Unresolved TODOs:

There are no unresolved TODOs

Add another comment

r99:ab383e0b489e - Tue, 22 Apr 2008 00:25:26 - 5 files changed: 65 inserted, 22 deleted

db/migrate/031_add_supports_for_output_only_problems.rb created 644 ¶ +11

			@@ -0,0 +1,11
		1	+ class AddSupportsForOutputOnlyProblems < ActiveRecord::Migration
		2	+ def self.up
		3	+ add_column :submissions, :source_filename, :string
		4	+ add_column :problems, :output_only, :boolean
		5	+ end
		6	+
		7	+ def self.down
		8	+ remove_column :submissions, :source_filename
		9	+ add_column :problems, :output_only, :boolean
		10	+ end
		11	+ end

app/controllers/main_controller.rb ¶ +4 -1

                 def submit
                   user = User.find(session[:user_id])
                   @submission = Submission.new(params[:submission])
                   @submission.user = user
                   @submission.language_id = 0
-            -     @submission.source = params['file'].read if params['file']!=''
+            +     if params['file']!=''
+            +       @submission.source = params['file'].read
+            +       @submission.source_filename = params['file'].original_filename
+            +     end
                   @submission.submitted_at = Time.new
                   if user.site!=nil and user.site.finished?
                     @submission.errors.add_to_base "The contest is over."
                     prepare_list_information
                     render :action => 'list' and return

app/models/submission.rb ¶ +29 -16

               class Submission < ActiveRecord::Base
                 belongs_to :language
                 belongs_to :problem
                 belongs_to :user
+            +   before_validation :assign_problem
+            +   before_validation :assign_language
+            +
                 validates_presence_of :source
                 validates_length_of :source, :maximum => 100_000, :allow_blank => true, :message => 'too long'
                 validates_length_of :source, :minimum => 1, :allow_blank => true, :message => 'too short'
+            +   validate :must_have_valid_problem
                 validate :must_specify_language
-            -   validate :must_have_valid_problem
                 before_save :assign_latest_number_if_new_recond
                 def self.find_last_by_user_and_problem(user_id, problem_id)
                   last_sub = find(:first,
                                   :conditions => {:user_id => user_id,
                     return problem
                   else
                     return nil
                   end
                 end
+            +   def assign_problem
+            +     if self.problem_id!=-1
+            +       begin
+            +         self.problem = Problem.find(self.problem_id)
+            +       rescue ActiveRecord::RecordNotFound
+            +         self.problem = nil
+            +       end
+            +     else
+            +       self.problem = Submission.find_problem_in_source(self.source)
+            +     end
+            +   end
+            +
+            +   def assign_language
+            +     self.language = Submission.find_language_in_source(self.source)
+            +   end
+            +
                 # validation codes
                 def must_specify_language
                   return if self.source==nil
-            -     self.language = Submission.find_language_in_source(self.source)
-            -     errors.add('source',"must specify programming language") unless self.language!=nil
+            +
+            +     # for output_only tasks
+            +     return if self.problem!=nil and self.problem.output_only
+            +
+            +     if self.language==nil
+            +       errors.add('source',"must specify programming language") unless self.language!=nil
+            +     end
                 end
                 def must_have_valid_problem
                   return if self.source==nil
-            -     if self.problem_id!=-1
-            -       begin
-            -         problem = Problem.find(self.problem_id)
-            -       rescue ActiveRecord::RecordNotFound
-            -         problem = nil
-            -       end
-            -     else
-            -       problem = Submission.find_problem_in_source(self.source)
-            -     end
-            -     if problem==nil
+            +     if self.problem==nil
                     errors.add('problem',"must be specified.")
-            -     elsif (!problem.available) and (self.new_record?)
+            +     elsif (!self.problem.available) and (self.new_record?)
                     errors.add('problem',"must be valid.")
-            -     else
-            -       self.problem = problem
                   end
                 end
                 # callbacks
                 def assign_latest_number_if_new_recond
                   return if !self.new_record?

app/views/problems/_form.rhtml ¶ +18 -4

               <p><label for="problem_full_score">Full score</label><br/>
               <%= text_field 'problem', 'full_score'  %></p>
               <p><label for="problem_date_added">Date added</label><br/>
               <%= date_select 'problem', 'date_added'  %></p>
-            - <p><label for="problem_available">Available?</label>
-            - <%= select("problem","available",[['True',true],['False',false]]) %></p>
+            + <%
+            + # TODO: these should be put in model Problem, but I can't think of
+            + #       nice default values for them.  These values look fine only
+            + #       in this case (of lazily adding new problems).
+            + @problem.available = true if @problem!=nil and @problem.available==nil
+            + @problem.test_allowed = true if @problem!=nil and @problem.test_allowed==nil
+            + @problem.output_only = false if @problem!=nil and @problem.output_only==nil
+            + %>
-            - <p><label for="problem_test_allowed">Test allowed?</label>
-            - <%= select("problem","test_allowed",[['True',true],['False',false]]) %></p>
+            + <p>
+            + <label for="problem_available">Available?</label>
+            + <%= check_box :problem, :available %>
+            +
+            + <label for="problem_test_allowed">Test allowed?</label>
+            + <%= check_box :problem, :test_allowed %>
+            +
+            + <label for="problem_output_only">Output only?</label>
+            + <%= check_box :problem, :output_only %>
+            + </p>
               <%= error_messages_for 'description' %>
               <p><label for="description_body">Description</label><br/>
               <%= text_area :description, :body, :rows => 10, :cols => 80  %></p>

db/schema.rb ¶ +3 -1

               # to create the application database on another system, you should be using db:schema:load, not running
               # all the migrations from scratch. The latter is a flawed and unsustainable approach (the more migrations
               # you'll amass, the slower it'll run and the greater likelihood for issues).
               #
               # It's strongly recommended to check this file into your version control system.
-            - ActiveRecord::Schema.define(:version => 30) do
+            + ActiveRecord::Schema.define(:version => 31) do
                 create_table "announcements", :force => true do |t|
                   t.string   "author"
                   t.text     "body"
                   t.boolean  "published"
                   t.datetime "created_at"
                   t.integer "full_score"
                   t.date    "date_added"
                   t.boolean "available"
                   t.string  "url"
                   t.integer "description_id"
                   t.boolean "test_allowed"
+            +     t.boolean "output_only"
                 end
                 create_table "rights", :force => true do |t|
                   t.string "name"
                   t.string "controller"
                   t.string "action"
                   t.datetime "compiled_at"
                   t.text     "compiler_message"
                   t.datetime "graded_at"
                   t.integer  "points"
                   t.text     "grader_comment"
                   t.integer  "number"
+            +     t.string   "source_filename"
                 end
                 add_index "submissions", ["user_id", "problem_id", "number"], :name => "index_submissions_on_user_id_and_problem_id_and_number", :unique => true
                 add_index "submissions", ["user_id", "problem_id"], :name => "index_submissions_on_user_id_and_problem_id"
                 create_table "tasks", :force => true do |t|

Write
Preview

You need to be logged in to leave comments. Login now

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository permissions settings

Sign in to your account

Author

r99:ab383e0b489e - Tue, 22 Apr 2008 00:25:26 - 5 files changed: 65 inserted, 22 deleted

Sign in to your account

Commit r99:ab383e0b489e public

Author

r99:ab383e0b489e - Tue, 22 Apr 2008 00:25:26 - 5 files changed: 65 inserted, 22 deleted

Commit `r99:ab383e0b489e` public