cafe-grader-web Commit - r288:74436ad04ad0

cafe-grader-web

Commit `r288:74436ad04ad0` public

parent | child

Description:

controllers get available problems from current user

Commit status:

[Not Reviewed]

References:

default

Diff options:

| | | |

Comments:

0 Commit comments 0 Inline Comments

Unresolved TODOs:

There are no unresolved TODOs

Add another comment

r288:74436ad04ad0 - Thu, 11 Mar 2010 08:18:40 - 3 files changed: 42 inserted, 45 deleted

app/controllers/main_controller.rb ¶ +3 -44

                 def source
                   submission = Submission.find(params[:id])
                   if submission.user_id == session[:user_id]
                     send_data(submission.source,
               		{:filename => submission.download_filename,
                                 :type => 'text/plain'})
                   else
                     flash[:notice] = 'Error viewing source'
                     redirect_to :action => 'list'
                   end
                 end
                 def compiler_msg
                   @submission = Submission.find(params[:id])
                   if @submission.user_id == session[:user_id]
                     render :action => 'compiler_msg', :layout => 'empty'
                   else
                     flash[:notice] = 'Error viewing source'
                     redirect_to :action => 'list'
                   end
                 end
                 def submission
                   @user = User.find(session[:user_id])
-            -     @problems = Problem.find_available_problems
+            +     @problems = @user.available_problems
                   if params[:id]==nil
                     @problem = nil
                     @submissions = nil
                   else
                     @problem = Problem.find_by_name(params[:id])
                     if not @problem.available
                       redirect_to :action => 'list'
                       flash[:notice] = 'Error: submissions for that problem are not viewable.'
                       return
                     end
                     @submissions = Submission.find_all_by_user_problem(@user.id, @problem.id)
                   end
                 end
                 def result
                   if !Configuration.show_grading_result
                     redirect_to :action => 'list' and return
                   end
                   @user = User.find(session[:user_id])
                   @submission = Submission.find(params[:id])
                   if @submission.user!=@user
                     flash[:notice] = 'You are not allowed to view result of other users.'
                     redirect_to :action => 'list' and return
                   end
                   if params.has_key? 'recent'
                     prepare_announcements(params[:recent])
                   else
                     prepare_announcements
                   end
                   render(:partial => 'announcement',
                          :collection => @announcements,
                          :locals => {:announcement_effect => true})
                 end
                 protected
                 def prepare_announcements(recent=nil)
                   if Configuration.show_tasks_to?(@user)
                     @announcements = Announcement.find_published(true)
                   else
                     @announcements = Announcement.find_published
                   end
                   if recent!=nil
                     recent_id = recent.to_i
                     @announcements = @announcements.find_all { |a| a.id > recent_id }
                   end
                 end
-            -   def problem_list_by_user_contests(user)
-            -     contest_problems = []
-            -     pin = {}
-            -     user.contests.enabled.each do |contest|
-            -       available_problems = contest.problems.available
-            -       contest_problems << {
-            -         :contest => contest,
-            -         :problems => available_problems
-            -       }
-            -       available_problems.each {|p| pin[p.id] = true}
-            -     end
-            -     other_avaiable_problems = Problem.available.find_all {|p| pin[p.id]==nil and p.contests.length==0}
-            -     contest_problems << {
-            -       :contest => nil,
-            -       :problems => other_avaiable_problems
-            -     }
-            -     return contest_problems
-            -   end
-            -   def problem_list_for_user(user, contest_problems=nil)
-            -     if not Configuration.multicontests?
-            -       return Problem.find_available_problems
-            -     else
-            -       if contest_problems==nil
-            -         contest_problems = problem_list_by_user_contests(user)
-            -       end
-            -       problems = []
-            -       collected = {}
-            -       contest_problems.each do |cp|
-            -         cp[:problems].each do |problem|
-            -           if not collected[problem.id]
-            -             problems << problem
-            -             collected[problem.id] = true
-            -           end
-            -         end
-            -       end
-            -       return problems
-            -     end
-            -   end
                 def prepare_list_information
                   @user = User.find(session[:user_id])
                   if not Configuration.multicontests?
                     @problems = problem_list_for_user(@user)
                   else
-            -       @contest_problems = problem_list_by_user_contests(@user)
+            +       @contest_problems = @user.available_problems_group_by_contests
-            -       @problems = problem_list_for_user(@user, @contest_problems)
+            +       @problems = @user.available_problems
                   end
                   @prob_submissions = {}
                   @problems.each do |p|
                     sub = Submission.find_last_by_user_and_problem(@user.id,p.id)
                     if sub!=nil
                       @prob_submissions[p.id] = { :count => sub.number, :submission => sub }
                     else
                       @prob_submissions[p.id] = { :count => 0, :submission => nil }
                     end
                   end
                   prepare_announcements
                 end
                 def check_viewability
                   @user = User.find(session[:user_id])
                   if (!Configuration.show_tasks_to?(@user)) and
                       ((action_name=='submission') or (action_name=='submit'))
                     redirect_to :action => 'list' and return
                   end
                 end
                 def prepare_grading_result(submission)
                   if Configuration.task_grading_info.has_key? submission.problem.name
                     grading_info = Configuration.task_grading_info[submission.problem.name]

app/controllers/tasks_controller.rb ¶ +1 -1

               class TasksController < ApplicationController
                 before_filter :authenticate, :check_viewability
                 def index
                   redirect_to :action => 'list'
                 end
                 def list
-            -     @problems = Problem.find_available_problems
+            +     @problems = @user.available_problems
                 end
                 # this has contest-wide access control
                 def view
                   base_name = params[:file]
                   base_filename = File.basename("#{base_name}.#{params[:ext]}")
                   filename = "#{Problem.download_file_basedir}/#{base_filename}"
                   if !FileTest.exists?(filename)
                     redirect_to :action => 'index' and return
                   end
                   send_file_to_user(filename, base_filename)
                 end
                 # this has problem-level access control
                 def download
                   problem = Problem.find(params[:id])
                   if !problem or !problem.available or !@user.can_view_problem? problem
                     redirect_to :action => 'index' and return
                   end
                   base_name = params[:file]
                   base_filename = File.basename("#{base_name}.#{params[:ext]}")

app/models/user.rb ¶ +38

                 def update_start_time
                   stat = self.contest_stat
                   if stat == nil
                     stat = UserContestStat.new(:user => self,
                                                :started_at => Time.now.gmtime)
                     stat.save
                   end
                 end
                 def problem_in_user_contests?(problem)
                   problem_contests = problem.contests.all
                   if problem_contests.length == 0   # this is public contest
                     return true
                   end
                   contests.each do |contest|
                     if problem_contests.find {|c| c.id == contest.id }
                       return true
                     end
                   end
                   return false
                 end
+            +   def available_problems_group_by_contests
+            +     contest_problems = []
+            +     pin = {}
+            +     contests.enabled.each do |contest|
+            +       available_problems = contest.problems.available
+            +       contest_problems << {
+            +         :contest => contest,
+            +         :problems => available_problems
+            +       }
+            +       available_problems.each {|p| pin[p.id] = true}
+            +     end
+            +     other_avaiable_problems = Problem.available.find_all {|p| pin[p.id]==nil and p.contests.length==0}
+            +     contest_problems << {
+            +       :contest => nil,
+            +       :problems => other_avaiable_problems
+            +     }
+            +     return contest_problems
+            +   end
+            +
+            +   def available_problems
+            +     if not Configuration.multicontests?
+            +       return Problem.find_available_problems
+            +     else
+            +       contest_problems = []
+            +       pin = {}
+            +       contests.enabled.each do |contest|
+            +         contest.problems.available.each do |problem|
+            +           if not pin.has_key? problem.id
+            +             contest_problems << problem
+            +           end
+            +           pin[problem.id] = true
+            +         end
+            +       end
+            +       other_avaiable_problems = Problem.available.find_all {|p| pin[p.id]==nil and p.contests.length==0}
+            +       return contest_problems + other_avaiable_problems
+            +     end
+            +   end
+            +
                 def can_view_problem?(problem)
                   if not Configuration.multicontests?
                     return problem.available
                   else
                     return problem_in_user_contests? problem
                   end
                 end
                 protected
                   def encrypt_new_password
                     return if password.blank?
                     self.salt = (10+rand(90)).to_s
                     self.hashed_password = User.encrypt(self.password,self.salt)
                   end
                   def assign_default_site
                     # have to catch error when migrating (because self.site is not available).
                     begin
                       if self.site==nil
                         self.site = Site.find_by_name('default')
                         if self.site==nil
                           self.site = Site.find(1)  # when 'default has be renamed'
                         end
                       end

Write
Preview

You need to be logged in to leave comments. Login now

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository permissions settings

Sign in to your account

Author

r288:74436ad04ad0 - Thu, 11 Mar 2010 08:18:40 - 3 files changed: 42 inserted, 45 deleted

Sign in to your account

Commit r288:74436ad04ad0 public

Author

r288:74436ad04ad0 - Thu, 11 Mar 2010 08:18:40 - 3 files changed: 42 inserted, 45 deleted

Commit `r288:74436ad04ad0` public