Description:
change to encrypted cookies
Commit status:
[Not Reviewed]
References:
Diff options:
Comments:
0 Commit comments
0 Inline Comments
Unresolved TODOs:
There are no unresolved TODOs
r850:59871a361239 - - 2 files changed: 8 inserted, 6 deleted
@@ -48,28 +48,30 | |||
|
48 | 48 | end |
|
49 | 49 | |
|
50 | 50 | def testcase_authorization |
|
51 | 51 | #admin always has privileged |
|
52 | 52 | if @current_user.admin? |
|
53 | 53 | return true |
|
54 | 54 | end |
|
55 | 55 | |
|
56 | 56 | unauthorized_redirect unless GraderConfiguration["right.view_testcase"] |
|
57 | 57 | end |
|
58 | 58 | |
|
59 | 59 | def unique_visitor_id |
|
60 | - unless cookies[:uuid] | |
|
60 | + unless cookies.encrypted[:uuid] | |
|
61 | 61 | value = SecureRandom.uuid |
|
62 | - cookies[:uuid] = { value: value, expires: 20.year } | |
|
62 | + cookies.encrypted[:uuid] = { value: value, expires: 20.year } | |
|
63 | 63 | end |
|
64 | + puts "encrypt " + cookies.encrypted[:uuid] | |
|
65 | + puts cookies[:uuid] | |
|
64 | 66 | end |
|
65 | 67 | |
|
66 | 68 | protected |
|
67 | 69 | |
|
68 | 70 | #redirect to root (and also force logout) |
|
69 | 71 | #if the user is not logged_in or the system is in "ADMIN ONLY" mode |
|
70 | 72 | def check_valid_login |
|
71 | 73 | #check if logged in |
|
72 | 74 | unless session[:user_id] |
|
73 | 75 | if GraderConfiguration[SINGLE_USER_MODE_CONF_KEY] |
|
74 | 76 | unauthorized_redirect('You need to login but you cannot log in at this time') |
|
75 | 77 | else |
@@ -15,49 +15,49 | |||
|
15 | 15 | redirect_to :controller => 'main', :action => 'login' |
|
16 | 16 | return |
|
17 | 17 | end |
|
18 | 18 | |
|
19 | 19 | if (!GraderConfiguration['right.bypass_agreement']) and (!params[:accept_agree]) and !user.admin? |
|
20 | 20 | flash[:notice] = 'You must accept the agreement before logging in' |
|
21 | 21 | redirect_to :controller => 'main', :action => 'login' |
|
22 | 22 | return |
|
23 | 23 | end |
|
24 | 24 | |
|
25 | 25 | #store uuid when login |
|
26 | 26 | if user.last_ip.nil? |
|
27 | - user.last_ip = cookies[:uuid] | |
|
27 | + user.last_ip = cookies.encrypted[:uuid] | |
|
28 | 28 | else |
|
29 | - if user.last_ip != cookies[:uuid] | |
|
30 | - user.last_ip =cookies[:uuid] | |
|
29 | + if user.last_ip != cookies.encrypted[:uuid] | |
|
30 | + user.last_ip =cookies.encrypted[:uuid] | |
|
31 | 31 | #log different login |
|
32 | 32 | end |
|
33 | 33 | end |
|
34 | 34 | |
|
35 | 35 | #process logging in |
|
36 | 36 | session[:user_id] = user.id |
|
37 | 37 | session[:admin] = user.admin? |
|
38 | 38 | |
|
39 | 39 | # clear forced logout flag for multicontests contest change |
|
40 | 40 | if GraderConfiguration.multicontests? |
|
41 | 41 | contest_stat = user.contest_stat |
|
42 | 42 | if contest_stat.respond_to? :forced_logout |
|
43 | 43 | if contest_stat.forced_logout |
|
44 | 44 | contest_stat.forced_logout = false |
|
45 | 45 | contest_stat.save |
|
46 | 46 | end |
|
47 | 47 | end |
|
48 | 48 | end |
|
49 | 49 | |
|
50 | 50 | #save login information |
|
51 | - Login.create(user_id: user.id, ip_address: cookies[:uuid]) | |
|
51 | + Login.create(user_id: user.id, ip_address: cookies.encrypted[:uuid]) | |
|
52 | 52 | |
|
53 | 53 | redirect_to :controller => 'main', :action => 'list' |
|
54 | 54 | end |
|
55 | 55 | |
|
56 | 56 | def site_login |
|
57 | 57 | begin |
|
58 | 58 | site = Site.find(params[:login][:site_id]) |
|
59 | 59 | rescue ActiveRecord::RecordNotFound |
|
60 | 60 | site = nil |
|
61 | 61 | end |
|
62 | 62 | if site==nil |
|
63 | 63 | flash[:notice] = 'Wrong site' |
You need to be logged in to leave comments.
Login now