cafe-grader-web Commit - r336:4e59f67ded1a

cafe-grader-web

Commit `r336:4e59f67ded1a` public

parent | child

Description:

moved send mail code back to helper

Commit status:

[Not Reviewed]

References:

default

Diff options:

| | | |

Comments:

0 Commit comments 0 Inline Comments

Unresolved TODOs:

There are no unresolved TODOs

Add another comment

r336:4e59f67ded1a - Sat, 06 Oct 2012 07:35:19 - 3 files changed: 22 inserted, 50 deleted

app/controllers/user_admin_controller.rb ¶ +4 -16

               class UserAdminController < ApplicationController
+            +   include MailHelperMethods
+            +
                 before_filter :admin_authorization
                 # GETs should be safe (see http://www.w3.org/2001/tag/doc/whenToUseGet.html)
                 verify :method => :post, :only => [ :destroy,
                                                     :create, :create_from_list,
                                                     :update,
                   mail_body = params[:email_body]
                   if !mail_body or mail_body.blank?
                     flash[:notice] = 'You entered an empty mail body.'
                     redirect_to :action => 'mass_mailing' and return
                   end
-            -     admin_email = GraderConfiguration['system.admin_email']
                   note = []
                   users = []
                   lines.split("\n").each do |line|
                     user = User.find_by_login(line.chomp)
                     if user
-            -         Mail.deliver do
+            +         send_mail(user.email, mail_subject, mail_body)
-            -           from admin_email
-            -           to user.email
-            -           subject mail_subject
-            -           body mail_body
-            -         end
                       note << user.login
                     end
                   end
                   flash[:notice] = 'User(s) ' + note.join(', ') +
                     ' were successfully modified.  '
                   mail_body = t('contest.notification.email_body', {
                                   :full_name => user.full_name,
                                   :contest_title_name => contest_title_name,
                                   :contest_name => contest.name,
                                 })
-            -     admin_email = GraderConfiguration['system.admin_email']
                   logger.info mail_body
-            -     Mail.deliver do
+            +     send_mail(user.email, mail_subject, mail_body)
-            -       from admin_email
-            -       to user.email
-            -       subject mail_subject
-            -       body mail_body
-            -     end
                 end
                 def find_contest_and_user_from_contest_id(id)
                   if id!='none'
                     @contest = Contest.find(id)
                   else

app/controllers/users_controller.rb ¶ +4 -14

               require 'net/smtp'
               class UsersController < ApplicationController
+            +   include MailHelperMethods
+            +
                 before_filter :authenticate, :except => [:new,
                                                          :register,
                                                          :confirm,
                                                          :forget,
                                                          :retrieve_password]
                     redirect_to :controller => 'main', :action => 'login'
                   end
                 end
                 def send_confirmation_email(user)
                   contest_name = GraderConfiguration['contest.name']
-            -     admin_email = GraderConfiguration['system.admin_email']
                   activation_url = url_for(:action => 'confirm',
                                            :login => user.login,
                                            :activation => user.activation_key)
                   home_url = url_for(:controller => 'main', :action => 'index')
                   mail_subject = "[#{contest_name}] Confirmation"
                   mail_body = t('registration.email_body', {
                                   :activation_url => activation_url,
                                   :admin_email => admin_email
                                 })
                   logger.info mail_body
-            -     Mail.deliver do
+            +     send_mail(user.email, mail_subject, mail_body)
-            -       from admin_email
-            -       to user.email
-            -       subject mail_subject
-            -       body mail_body
-            -     end
                 end
                 def send_new_password_email(user)
                   contest_name = GraderConfiguration['contest.name']
-            -     admin_email = GraderConfiguration['system.admin_email']
                   mail_subject = "[#{contest_name}] Password recovery"
                   mail_body = t('registration.password_retrieval.email_body', {
                                   :full_name => user.full_name,
                                   :contest_name => contest_name,
                                   :login => user.login,
                                   :password => user.password,
                                   :admin_email => admin_email
                                 })
                   logger.info mail_body
-            -     Mail.deliver do
+            +     send_mail(user.email, mail_subject, mail_body)
-            -       from admin_email
-            -       to user.email
-            -       subject mail_subject
-            -       body mail_body
-            -     end
                 end
               end

lib/mail_helper_methods.rb ¶ +14 -20

               module MailHelperMethods
-            -   def send_mail(to, subject, body)
+            +   def send_mail(mail_to, mail_subject, mail_body)
-            -     mail = TMail::Mail.new
+            +     mail_from = GraderConfiguration['system.online_registration.from']
-            -     mail.to = to
+            +     smtp_server = GraderConfiguration['system.online_registration.smtp']
-            -     mail.from = Configuration['system.online_registration.from']
-            -     mail.subject = subject
-            -     mail.body = body
-            -     smtp_server = Configuration['system.online_registration.smtp']
                   if ['fake', 'debug'].include? smtp_server
                     puts "-------------------------
-            - To: #{mail.to}
+            + To: #{mail_to}
-            - From: #{mail.from}
+            + From: #{mail_from}
-            - Subject: #{mail.subject}
+            + Subject: #{mail_subject}
-            - #{mail.body}
+            + #{mail_body}
               --------------------------
               "
                     return true
                   end
-            -     begin
+            +     mail = Mail.new do
-            -       Net::SMTP.start(smtp_server) do |smtp|
+            +       from mail_from
-            -         smtp.send_message(mail.to_s, mail.from, mail.to)
+            +       to mail_to
-            -       end
+            +       subject mail_subject
-            -       result = true
+            +       body mail_body
-            -     rescue
-            -       result = false
                   end
-            -     result
+            +     mail.delivery_settings = { :address => smtp_server }
+            +     mail.deliver
                 end
               end

Write
Preview

You need to be logged in to leave comments. Login now

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository permissions settings

Sign in to your account

Author

r336:4e59f67ded1a - Sat, 06 Oct 2012 07:35:19 - 3 files changed: 22 inserted, 50 deleted

Sign in to your account

Commit r336:4e59f67ded1a public

Author

r336:4e59f67ded1a - Sat, 06 Oct 2012 07:35:19 - 3 files changed: 22 inserted, 50 deleted

Commit `r336:4e59f67ded1a` public