Description:
fix displaying bug
Commit status:
[Not Reviewed]
References:
Diff options:
Comments:
0 Commit comments
0 Inline Comments
Unresolved TODOs:
There are no unresolved TODOs
r518:4d5c727a0d13 - - 2 files changed: 2 inserted, 1 deleted
@@ -175,42 +175,43 | |||
|
175 | 175 | if @best[:length][:value] >= prop[:length][:value] |
|
176 | 176 | @best[:length] = prop[:length] |
|
177 | 177 | @best[:length][:lang] = lang |
|
178 | 178 | end |
|
179 | 179 | if @best[:first][:value] >= prop[:first][:value] |
|
180 | 180 | @best[:first] = prop[:first] |
|
181 | 181 | @best[:first][:lang] = lang |
|
182 | 182 | end |
|
183 | 183 | end |
|
184 | 184 | end |
|
185 | 185 | |
|
186 | 186 | @histogram[:summary][:max] = [@histogram[:data].max,1].max |
|
187 | 187 | @summary[:attempt] = user.count |
|
188 | 188 | user.each_value { |v| @summary[:solve] += 1 if v == 1 } |
|
189 | 189 | end |
|
190 | 190 | |
|
191 | 191 | def stuck #report struggling user,problem |
|
192 | 192 | # init |
|
193 | 193 | user,problem = nil |
|
194 | 194 | solve = true |
|
195 | 195 | tries = 0 |
|
196 | 196 | @struggle = Array.new |
|
197 | 197 | record = {} |
|
198 | 198 | Submission.includes(:problem,:user).order(:problem_id,:user_id).find_each do |sub| |
|
199 | + next unless sub.user and sub.problem | |
|
199 | 200 | if user != sub.user_id or problem != sub.problem_id |
|
200 | 201 | @struggle << { user: record[:user], problem: record[:problem], tries: tries } unless solve |
|
201 | 202 | record = {user: sub.user, problem: sub.problem} |
|
202 | 203 | user,problem = sub.user_id, sub.problem_id |
|
203 | 204 | solve = false |
|
204 | 205 | tries = 0 |
|
205 | 206 | end |
|
206 | 207 | if sub.points >= sub.problem.full_score |
|
207 | 208 | solve = true |
|
208 | 209 | else |
|
209 | 210 | tries += 1 |
|
210 | 211 | end |
|
211 | 212 | end |
|
212 | 213 | @struggle.sort!{|a,b| b[:tries] <=> a[:tries] } |
|
213 | 214 | @struggle = @struggle[0..50] |
|
214 | 215 | end |
|
215 | 216 | |
|
216 | 217 | end |
@@ -45,28 +45,28 | |||
|
45 | 45 | |
|
46 | 46 | %h2 Terminated graders |
|
47 | 47 | |
|
48 | 48 | = form_for :clear, :url => {:action => 'clear_terminated'} do |f| |
|
49 | 49 | = submit_tag 'Clear data for terminated graders' |
|
50 | 50 | |
|
51 | 51 | = render :partial => 'grader_list', :locals => {:grader_list => @terminated_processes} |
|
52 | 52 | %div{} |
|
53 | 53 | %h2 Last 20 submissions |
|
54 | 54 | %table.graders |
|
55 | 55 | %thead |
|
56 | 56 | %th ID |
|
57 | 57 | %th User |
|
58 | 58 | %th Problem |
|
59 | 59 | %th Submitted |
|
60 | 60 | %th Graded |
|
61 | 61 | %th Result |
|
62 | 62 | %tbody |
|
63 | 63 | - @submission.each do |sub| |
|
64 | 64 | %tr.inactive |
|
65 | 65 | %td= link_to sub.id, controller: 'graders' ,action: 'submission', id: sub.id |
|
66 | 66 | %td= sub.try(:user).try(:full_name) |
|
67 | 67 | %td= sub.try(:problem).try(:full_name) |
|
68 | 68 | %td= "#{time_ago_in_words(sub.submitted_at)} ago" |
|
69 | - %td= "#{time_ago_in_words(sub.graded_at)} ago" | |
|
69 | + %td= "#{sub.graded_at ? time_ago_in_words(sub.graded_at) : ''} ago" | |
|
70 | 70 | %td= sub.grader_comment |
|
71 | 71 | |
|
72 | 72 |
You need to be logged in to leave comments.
Login now