cafe-grader-web Commit - r680:4ce0b8696d06

cafe-grader-web

Commit `r680:4ce0b8696d06` public

parent | child

Description:

add remove_all in groups consolidate submissions viewing from grader/task

Commit status:

[Not Reviewed]

References:

java

Diff options:

| | | |

Comments:

0 Commit comments 0 Inline Comments

Unresolved TODOs:

There are no unresolved TODOs

Add another comment

r680:4ce0b8696d06 - Thu, 14 Sep 2017 14:45:10 - 9 files changed: 35 inserted, 138 deleted

app/controllers/graders_controller.rb ¶ +1 -36

               class GradersController < ApplicationController
-            -   before_filter :admin_authorization, except: [ :submission ]
+            +   before_filter :admin_authorization
-            -   before_filter(only: [:submission]) {
-            -     #check if authenticated
-            -     return false unless authenticate
-            -     #admin always has privileged
-            -     if @current_user.admin?
-            -       return true
-            -     end
-            -     if GraderConfiguration["right.user_view_submission"] and Submission.find(params[:id]).problem.available?
-            -       return true
-            -     else
-            -       unauthorized_redirect
-            -       return false
-            -     end
-            -   }
                 verify :method => :post, :only => ['clear_all',
                                                    'start_exam',
                                                    'start_grading',
                                                    'stop_all',
                                                    'clear_terminated'],
                        :redirect_to => {:action => 'index'}
                 def index
                   redirect_to :action => 'list'
                 end
                 def list
                   @grader_processes = GraderProcess.find_running_graders
                   @stalled_processes = GraderProcess.find_stalled_process
                   @terminated_processes = GraderProcess.find_terminated_graders
                   @last_task = Task.last
                   @last_test_request = TestRequest.last
                   @submission = Submission.order("id desc").limit(20)
                   @backlog_submission = Submission.where('graded_at is null')
                 end
                 def clear_all
                   GraderProcess.all.each do |p|
                     p.destroy
                   end
                   redirect_to :action => 'list'
                 end
                 def view
                   if params[:type]=='Task'
                     redirect_to :action => 'task', :id => params[:id]
                   else
                     redirect_to :action => 'test_request', :id => params[:id]
                   end
                 end
                 def test_request
                   @test_request = TestRequest.find(params[:id])
                 end
                 def task
                   @task = Task.find(params[:id])
                 end
-            -   def submission
-            -     @submission = Submission.find(params[:id])
-            -     formatter = Rouge::Formatters::HTML.new(css_class: 'highlight', line_numbers: true )
-            -     lexer = case @submission.language.name
-            -       when "c"      then Rouge::Lexers::C.new
-            -       when "cpp"    then Rouge::Lexers::Cpp.new
-            -       when "pas"    then Rouge::Lexers::Pas.new
-            -       when "ruby"   then Rouge::Lexers::Ruby.new
-            -       when "python" then Rouge::Lexers::Python.new
-            -       when "java"   then Rouge::Lexers::Java.new
-            -       when "php"    then Rouge::Lexers::PHP.new
-            -     end
-            -     @formatted_code = formatter.format(lexer.lex(@submission.source))
-            -     @css_style = Rouge::Themes::ThankfulEyes.render(scope: '.highlight')
-            -     user = User.find(session[:user_id])
-            -     SubmissionViewLog.create(user_id: session[:user_id],submission_id: @submission.id) unless user.admin?
-            -   end
                 # various grader controls
                 def stop
                   grader_proc = GraderProcess.find(params[:id])
                   GraderScript.stop_grader(grader_proc.pid)
                   flash[:notice] = 'Grader stopped.  It may not disappear now, but it should disappear shortly.'
                   redirect_to :action => 'list'
                 end
                 def stop_all
                   GraderScript.stop_graders(GraderProcess.find_running_graders +
                                             GraderProcess.find_stalled_process)
                   flash[:notice] = 'Graders stopped.  They may not disappear now, but they should disappear shortly.'
                   redirect_to :action => 'list'
                 end
                 def start_grading
                   GraderScript.start_grader('grading')
                   flash[:notice] = '2 graders in grading env started, one for grading queue tasks, another for grading test request'
                   redirect_to :action => 'list'
                 end
                 def start_exam

app/controllers/groups_controller.rb ¶ +12 -2

               class GroupsController < ApplicationController
                 before_action :set_group, only: [:show, :edit, :update, :destroy,
-            -                                    :add_user, :remove_user,
+            +                                    :add_user, :remove_user,:remove_all_user,
-            -                                    :add_problem, :remove_problem,
+            +                                    :add_problem, :remove_problem,:remove_all_problem,
                                                 ]
                 before_action :authenticate, :admin_authorization
                 # GET /groups
                 def index
                   @groups = Group.all
                 end
                 # GET /groups/1
                 def show
                 end
                 # GET /groups/new
                 def new
                   @group = Group.new
                 end
                 # GET /groups/1/edit
                 def edit
                 end
                 # POST /groups
                 def create
                   @group = Group.new(group_params)
                   end
                 end
                 # PATCH/PUT /groups/1
                 def update
                   if @group.update(group_params)
                     redirect_to @group, notice: 'Group was successfully updated.'
                   else
                     render :edit
                   end
                 end
                 # DELETE /groups/1
                 def destroy
                   @group.destroy
                   redirect_to groups_url, notice: 'Group was successfully destroyed.'
                 end
                 def remove_user
                   user = User.find(params[:user_id])
                   @group.users.delete(user)
                   redirect_to group_path(@group), flash: {success: "User #{user.login} was removed from the group #{@group.name}"}
                 end
+            +   def remove_all_user
+            +     @group.users.clear
+            +     redirect_to group_path(@group), alert: 'All users removed'
+            +   end
+            +
+            +   def remove_all_problem
+            +     @group.problems.clear
+            +     redirect_to group_path(@group), alert: 'All problems removed'
+            +   end
+            +
                 def add_user
                   user = User.find(params[:user_id])
                   begin
                     @group.users << user
                     redirect_to group_path(@group), flash: { success: "User #{user.login} was add to the group #{@group.name}"}
                   rescue => e
                     redirect_to group_path(@group), alert: e.message
                   end
                 end
                 def remove_problem
                   problem = Problem.find(params[:problem_id])
                   @group.problems.delete(problem)
                   redirect_to group_path(@group), flash: {success: "Problem #{problem.name} was removed from the group #{@group.name}" }
                 end
                 def add_problem
                   problem = Problem.find(params[:problem_id])
                   begin
                     @group.problems << problem
                     redirect_to group_path(@group), flash: {success: "Problem #{problem.name} was add to the group #{@group.name}" }
                   rescue => e
                     redirect_to group_path(@group), alert: e.message
                   end

app/controllers/tasks_controller.rb ¶ +1 -1

                 def index
                   redirect_to :action => 'list'
                 end
                 def list
                   @problems = @user.available_problems
                 end
                 # this has contest-wide access control
                 def view
                   base_name = params[:file]
                   base_filename = File.basename("#{base_name}.#{params[:ext]}")
                   filename = "#{Problem.download_file_basedir}/#{base_filename}"
                   if !FileTest.exists?(filename)
                     redirect_to :action => 'index' and return
                   end
                   send_file_to_user(filename, base_filename)
                 end
                 # this has problem-level access control
                 def download
                   problem = Problem.find(params[:id])
-            -     if !problem or !problem.available or !@user.can_view_problem? problem
+            +     unless @current_user.can_view_problem? problem
                     redirect_to :action => 'index' and return
                   end
                   base_name = params[:file]
                   base_filename = File.basename("#{base_name}.#{params[:ext]}")
                   filename = "#{Problem.download_file_basedir}/#{params[:id]}/#{base_filename}"
                   puts "SENDING: #{filename}"
                   if !FileTest.exists?(filename)
                     redirect_to :action => 'index' and return
                   end
                   puts "SENDING: #{filename}"
                   send_file_to_user(filename, base_filename)
                 end
                 protected
                 def send_file_to_user(filename, base_filename)
                   if defined?(USE_APACHE_XSENDFILE) and USE_APACHE_XSENDFILE
                     response.headers['Content-Type'] = "application/force-download"
                     response.headers['Content-Disposition'] = "attachment; filename=\"#{File.basename(filename)}\""
                     response.headers["X-Sendfile"] = filename

app/models/user.rb ¶ +2 -5

                 def available_problems_in_group
                   problem = []
                   self.groups.each do |group|
                     group.problems.where(available: true).each { |p| problem << p }
                   end
                   problem.uniq!
                   if problem
                     problem.sort! do |a,b|
                       case
                       when a.date_added < b.date_added
                       when a.date_added > b.date_added
                         -1
                       else
                         a.name <=> b.name
                       end
                     end
                     return problem
                   else
                     return []
                   end
                 end
                 def can_view_problem?(problem)
-            -     if not GraderConfiguration.multicontests?
+            +     return true if admin?
-            -       return problem.available
+            +     return available_problems.include? problem
-            -     else
-            -       return problem_in_user_contests? problem
-            -     end
                 end
                 def self.clear_last_login
                   User.update_all(:last_ip => nil)
                 end
                 protected
                   def encrypt_new_password
                     return if password.blank?
                     self.salt = (10+rand(90)).to_s
                     self.hashed_password = User.encrypt(self.password,self.salt)
                   end
                   def assign_default_site
                     # have to catch error when migrating (because self.site is not available).
                     begin
                       if self.site==nil
                         self.site = Site.find_by_name('default')
                         if self.site==nil
                           self.site = Site.find(1)  # when 'default has be renamed'
                         end
                       end
                     rescue
                     end

app/views/graders/task.html.haml ¶ +1 -1

               %h1= "Task: #{@task.id}"
               %p
                 User:
                 = "#{@task.submission.user.login}"
                 %br/
                 Status:
                 = "#{@task.status_str} (at #{format_short_time(@task.updated_at)})"
                 %br/
                 = "Submission: #{@task.submission_id}"
                 - if @task.submission !=nil
-            -     = link_to '[view submission]', :action => 'submission', :id => @task.submission.id
+            +     = link_to '[view submission]', submission_path( @task.submission.id )
                 %br/
                 = "Submitted at: #{format_short_time(@task.created_at)}"
                 %br/

app/views/groups/show.html.haml ¶ +6 -5

               %p
                 %b Name:
                 = @group.name
               %p
                 %b Description:
                 = @group.description
               %br
               = link_to 'Edit', edit_group_path(@group)
               \|
               = link_to 'Back', groups_path
               .row
-            -   %h1 Group details
+            +   .col-md-12
+            +     %h1 Group details
               .row
                 .col-md-6
                   .panel.panel-default
                     .panel-heading
                       .panel-title Users in this group
                     .panel-body
                       =form_tag add_user_group_path(@group), class: 'form-inline' do
                         .form-group
                           =label_tag :user_id, "User"
                           =select_tag :user_id, options_from_collection_for_select(User.all,'id','full_name'), class: 'select2'
                         =submit_tag "Add",class: 'btn btn-primary'
                       %table.table.table-hover
                         %thead
                           %tr
                             %th Login
                             %th Full name
                             %th Remark
-            -               %th
+            +               %th= link_to 'Remove All', remove_all_user_group_path(@group), method: :delete, :data => { :confirm => "Remove ALL USERS from group?" }, class: 'btn btn-danger btn-sm'
                         %tbody
                           - @group.users.each do |user|
                             %tr
                               %td= user.login
                               %td= user.full_name
                               %td= user.remark
-            -                 %td= link_to 'Remove', remove_user_group_path(@group,user), :method => :delete, :data => { :confirm => "Remove #{user.full_name}?" }, class: 'btn btn-danger'
+            +                 %td= link_to 'Remove', remove_user_group_path(@group,user), :method => :delete, :data => { :confirm => "Remove #{user.full_name}?" }, class: 'btn btn-danger btn-sm'
                 .col-md-6
                   .panel.panel-default
                     .panel-heading
                       .panel-title Problems
                     .panel-body
                       =form_tag add_problem_group_path(@group), class: 'form-inline' do
                         .form-group
                           =label_tag :problem_id, "Problem"
                           =select_tag :problem_id, options_from_collection_for_select(Problem.all,'id','full_name'), class: 'select2'
                         =submit_tag "Add",class: 'btn btn-primary'
                       %table.table.table-hover
                         %thead
                           %tr
                             %th name
                             %th Full name
                             %th Full score
-            -               %th
+            +               %th= link_to 'Remove All', remove_all_problem_group_path(@group), method: :delete, :data => { :confirm => "Remove ALL PROBLEMS from group?" }, class: 'btn btn-danger btn-sm'
                         %tbody
                           - @group.problems.each do |problem|
                             %tr
                               %td= problem.name
                               %td= problem.full_name
                               %td= problem.full_score
-            -                 %td= link_to 'Remove', remove_problem_group_path(@group,problem), :method => :delete, :data => { :confirm => "Remove #{problem.full_name}?" }, class: 'btn btn-danger'
+            +                 %td= link_to 'Remove', remove_problem_group_path(@group,problem), :method => :delete, :data => { :confirm => "Remove #{problem.full_name}?" }, class: 'btn btn-danger btn-sm'

app/views/problems/index.html.haml ¶ +7 -1

               - content_for :head do
                 = stylesheet_link_tag 'problems'
               %h1 Problems
               %p
                 = link_to 'Import problems', {:action => 'import'}, class: 'btn btn-success btn-sm'
                 = link_to 'New problem', new_problem_path, class: 'btn btn-success btn-sm'
                 = link_to 'Bulk Manage', { action: 'manage'}, class: 'btn btn-info btn-sm'
                 = link_to 'Turn off all problems', {:action => 'turn_all_off'}, class: 'btn btn-default btn-sm'
                 = link_to 'Turn on all problems', {:action => 'turn_all_on'}, class: 'btn btn-default btn-sm'
               .submitbox
                 = form_tag :action => 'quick_create' do
                   %b Quick New:
                   %label{:for => "problem_name"} Name
                   = text_field 'problem', 'name'
                   |
                   %label{:for => "problem_full_name"} Full name
                   = text_field 'problem', 'full_name'
                   = submit_tag "Create"
               %table.table.table-condense.table-hover
                 %thead
                   %th Name
                   %th Full name
                   %th.text-right Full score
+            +     %th
+            +       Submit
+            +       %sup{class: 'text-primary',data: {toggle: 'tooltip'}, title: 'Admin can always submit to any problem' } [?]
                   %th Date added
                   %th.text-center
                     Avail?
                     %sup{class: 'text-primary',data: {toggle: 'tooltip'}, title: 'Let user submits to this problem?' } [?]
                   %th.text-center
                     View Data?
                     %sup{class: 'text-primary',data: {toggle: 'tooltip'}, title: 'Let user view the testcase of this problem?' } [?]
                   %th.text-center
                     Test?
                     %sup{class: 'text-primary',data: {toggle: 'tooltip'}, title: 'Let user uses test interface on this problem?' } [?]
                   - if GraderConfiguration.multicontests?
                     %th Contests
                 - for problem in @problems
                   %tr{:class => "#{(problem.available) ? "success" : "danger"}", :id => "prob-#{problem.id}", :name => "prob-#{problem.id}"}
                     - @problem=problem
                     %td= problem.name #in_place_editor_field :problem, :name, {}, :rows=>1
-            -       %td= problem.full_name #in_place_editor_field :problem, :full_name, {}, :rows=>1
+            +       %td
+            +         = problem.full_name #in_place_editor_field :problem, :full_name, {}, :rows=>1
+            +         = link_to_description_if_any "[#{t 'main.problem_desc'}] <span class='glyphicon glyphicon-file'></span>".html_safe, problem
                     %td.text-right= problem.full_score #in_place_editor_field :problem, :full_score, {}, :rows=>1
+            +       %td= link_to "Submit", direct_edit_problem_submissions_path(problem), class: 'btn btn-xs btn-primary'
                     %td= problem.date_added
                     %td= toggle_button(@problem.available?, toggle_problem_path(@problem), "problem-avail-#{@problem.id}")
                     %td= toggle_button(@problem.view_testcase?, toggle_view_testcase_problem_path(@problem), "problem-view-testcase-#{@problem.id}")
                     %td= toggle_button(@problem.test_allowed?, toggle_test_problem_path(@problem), "problem-test-#{@problem.id}")
                     - if GraderConfiguration.multicontests?
                       %td
                         = problem.contests.collect { |c| c.name }.join(', ')
                     %td= link_to 'Stat', {:action => 'stat', :id => problem.id}, class: 'btn btn-info btn-xs btn-block'
                     %td= link_to 'Show', {:action => 'show', :id => problem}, class: 'btn btn-info btn-xs btn-block'
                     %td= link_to 'Edit', {:action => 'edit', :id => problem}, class: 'btn btn-info btn-xs btn-block'
                     %td= link_to 'Destroy', { :action => 'destroy', :id => problem }, :confirm => 'Are you sure?', :method => :delete, class: 'btn btn-danger btn-xs btn-block'
               %br/
               = link_to '[New problem]', :action => 'new'

config/routes.rb ¶ +5

                   member do
                     get 'toggle','toggle_front'
                   end
                 end
                 resources :problems do
                   member do
                     get 'toggle'
                     get 'toggle_test'
                     get 'toggle_view_testcase'
                     get 'stat'
                   end
                   collection do
                     get 'turn_all_off'
                     get 'turn_all_on'
                     get 'import'
                     get 'manage'
                   end
                 end
                 resources :groups do
                   member do
                     post 'add_user', to: 'groups#add_user', as: 'add_user'
                     delete 'remove_user/:user_id', to: 'groups#remove_user', as: 'remove_user'
+            +       delete 'remove_all_user', to: 'groups#remove_all_user', as: 'remove_all_user'
                     post 'add_problem', to: 'groups#add_problem', as: 'add_problem'
                     delete 'remove_problem/:problem_id', to: 'groups#remove_problem', as: 'remove_problem'
+            +       delete 'remove_all_problem', to: 'groups#remove_all_problem', as: 'remove_all_problem'
+            +     end
+            +     collection do
+            +
                   end
                 end
                 resources :testcases, only: [] do
                   member do
                     get 'download_input'
                     get 'download_sol'
                   end
                   collection do
                     get 'show_problem/:problem_id(/:test_num)' => 'testcases#show_problem', as: 'show_problem'
                   end
                 end
                 resources :grader_configuration, controller: 'configurations'
                 resources :users do
                   member do
                     get 'toggle_activate', 'toggle_enable'
                     get 'stat'
                   end
                 end
                 resources :submissions do
                   member do

app/views/graders/submission.html.haml removed ¶ -87

deleted file

Write
Preview

You need to be logged in to leave comments. Login now

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository permissions settings

Sign in to your account

Author

r680:4ce0b8696d06 - Thu, 14 Sep 2017 14:45:10 - 9 files changed: 35 inserted, 138 deleted

Sign in to your account

Commit r680:4ce0b8696d06 public

Author

r680:4ce0b8696d06 - Thu, 14 Sep 2017 14:45:10 - 9 files changed: 35 inserted, 138 deleted

Commit `r680:4ce0b8696d06` public