cafe-grader-web Commit - r682:405106fcdb33

cafe-grader-web

parent | child

Description:

fix allow admin to submit to any problem

Commit status:

[Not Reviewed]

References:

java

Diff options:

| | | |

Comments:

0 Commit comments 0 Inline Comments

Unresolved TODOs:

There are no unresolved TODOs

Add another comment

r682:405106fcdb33 - Sun, 17 Sep 2017 07:48:36 - 7 files changed: 17 inserted, 5 deleted

app/controllers/main_controller.rb ¶ +1 -1

                     render :action => 'list' and return
                   end
-            -     if @submission.valid?
+            +     if @submission.valid?(@current_user)
                     if @submission.save == false
                       flash[:notice] = 'Error saving your submission'
                     elsif Task.create(:submission_id => @submission.id,

app/controllers/submissions_controller.rb ¶ +5

                 def direct_edit_problem
                   @problem = Problem.find(params[:problem_id])
                   @source = ''
+            +     if (params[:user_id])
+            +       u = User.find(params[:user_id])
+            +       @submission = Submission.find_last_by_user_and_problem(u.id,@problem.id)
+            +       @source = @submission.source.to_s if @submission and @submission.source
+            +     end
                   render 'edit'
                 end

app/models/submission.rb ¶ +6 -2

                   return if self.source==nil
                   if self.problem==nil
                     errors.add('problem',"must be specified.")
-            -     elsif (!self.problem.available) and (self.new_record?)
+            +     else
-            -       errors.add('problem',"must be valid.")
+            +       #admin always have right
+            +       return if self.user.admin?
+            +
+            +       #check if user has the right to submit the problem
+            +       errors.add('problem',"must be valid.") if (!self.user.available_problem.include?(self.problem)) and (self.new_record?)
                   end
                 end

app/models/user.rb ¶ +1

                   return true
                 end
+            +   #get a list of available problem
                 def available_problems
                   if not GraderConfiguration.multicontests?
                     if GraderConfiguration.use_problem_group?

app/views/problems/index.html.haml ¶ +1 -1

                       = problem.full_name #in_place_editor_field :problem, :full_name, {}, :rows=>1
                       = link_to_description_if_any "[#{t 'main.problem_desc'}] <span class='glyphicon glyphicon-file'></span>".html_safe, problem
                     %td.text-right= problem.full_score #in_place_editor_field :problem, :full_score, {}, :rows=>1
-            -       %td= link_to "Submit", direct_edit_problem_submissions_path(problem), class: 'btn btn-xs btn-primary'
+            +       %td= link_to "Submit", direct_edit_problem_submissions_path(problem,@current_user.id), class: 'btn btn-xs btn-primary'
                     %td= problem.date_added
                     %td= toggle_button(@problem.available?, toggle_problem_path(@problem), "problem-avail-#{@problem.id}")
                     %td= toggle_button(@problem.view_testcase?, toggle_view_testcase_problem_path(@problem), "problem-view-testcase-#{@problem.id}")

app/views/submissions/edit.html.haml ¶ +2

                   .col-md-8
                     %div#editor{style: 'height: 500px; border-radius: 7px; font-size: 14px;'}
                   .col-md-4
+            +       - # submission form
                     = form_tag({controller: :main, :action => 'submit'}, :multipart => true, class: 'form') do
                       = hidden_field_tag 'editor_text', @source
                       .form-group
                         = submit_tag 'Submit', class: 'btn btn-success', id: 'live_submit',
                           data: {confirm: "Submitting this source code for task #{@problem.long_name}?"}
+            +       - # latest submission status
                     .panel.panel-info
                       .panel-heading
                         Latest Submission Status

config/routes.rb ¶ +1 -1

                   end
                   collection do
                     get 'prob/:problem_id', to: 'submissions#index', as: 'problem'
-            -       get 'direct_edit_problem/:problem_id', to: 'submissions#direct_edit_problem', as: 'direct_edit_problem'
+            +       get 'direct_edit_problem/:problem_id(/:user_id)', to: 'submissions#direct_edit_problem', as: 'direct_edit_problem'
                     get 'get_latest_submission_status/:uid/:pid', to: 'submissions#get_latest_submission_status', as: 'get_latest_submission_status'
                   end
                 end

You need to be logged in to leave comments. Login now

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository permissions settings