cafe-grader-web Commit - r35:3d41a77d4876

cafe-grader-web

Commit `r35:3d41a77d4876` public

parent | child

Description:

added number (auto generated when submitting) to submissions git-svn-id: http://theory.cpe.ku.ac.th/grader/web/trunk@73 6386c4cd-e34a-4fa8-8920-d93eb39b512e

Commit status:

[Not Reviewed]

References:

default

Diff options:

| | | |

Comments:

0 Commit comments 0 Inline Comments

Unresolved TODOs:

There are no unresolved TODOs

Add another comment

r35:3d41a77d4876 - Mon, 03 Mar 2008 17:22:16 - 6 files changed: 62 inserted, 18 deleted

db/migrate/018_add_number_to_submissions.rb created 644 ¶ +33

@@ -0,0 +1,33
	1	+ class AddNumberToSubmissions < ActiveRecord::Migration
	2	+ def self.up
	3	+ add_column :submissions, :number, :integer
	4	+
	5	+ # add number field for all records
	6	+ Submission.reset_column_information
	7	+
	8	+ last_user_id = nil
	9	+ last_problem_id = nil
	10	+ current_number = 0
	11	+
	12	+ Submission.find(:all,
	13	+ :order => 'user_id, problem_id, submitted_at').each do \|submission\|
	14	+ if submission.user_id==last_user_id and submission.problem_id==last_problem_id
	15	+ current_number += 1
	16	+ else
	17	+ current_number = 1
	18	+ end
	19	+ submission.number = current_number
	20	+ submission.save
	21	+
	22	+ last_user_id = submission.user_id
	23	+ last_problem_id = submission.problem_id
	24	+ end
	25	+
	26	+ add_index :submissions, [:user_id, :problem_id, :number], :unique => true
	27	+ end
	28	+
	29	+ def self.down
	30	+ remove_index :submissions, :column => [:user_id, :problem_id, :number]
	31	+ remove_column :submissions, :number
	32	+ end
	33	+ end

app/controllers/main_controller.rb ¶ +6 -2

                 protected
                 def prepare_list_information
                   @problems = Problem.find_available_problems
                   @prob_submissions = Array.new
                   @user = User.find(session[:user_id])
                   @problems.each do |p|
-            -       c, sub = Submission.find_by_user_and_problem(@user.id,p.id)
+            +       sub = Submission.find_last_by_user_and_problem(@user.id,p.id)
-            -       @prob_submissions << { :count => c, :submission => sub }
+            +       if sub!=nil
+            +         @prob_submissions << { :count => sub.number, :submission => sub }
+            +       else
+            +         @prob_submissions << { :count => 0, :submission => nil }
+            +       end
                   end
                 end
               end

app/controllers/problems_controller.rb ¶ +1 -1

                   problem.save
                   redirect_to :action => 'list'
                 end
                 def stat
                   @problem = Problem.find(params[:id])
-            -     @submissions = Submission.find_last_by_problem(params[:id])
+            +     @submissions = Submission.find_all_last_by_problem(params[:id])
                 end
               end

app/controllers/user_admin_controller.rb ¶ +2 -2

                   @users = User.find(:all)
                   @scorearray = Array.new
                   @users.each do |u|
                     ustat = Array.new
                     ustat[0] = u.login
                     @problems.each do |p|
-            - 	c, sub = Submission.find_by_user_and_problem(u.id,p.id)
+            + 	sub = Submission.find_last_by_user_and_problem(u.id,p.id)
-            - 	if (c!=0) and (sub.points!=nil)
+            + 	if (sub!=nil) and (sub.points!=nil)
               	  ustat << [sub.points, (sub.points>=p.full_score)]
               	else
               	  ustat << [0,false]
               	end
                     end
                     @scorearray << ustat

app/models/submission.rb ¶ +17 -12

                 validates_presence_of :source
                 validates_length_of :source, :maximum => 100_000, :allow_blank => true, :message => 'too long'
                 validates_length_of :source, :minimum => 1, :allow_blank => true, :message => 'too short'
                 validate :must_specify_language
                 validate :must_have_valid_problem
-            -   def self.find_by_user_and_problem(user_id, problem_id)
+            +   before_save :assign_latest_number
-            -     subcount = count(:conditions => "user_id = #{user_id} AND problem_id = #{problem_id}")
-            -     if subcount != 0
+            +   def self.find_last_by_user_and_problem(user_id, problem_id)
-            -       last_sub = find(:first,
+            +     last_sub = find(:first,
-            - 		      :conditions => {:user_id => user_id,
+            +                     :conditions => {:user_id => user_id,
-            - 			:problem_id => problem_id},
+            +                       :problem_id => problem_id},
-            - 		      :order => 'submitted_at DESC')
+            +                     :order => 'submitted_at DESC')
-            -     else
+            +     return last_sub
-            -       last_sub = nil
-            -     end
-            -     return subcount, last_sub
                 end
-            -   def self.find_last_by_problem(problem_id)
+            +   def self.find_all_last_by_problem(problem_id)
                   # need to put in SQL command, maybe there's a better way
                   Submission.find_by_sql("SELECT * FROM submissions " +
               			   "WHERE id = " +
               			   "(SELECT MAX(id) FROM submissions AS subs " +
               			   "WHERE subs.user_id = submissions.user_id AND " +
                                          "problem_id = " + problem_id.to_s + " " +
               			   "GROUP BY user_id)")
                 end
+            +   protected
+            +
                 def self.find_option_in_source(option, source)
                   if source==nil
                     return nil
                   end
                   i = 0
                   source.each_line do |s|
                     errors.add_to_base("must specify problem")
                   elsif !problem.available
                     errors.add_to_base("must specify valid problem")
                   end
                 end
+            +   # callbacks
+            +   def assign_latest_number
+            +     latest = Submission.find_last_by_user_and_problem(self.user_id, self.problem_id)
+            +     self.number = (latest==nil) ? 1 : latest.number + 1;
+            +   end
+            +
               end

db/schema.rb ¶ +3 -1

               # to create the application database on another system, you should be using db:schema:load, not running
               # all the migrations from scratch. The latter is a flawed and unsustainable approach (the more migrations
               # you'll amass, the slower it'll run and the greater likelihood for issues).
               #
               # It's strongly recommended to check this file into your version control system.
-            - ActiveRecord::Schema.define(:version => 17) do
+            + ActiveRecord::Schema.define(:version => 18) do
                 create_table "grader_processes", :force => true do |t|
                   t.string   "host",       :limit => 20
                   t.integer  "pid"
                   t.string   "mode"
                   t.boolean  "active"
                   t.datetime "submitted_at"
                   t.datetime "compiled_at"
                   t.text     "compiler_message"
                   t.datetime "graded_at"
                   t.integer  "points"
                   t.text     "grader_comment"
+            +     t.integer  "number"
                 end
+            +   add_index "submissions", ["user_id", "problem_id", "number"], :name => "index_submissions_on_user_id_and_problem_id_and_number", :unique => true
                 add_index "submissions", ["user_id", "problem_id"], :name => "index_submissions_on_user_id_and_problem_id"
                 create_table "tasks", :force => true do |t|
                   t.integer  "submission_id"
                   t.datetime "created_at"
                   t.integer  "status"

Write
Preview

You need to be logged in to leave comments. Login now

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository permissions settings

Sign in to your account

Author

r35:3d41a77d4876 - Mon, 03 Mar 2008 17:22:16 - 6 files changed: 62 inserted, 18 deleted

Sign in to your account

Commit r35:3d41a77d4876 public

Author

r35:3d41a77d4876 - Mon, 03 Mar 2008 17:22:16 - 6 files changed: 62 inserted, 18 deleted

Commit `r35:3d41a77d4876` public