cafe-grader-web Commit - r223:1586858ff9d5

cafe-grader-web

Commit `r223:1586858ff9d5` public

parent | child

Description:

shows recent problem after wrong submissions

Commit status:

[Not Reviewed]

References:

default

Diff options:

| | | |

Comments:

0 Commit comments 0 Inline Comments

Unresolved TODOs:

There are no unresolved TODOs

Add another comment

r223:1586858ff9d5 - Tue, 26 Jan 2010 02:08:22 - 4 files changed: 32 inserted, 12 deleted

app/controllers/main_controller.rb ¶ +13

                   if params[:id]==nil
                     @problem = nil
                     @submissions = nil
                   else
                     @problem = Problem.find_by_name(params[:id])
                     if not @problem.available
                       redirect_to :action => 'list'
                       flash[:notice] = 'Error: submissions for that problem are not viewable.'
                       return
                     end
                     @submissions = Submission.find_all_by_user_problem(@user.id, @problem.id)
                   end
                 end
                 def result
                   if !Configuration.show_grading_result
                     redirect_to :action => 'list' and return
                   end
                   @user = User.find(session[:user_id])
                   @submission = Submission.find(params[:id])
                   if @submission.user!=@user
                     flash[:notice] = 'You are not allowed to view result of other users.'
                     redirect_to :action => 'list' and return
                   end
                   prepare_grading_result(@submission)
                 end
                 def load_output
                   if !Configuration.show_grading_result or params[:num]==nil
                     redirect_to :action => 'list' and return
                   end
                   @user = User.find(session[:user_id])
                   @submission = Submission.find(params[:id])
                   if @submission.user!=@user
                     flash[:notice] = 'You are not allowed to view result of other users.'
                     redirect_to :action => 'list' and return
                   end
                   case_num = params[:num].to_i
                   out_filename = output_filename(@user.login,
                                                  @submission.problem.name,
                                                  @submission.id,
                                                  case_num)
                   if !FileTest.exists?(out_filename)
                     flash[:notice] = 'Output not found.'
                     redirect_to :action => 'list' and return
                   end
                   response.headers['Content-Type'] = "application/force-download"
                   response.headers['Content-Disposition'] = "attachment; filename=\"output-#{case_num}.txt\""
                   response.headers["X-Sendfile"] = out_filename
                   response.headers['Content-length'] = File.size(out_filename)
                   render :nothing => true
                 end
                 def error
                   @user = User.find(session[:user_id])
                 end
                 # announcement refreshing and hiding methods
                 def announcements
                   if params.has_key? 'recent'
                     prepare_announcements(params[:recent])
                   else
                     prepare_announcements
                   end
                   render(:partial => 'announcement',
                          :collection => @announcements,
                          :locals => {:announcement_effect => true})
                 end
                 #
                 # actions for Code Jom
                 #
                 def download_input
                   problem = Problem.find(params[:id])
                   user = User.find(session[:user_id])
                   if user.can_request_new_test_pair_for? problem
                     assignment = user.get_new_test_pair_assignment_for problem
                     assignment.save
                     send_data(assignment.test_pair.input,
                               { :filename => "#{problem.name}-#{assignment.request_number}.in",
                                 :type => 'text/plain' })
                   else
                     recent_assignment = user.get_recent_test_pair_assignment_for problem
                     send_data(recent_assignment.test_pair.input,
                               { :filename => "#{problem.name}-#{recent_assignment.request_number}.in",
                                 :type => 'text/plain' })
                   end
                 end
                 def submit_solution
                   problem = Problem.find(params[:id])
                   user = User.find(session[:user_id])
                   recent_assignment = user.get_recent_test_pair_assignment_for problem
+            +
                   if recent_assignment == nil
                     flash[:notice] = 'You have not requested for any input data for this problem.  Please download an input first.'
+            +       session[:current_problem_id] = problem.id
                     redirect_to :action => 'list' and return
                   end
                   if recent_assignment.expired?
                     flash[:notice] = 'The current input is expired.  Please download a new input data.'
+            +       session[:current_problem_id] = problem.id
                     redirect_to :action => 'list' and return
                   end
                   if recent_assignment.submitted
                     flash[:notice] = 'You have already submitted an incorrect solution for this input.  Please download a new input data.'
+            +       session[:current_problem_id] = problem.id
                     redirect_to :action => 'list' and return
                   end
                   if params[:file] == nil
                     flash[:notice] = 'You have not submitted any output.'
+            +       session[:current_problem_id] = problem.id
                     redirect_to :action => 'list' and return
                   end
                   submitted_solution = params[:file].read
                   test_pair = recent_assignment.test_pair
                   passed = test_pair.grade(submitted_solution)
                   points = passed ? 100 : 0
                   submission = Submission.new(:user => user,
                                               :problem => problem,
                                               :source => submitted_solution,
                                               :source_filename => params['file'].original_filename,
                                               :language_id => 0,
                                               :submitted_at => Time.new.gmtime,
                                               :graded_at => Time.new.gmtime,
                                               :points => points)
                   submission.save
                   recent_assignment.submitted = true
                   recent_assignment.save
                   status = user.get_submission_status_for(problem)
                   if status == nil
                     status = SubmissionStatus.new :user => user, :problem => problem, :submission_count => 0
                   end
                   status.submission_count += 1
                   status.passed = passed
                   status.save
                   if passed
                     flash[:notice] = 'Correct solution.'
                     user.update_codejom_status
                   else
+            +       session[:current_problem_id] = problem.id
                     flash[:notice] = 'Incorrect solution.'
                   end
                   redirect_to :action => 'list'
                 end
                 protected
                 def prepare_announcements(recent=nil)
                   if Configuration.show_tasks_to?(@user)
                     @announcements = Announcement.find_published(true)
                   else
                     @announcements = Announcement.find_published
                   end
                   if recent!=nil
                     recent_id = recent.to_i
                     @announcements = @announcements.find_all { |a| a.id > recent_id }
                   end
                 end
                 def prepare_list_information
                   @user = User.find(session[:user_id])
                   all_problems = Problem.find_available_problems
                   passed = {}
                   sub_count = {}
                   @user.submission_statuses.each do |status|
                     if status.passed
                       passed[status.problem_id] = true
                     end
                     sub_count[status.problem_id] = status.submission_count
                   end
+            +     if session.has_key? :current_problem_id
+            +       @current_problem_id = session[:current_problem_id]
+            +       session.delete(:current_problem_id)
+            +     else
+            +       @current_problem_id = nil
+            +     end
+            +
                   @problems = all_problems.reject { |problem| passed.has_key? problem.id }
                   @prob_submissions = Array.new
                   @problems.each do |p|
                     if sub_count.has_key? p.id
                       @prob_submissions << { :count => sub_count[p.id] }
                     else
                       @prob_submissions << { :count => 0 }
                     end
                   end
                   prepare_announcements
                 end
                 def check_viewability
                   @user = User.find(session[:user_id])
                   if (!Configuration.show_tasks_to?(@user)) and
                       ((action_name=='submission') or (action_name=='submit'))
                     redirect_to :action => 'list' and return
                   end
                 end
                 def prepare_grading_result(submission)
                   if Configuration.task_grading_info.has_key? submission.problem.name
                     grading_info = Configuration.task_grading_info[submission.problem.name]
                   else
                     # guess task info from problem.full_score
                     cases = submission.problem.full_score / 10
                     grading_info = {
                       'testruns' => cases,
                       'testcases' => cases
                     }
                   end
                   @test_runs = []
                   if grading_info['testruns'].is_a? Integer
                     trun_count = grading_info['testruns']
                     trun_count.times do |i|
                       @test_runs << [ read_grading_result(@user.login,
                                                           submission.problem.name,
                                                           submission.id,
                                                           i+1) ]
                     end
                   else
                     grading_info['testruns'].keys.sort.each do |num|
                       run = []
                       testrun = grading_info['testruns'][num]
                       testrun.each do |c|
                         run << read_grading_result(@user.login,
                                                    submission.problem.name,
                                                    submission.id,
                                                    c)
                       end
                       @test_runs << run
                     end
                   end
                 end
                 def grading_result_dir(user_name, problem_name, submission_id, case_num)
                   return "#{GRADING_RESULT_DIR}/#{user_name}/#{problem_name}/#{submission_id}/test-result/#{case_num}"
                 end
                 def output_filename(user_name, problem_name, submission_id, case_num)
                   dir = grading_result_dir(user_name,problem_name, submission_id, case_num)
                   return "#{dir}/output.txt"
                 end
                 def read_grading_result(user_name, problem_name, submission_id, case_num)
                   dir = grading_result_dir(user_name,problem_name, submission_id, case_num)
                   result_file_name = "#{dir}/result"
                   if !FileTest.exists?(result_file_name)
                     return {:num => case_num, :msg => 'program did not run'}
                   else
                     results = File.open(result_file_name).readlines
                     run_stat = extract_running_stat(results)
                     output_filename = "#{dir}/output.txt"
                     if FileTest.exists?(output_filename)
                       output_file = true
                       output_size = File.size(output_filename)
                     else
                       output_file = false
                       output_size = 0
                     end
                     return {
                       :num => case_num,
                       :msg => results[0],
                       :run_stat => run_stat,
                       :output => output_file,
                       :output_size => output_size
                     }
                   end
                 end
                 # copied from grader/script/lib/test_request_helper.rb
                 def extract_running_stat(results)
                   running_stat_line = results[-1]

app/models/problem.rb ¶ +6 -2

               class Problem < ActiveRecord::Base
                 belongs_to :description
                 has_many :test_pairs, :dependent => :delete_all
                 validates_presence_of :name
                 validates_format_of :name, :with => /^\w+$/
                 validates_presence_of :full_name
                 DEFAULT_TIME_LIMIT = 1
                 DEFAULT_MEMORY_LIMIT = 32
                 def test_pair_count
                   @test_pair_count ||= test_pairs.size
                 end
                 def uses_random_test_pair?
                   test_pair_count != 0
                 end
                 def random_test_pair(forbidden_numbers=nil)
-            -     begin
+            +     if forbidden_numbers.length < test_pair_count
+            +       begin
+            +         test_num = 1 + rand(test_pair_count)
+            +       end while forbidden_numbers!=nil and forbidden_numbers.include? test_num
+            +     else
                     test_num = 1 + rand(test_pair_count)
-            -     end while forbidden_numbers!=nil and forbidden_numbers.include? test_num
+            +     end
                   test_pairs.find_by_number test_num
                 end
                 def self.find_available_problems
                   find(:all, :conditions => {:available => true}, :order => "date_added DESC")
                 end
                 # TODO: may try to optimize this using cache
                 def self.available_problem_count
                   return Problem.find_available_problems.length
                 end
                 def self.create_from_import_form_params(params, old_problem=nil)
                   problem = old_problem || Problem.new
                   import_params = Problem.extract_params_and_check(params, problem)
                   if not problem.valid?
                     return problem, 'Error importing'
                   end
                   problem.full_score = 100
                   problem.date_added = Time.new
                   problem.test_allowed = true
                   problem.output_only = false
                   problem.available = false
                   if not problem.save
                     return problem, 'Error importing'
                   end
                   import_to_db = params.has_key? :import_to_db
                   importer = TestdataImporter.new(problem)
                   if not importer.import_from_file(import_params[:file],
                                                    import_params[:time_limit],
                                                    import_params[:memory_limit],
                                                    import_to_db)
                     problem.errors.add_to_base('Import error.')
                   end
                   return problem, importer.log_msg
                 end
                 protected
                 def self.to_i_or_default(st, default)
                   if st!=''
                     st.to_i
                   else
                     default
                   end
                 end
                 def self.extract_params_and_check(params, problem)
                   time_limit = Problem.to_i_or_default(params[:time_limit],
                                                        DEFAULT_TIME_LIMIT)
                   memory_limit = Problem.to_i_or_default(params[:memory_limit],
                                                          DEFAULT_MEMORY_LIMIT)
                   if time_limit==0 and time_limit_s!='0'
                     problem.errors.add_to_base('Time limit format errors.')
                   elsif time_limit<=0 or time_limit >60
                     problem.errors.add_to_base('Time limit out of range.')
                   end
                   if memory_limit==0 and memory_limit_s!='0'
                     problem.errors.add_to_base('Memory limit format errors.')
                   elsif memory_limit<=0 or memory_limit >512
                     problem.errors.add_to_base('Memory limit out of range.')
                   end
                   if params[:file]==nil or params[:file]==''
                     problem.errors.add_to_base('No testdata file.')
                   end
                   file = params[:file]
                   if problem.errors.length!=0
                     return problem
                   end
                   problem.name = params[:name]
                   if params[:full_name]!=''
                     problem.full_name = params[:full_name]
                   else
                     problem.full_name = params[:name]
                   end
                   return {
                     :time_limit => time_limit,
                     :memory_limit => memory_limit,
                     :file => file
                   }
                 end

app/views/main/_problem.html.haml ¶ +8 -6

-            - .problem-panel{:id => "problem-panel-#{problem.id}", :style => "display:none"}
+            + .problem-panel{:id => "problem-panel-#{problem.id}", :style => "#{(problem.id != @current_problem_id) ? "display:none" : ""}"}
                 .problem-form{:id => "problem-form-#{problem.id}"}
                   - form_tag({ :action => 'download_input', :id => problem.id }, :method => :post) do
                     %b Input:
                     %input{:type => "submit", :value => "Download input"}
-            -       = "After downloading, you have #{TEST_ASSIGNMENT_EXPIRATION_DURATION/60} minutes to submit."
+            +       %span{:id => "problem-timing-message-#{problem.id}"}
-            -     - form_tag({ :action => 'submit_solution', :id => problem.id }, :method => :post, :multipart => true) do
+            +         = "After downloading, you have #{TEST_ASSIGNMENT_EXPIRATION_DURATION/60} minutes to submit."
-            -       %b Submit output:
+            +     %div{:id => "problem-submission-form-#{problem.id}"}
-            -       %input{:type => "file", :name => "file"}
+            +       - form_tag({ :action => 'submit_solution', :id => problem.id }, :method => :post, :multipart => true) do
-            -       %input{:type => "submit", :value => "Submit solution"}
+            +         %b Submit output:
+            +         %input{:type => "file", :name => "file"}
+            +         %input{:type => "submit", :value => "Submit solution"}
                 .problem-description
                   - if problem.description!=nil
                     - if problem.description.markdowned
                       = markdown(problem.description.body)
                     - else
                       = problem.description.body
                   - else
                     (not available)

app/views/main/list.html.haml ¶ +5 -4

               - content_for :head do
                 = javascript_include_tag :defaults
                 %script{:type => 'text/javascript', :src => '/javascripts/announcement_refresh.js'}
               = user_title_bar(@user)
               - if @announcements.length!=0
                 .announcementbox
                   %span{:class => 'title'}
                     Announcements
                   #announcementbox-body
                     = render :partial => 'announcement', :collection => @announcements
               %hr/
               - if (Configuration.contest_mode?) and (@user.site!=nil) and (@user.site.started!=true)
                 %p=t 'main.start_soon'
               - if Configuration.show_tasks_to?(@user)
                 .problem-list
                   = render :partial => 'problem_title', :collection => @problems, :as => :problem
                 .problem-content
-            -     %span{:id => "problem-panel-filler"}
+            +     - if @current_problem_id==nil
-            -       %b Welcome to Code Jom
+            +       %span{:id => "problem-panel-filler"}
-            -       %br/
+            +         %b Welcome to Code Jom
-            -       Choose problems from the list on the right.
+            +         %br/
+            +         Choose problems from the list on the right.
                   = render :partial => 'problem', :collection => @problems
               %br{:clear=>'both'}/
               %hr/
               :javascript
                 Announcement.registerRefreshEventTimer();

Write
Preview

You need to be logged in to leave comments. Login now

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository permissions settings

Sign in to your account

Author

r223:1586858ff9d5 - Tue, 26 Jan 2010 02:08:22 - 4 files changed: 32 inserted, 12 deleted

Sign in to your account

Commit r223:1586858ff9d5 public

Author

r223:1586858ff9d5 - Tue, 26 Jan 2010 02:08:22 - 4 files changed: 32 inserted, 12 deleted

Commit `r223:1586858ff9d5` public