Description:
fixed login box showing in announcement box after user logged out in other tabs
Commit status:
[Not Reviewed]
References:
Diff options:
Comments:
0 Commit comments
0 Inline Comments
Unresolved TODOs:
There are no unresolved TODOs
r249:11f906d2e75a - - 1 file changed: 10 inserted, 0 deleted
@@ -1,31 +1,35 | |||
|
1 | 1 | class MainController < ApplicationController |
|
2 | 2 | |
|
3 | 3 | before_filter :authenticate, :except => [:index, :login] |
|
4 | 4 | before_filter :check_viewability, :except => [:index, :login] |
|
5 | 5 | |
|
6 | 6 | append_before_filter :update_user_start_time, :except => [:index, :login] |
|
7 | 7 | |
|
8 | + # to prevent log in box to be shown when user logged out of the | |
|
9 | + # system only in some tab | |
|
10 | + prepend_before_filter :reject_announcement_refresh_when_logged_out, :only => [:announcements] | |
|
11 | + | |
|
8 | 12 | # COMMENTED OUT: filter in each action instead |
|
9 | 13 | # before_filter :verify_time_limit, :only => [:submit] |
|
10 | 14 | |
|
11 | 15 | verify :method => :post, :only => [:submit], |
|
12 | 16 | :redirect_to => { :action => :index } |
|
13 | 17 | |
|
14 | 18 | # COMMENT OUT: only need when having high load |
|
15 | 19 | # caches_action :index, :login |
|
16 | 20 | |
|
17 | 21 | # NOTE: This method is not actually needed, 'config/routes.rb' has |
|
18 | 22 | # assigned action login as a default action. |
|
19 | 23 | def index |
|
20 | 24 | redirect_to :action => 'login' |
|
21 | 25 | end |
|
22 | 26 | |
|
23 | 27 | def login |
|
24 | 28 | saved_notice = flash[:notice] |
|
25 | 29 | reset_session |
|
26 | 30 | flash.now[:notice] = saved_notice |
|
27 | 31 | |
|
28 | 32 | # EXPERIMENT: |
|
29 | 33 | # Hide login if in single user mode and the url does not |
|
30 | 34 | # explicitly specify /login |
|
31 | 35 | # |
@@ -305,26 +309,32 | |||
|
305 | 309 | seconds = nil |
|
306 | 310 | time_stat = "Time used: n/a sec." |
|
307 | 311 | end |
|
308 | 312 | |
|
309 | 313 | # extract memory usage |
|
310 | 314 | if res = /s(.*)m/.match(running_stat_line) |
|
311 | 315 | memory_used = res[1].to_i |
|
312 | 316 | else |
|
313 | 317 | memory_used = -1 |
|
314 | 318 | end |
|
315 | 319 | |
|
316 | 320 | return { |
|
317 | 321 | :msg => "#{run_stat}\n#{time_stat}", |
|
318 | 322 | :running_time => seconds, |
|
319 | 323 | :exit_status => run_stat, |
|
320 | 324 | :memory_usage => memory_used |
|
321 | 325 | } |
|
322 | 326 | end |
|
323 | 327 | |
|
324 | 328 | def update_user_start_time |
|
325 | 329 | user = User.find(session[:user_id]) |
|
326 | 330 | UserContestStat.update_user_start_time(user) |
|
327 | 331 | end |
|
328 | 332 | |
|
333 | + def reject_announcement_refresh_when_logged_out | |
|
334 | + if not session[:user_id] | |
|
335 | + render :text => 'Access forbidden', :status => 403 | |
|
336 | + end | |
|
337 | + end | |
|
338 | + | |
|
329 | 339 | end |
|
330 | 340 |
You need to be logged in to leave comments.
Login now