cafe-grader-web Commit - r623:0e5f52b4f443

cafe-grader-web

Commit `r623:0e5f52b4f443` public

parent | child

Description:

merge update to rail 4.2

Commit status:

[Not Reviewed]

References:

merge java

Diff options:

| | | |

Comments:

0 Commit comments 0 Inline Comments

Unresolved TODOs:

There are no unresolved TODOs

Add another comment

r623:0e5f52b4f443 - Mon, 02 Jan 2017 04:42:18 - 101 files changed: 467 inserted, 2013 deleted

app/views/submissions/compiler_msg.js.haml created 644 ¶ +3

@@ -0,0 +1,3
	1	+ :javascript
	2	+ $("#compiler_msg").html("#{j @submissionhcompiler_msg}")
	3	+

config/secrets.yml created 644 ¶ +8

@@ -0,0 +1,8
	1	+ development:
	2	+ secret_key_base: '444f426d08add8e2d7cbd76e2057e521e06091231eb4d5472af6ba5654ea1124ce6a636f549be6827ce09561c314181226ad840d44e4677e1077942ee0dc82bd'
	3	+
	4	+ test:
	5	+ secret_key_base: 'd52f411b06a79cc9f56d92e10d27e670cf0f0c3357e7caf9018ec23091b5c452ea9266c03a5c9e37b72c358702d4d460e957f90dcc553c9fc73a98adb520e781'
	6	+
	7	+ production:
	8	+ secret_key_base: '7f85485d3d652fc6336dfe3cd98917d9bd7a323b32096bf7635d26b98ccd0480816cc2d12b5c10805cecf7d8fb322104e2bda71eb60dd871c5c537e56a063038'

test/integration/login_test.rb created 644 ¶ +13

@@ -0,0 +1,13
	1	+ require 'test_helper'
	2	+
	3	+ class LoginTest < ActionDispatch::IntegrationTest
	4	+ # test "the truth" do
	5	+ # assert true
	6	+ # end
	7	+
	8	+ test "login with valid information" do
	9	+ get root_path
	10	+ assert_response :success
	11	+
	12	+ end
	13	+ end

Gemfile ¶ +9 -11

               source 'https://rubygems.org'
-            - gem 'rails', '~>3.2'
+            + gem 'rails', '~>4.2.0'
+            + gem 'activerecord-session_store'
               gem 'select2-rails'
               # Bundle edge Rails instead:
               # gem 'rails', :git => 'git://github.com/rails/rails.git'
               gem 'mysql2'
+            + gem 'sqlite3'
               # Gems used only for assets and not required
               # in production environments by default.
-            - group :assets do
+            + gem 'sass-rails'
-            -   gem 'sass-rails',   '~> 3.2.6'
+            + gem 'coffee-rails'
-            -   gem 'coffee-rails', '~> 3.2.2'
                 # See https://github.com/sstephenson/execjs#readme for more supported runtimes
                 # gem 'therubyracer', :platforms => :ruby
-            -   gem 'uglifier'
+            + gem 'uglifier'
-            - end
-            - gem 'prototype-rails'
+            + # gem 'prototype-rails'
               # To use ActiveModel has_secure_password
               # gem 'bcrypt-ruby', '~> 3.0.0'
               # To use Jbuilder templates for JSON
               # gem 'jbuilder'
               # Use unicorn as the app server
               # gem 'unicorn'
               # Deploy with Capistrano
               # gem 'capistrano'
               # To use debugger
               # gem 'debugger'
               #
               #in-place editor
               gem 'best_in_place', '~> 3.0.1'
               # jquery addition
               gem 'jquery-rails'
-            - gem 'jquery-ui-sass-rails'
+            + gem 'jquery-ui-rails'
               gem 'jquery-timepicker-addon-rails'
               gem 'jquery-tablesorter'
               gem 'jquery-countdown-rails'
               #syntax highlighter
               gem 'rouge'
               #add bootstrap
               gem 'bootstrap-sass', '~> 3.2.0'
               gem 'bootstrap-switch-rails'
               gem 'bootstrap-toggle-rails'
               gem 'autoprefixer-rails'
               gem 'ace-rails-ap'
               gem 'haml'
               gem 'haml-rails'
               gem 'mail'
               gem 'rdiscount'
               gem 'test-unit'
               gem 'will_paginate', '~> 3.0.7'
               gem 'dynamic_form'
               gem 'in_place_editing'
               gem 'verification', :git => 'https://github.com/sikachu/verification.git'
-            - group :test, :development do
-            -   gem 'rspec-rails', '~> 2.99.0'
-            - end

Gemfile.lock ¶ +152 -139

@@ -1,208 +1,221
1	GIT	1	GIT
2	remote: https://github.com/sikachu/verification.git	2	remote: https://github.com/sikachu/verification.git
3	- revision: 76eaf51b13276ecae54bd9cd115832595d2ff56d	3	+ revision: ff31697b940d7b0e2ec65f08764215c96104e76d
4	specs:	4	specs:
5	verification (1.0.3)	5	verification (1.0.3)
6	- actionpack (>= 3.0.0, < 5.0)	6	+ actionpack (>= 3.0.0, < 5.1)
7	- activesupport (>= 3.0.0, < 5.0)	7	+ activesupport (>= 3.0.0, < 5.1)
8		8
9	GEM	9	GEM
10	remote: https://rubygems.org/	10	remote: https://rubygems.org/
11	specs:	11	specs:
12	- ace-rails-ap (4.~~0.2~~)	12	+ ace-rails-ap (4.1.1)
13	- actionmailer (~~3.2.22.5~~)	13	+ actionmailer (4.2.7.1)
14	- actionpack (= ~~3.2.22.5~~)	14	+ actionpack (= 4.2.7.1)
15	- ~~mail (~> 2.5.4~~)	15	+ actionview (= 4.2.7.1)
16	- ~~actionpack (3.2.22.5~~)	16	+ activejob (= 4.2.7.1)
17	- activemodel (= 3.2.22.5)	17	+ mail (~> 2.5, >= 2.5.4)
18	- activesupport (= 3.2.22.5)	18	+ rails-dom-testing (~> 1.0, >= 1.0.5)
19	- builder (~> 3.0.0)	19	+ actionpack (4.2.7.1)
		20	+ actionview (= 4.2.7.1)
		21	+ activesupport (= 4.2.7.1)
		22	+ rack (~> 1.6)
		23	+ rack-test (~> 0.6.2)
		24	+ rails-dom-testing (~> 1.0, >= 1.0.5)
		25	+ rails-html-sanitizer (~> 1.0, >= 1.0.2)
		26	+ actionview (4.2.7.1)
		27	+ activesupport (= 4.2.7.1)
		28	+ builder (~> 3.1)
20	erubis (~> 2.7.0)	29	erubis (~> 2.7.0)
21	- journey (~> 1.0.4)	30	+ rails-dom-testing (~> 1.0, >= 1.0.5)
22	- rack (~> 1.4.5)	31	+ rails-html-sanitizer (~> 1.0, >= 1.0.2)
23	- rack-cache (~> 1.2)	32	+ activejob (4.2.7.1)
24	- ~~rack-test (~> 0.6~~.1)	33	+ activesupport (= 4.2.7.1)
25	- sprockets (~> 2.2.1)	34	+ globalid (>= 0.3.0)
26	- activemodel (~~3.2.22.5~~)	35	+ activemodel (4.2.7.1)
27	- activesupport (= ~~3.2.22.5~~)	36	+ activesupport (= 4.2.7.1)
28	- builder (~> 3.~~0.0~~)	37	+ builder (~> 3.1)
29	- activerecord (~~3.2.22.5~~)	38	+ activerecord (4.2.7.1)
30	- activemodel (= ~~3.2.22.5~~)	39	+ activemodel (= 4.2.7.1)
31	- activesupport (= ~~3.2.22.5~~)	40	+ activesupport (= 4.2.7.1)
32	- arel (~> ~~3.0.2~~)	41	+ arel (~> 6.0)
33	- tzinfo (~> 0.3.29)	42	+ activerecord-session_store (1.0.0)
34	- activeresource (3.2.22.5)	43	+ actionpack (>= 4.0, < 5.1)
35	- active~~model (= 3.2.22.5~~)	44	+ activerecord (>= 4.0, < 5.1)
36	- activesupport (= 3.2.22.5)	45	+ multi_json (~> 1.11, >= 1.11.2)
37	- activesupport (3.2.22.5)	46	+ rack (>= 1.5.2, < 3)
38	- i18n (~> 0.6, >= 0.6.4)	47	+ railties (>= 4.0, < 5.1)
39	- multi_json (~> 1.0)	48	+ activesupport (4.2.7.1)
40	- arel (3.0.3)	49	+ i18n (~> 0.7)
41	- autoprefixer-rails (6.0.3)	50	+ json (~> 1.7, >= 1.7.7)
		51	+ minitest (~> 5.1)
		52	+ thread_safe (~> 0.3, >= 0.3.4)
		53	+ tzinfo (~> 1.1)
		54	+ arel (6.0.4)
		55	+ autoprefixer-rails (6.6.0)
42	execjs	56	execjs
43	- json
44	best_in_place (3.0.3)	57	best_in_place (3.0.3)
45	actionpack (>= 3.2)	58	actionpack (>= 3.2)
46	railties (>= 3.2)	59	railties (>= 3.2)
47	bootstrap-sass (3.2.0.2)	60	bootstrap-sass (3.2.0.2)
48	sass (~> 3.2)	61	sass (~> 3.2)
49	bootstrap-switch-rails (3.3.3)	62	bootstrap-switch-rails (3.3.3)
50	bootstrap-toggle-rails (2.2.1.0)	63	bootstrap-toggle-rails (2.2.1.0)
51	- builder (3.~~0.4~~)	64	+ builder (3.2.2)
52	- coffee-rails (~~3.2.2~~)	65	+ coffee-rails (4.2.1)
53	coffee-script (>= 2.2.0)	66	coffee-script (>= 2.2.0)
54	- railties (~~~> 3.2.0~~)	67	+ railties (>= 4.0.0, < 5.2.x)
55	- coffee-script (2.~~3.0~~)	68	+ coffee-script (2.4.1)
56	coffee-script-source	69	coffee-script-source
57	execjs	70	execjs
58	- coffee-script-source (1.~~9.0~~)	71	+ coffee-script-source (1.12.2)
59	- diff-lcs (1.2.5)	72	+ concurrent-ruby (1.0.4)
60	dynamic_form (1.1.4)	73	dynamic_form (1.1.4)
61	erubis (2.7.0)	74	erubis (2.7.0)
62	- execjs (2.3.0)	75	+ execjs (2.7.0)
63	- ~~haml (4.0.6~~)	76	+ globalid (0.3.7)
		77	+ activesupport (>= 4.1.0)
		78	+ haml (4.0.7)
64	tilt	79	tilt
65	- haml-rails (0.4)	80	+ haml-rails (0.9.0)
66	- actionpack (>= ~~3.1, < 4~~.1)	81	+ actionpack (>= 4.0.1)
67	- activesupport (>= ~~3.1, < 4~~.1)	82	+ activesupport (>= 4.0.1)
68	- haml (>= ~~3.1, < 4.1~~)	83	+ haml (>= 4.0.6, < 5.0)
69	- ~~railties (>= 3.1, < 4~~.1)	84	+ html2haml (>= 1.0.1)
70	- hike (1.2.3)	85	+ railties (>= 4.0.1)
		86	+ html2haml (2.0.0)
		87	+ erubis (~> 2.7.0)
		88	+ haml (~> 4.0.0)
		89	+ nokogiri (~> 1.6.0)
		90	+ ruby_parser (~> 3.5)
71	i18n (0.7.0)	91	i18n (0.7.0)
72	in_place_editing (1.2.0)	92	in_place_editing (1.2.0)
73	- journey (1.0.4)
74	jquery-countdown-rails (2.0.2)	93	jquery-countdown-rails (2.0.2)
75	- jquery-rails (~~3.1.2~~)	94	+ jquery-rails (4.2.1)
76	- rail~~ties (>= 3.0, < 5.0~~)	95	+ rails-dom-testing (>= 1, < 3)
		96	+ railties (>= 4.2.0)
77	thor (>= 0.14, < 2.0)	97	thor (>= 0.14, < 2.0)
78	- jquery-tablesorter (1.~~13.4~~)	98	+ jquery-tablesorter (1.23.3)
79	- railties (>= 3.~~1, < 5~~)	99	+ railties (>= 3.2, < 6)
80	jquery-timepicker-addon-rails (1.4.1)	100	jquery-timepicker-addon-rails (1.4.1)
81	railties (>= 3.1)	101	railties (>= 3.1)
82	- jquery-ui-rails (~~4.0.3~~)	102	+ jquery-ui-rails (6.0.1)
83	- jquery-rails	103	+ railties (>= 3.2.16)
84	- railties (>= 3.1.0)
85	- jquery-ui-sass-rails (4.0.3.0)
86	- jquery-rails
87	- jquery-ui-rails (= 4.0.3)
88	- railties (>= 3.1.0)
89	json (1.8.3)	104	json (1.8.3)
90	- ~~mail (2.5.4~~)	105	+ loofah (2.0.3)
91	- mime-types (~> 1.16)	106	+ nokogiri (>= 1.5.9)
92	- treetop (~> 1.4.8)	107	+ mail (2.6.4)
93	- mime-types (1.~~25.~~1)	108	+ mime-types (>= 1.16, < 4)
94	- momentjs-rails (2.11.1)	109	+ mime-types (3.1)
		110	+ mime-types-data (~> 3.2015)
		111	+ mime-types-data (3.2016.0521)
		112	+ mini_portile2 (2.1.0)
		113	+ minitest (5.10.1)
		114	+ momentjs-rails (2.15.1)
95	railties (>= 3.1)	115	railties (>= 3.1)
96	multi_json (1.12.1)	116	multi_json (1.12.1)
97	- mysql2 (0.~~3.20~~)	117	+ mysql2 (0.4.5)
98	- polyglot (0.3.5)	118	+ nokogiri (1.6.8.1)
99	- power_assert (0.2.2)	119	+ mini_portile2 (~> 2.1.0)
100	- prototype-rails (3.2.1)	120	+ power_assert (0.4.1)
101	- rails (~> 3.2)	121	+ rack (1.6.5)
102	- rack (1.4.7)
103	- rack-cache (1.6.1)
104	- rack (>= 0.4)
105	- rack-ssl (1.3.4)
106	- rack
107	rack-test (0.6.3)	122	rack-test (0.6.3)
108	rack (>= 1.0)	123	rack (>= 1.0)
109	- rails (~~3.2.22.5~~)	124	+ rails (4.2.7.1)
110	- actionmailer (= ~~3.2.22.5~~)	125	+ actionmailer (= 4.2.7.1)
111	- actionpack (= ~~3.2.22.5~~)	126	+ actionpack (= 4.2.7.1)
112	- acti~~verecord (= 3.2.22.5~~)	127	+ actionview (= 4.2.7.1)
113	- active~~resource (= 3.2.22.5~~)	128	+ activejob (= 4.2.7.1)
114	- active~~support (= 3.2.22.5~~)	129	+ activemodel (= 4.2.7.1)
115	- bundler (~> 1.0)	130	+ activerecord (= 4.2.7.1)
116	- ~~railties (= 3.2.22.5~~)	131	+ activesupport (= 4.2.7.1)
117	- rails_bootstrap_sortable (2.0.0)	132	+ bundler (>= 1.3.0, < 2.0)
118	- ~~momentjs-rails (~> 2, >= 2.8.3~~)	133	+ railties (= 4.2.7.1)
119	- railties (3.2.22.5)	134	+ sprockets-rails
120	- actionpack (= 3.2.22.5)	135	+ rails-deprecated_sanitizer (1.0.3)
121	- activesupport (~~= 3.2.22.5~~)	136	+ activesupport (>= 4.2.0.alpha)
122	- rack-ssl (~> 1.3.2)	137	+ rails-dom-testing (1.0.8)
		138	+ activesupport (>= 4.2.0.beta, < 5.0)
		139	+ nokogiri (~> 1.6)
		140	+ rails-deprecated_sanitizer (>= 1.0.1)
		141	+ rails-html-sanitizer (1.0.3)
		142	+ loofah (~> 2.0)
		143	+ rails_bootstrap_sortable (2.0.1)
		144	+ momentjs-rails (>= 2.8.3)
		145	+ railties (4.2.7.1)
		146	+ actionpack (= 4.2.7.1)
		147	+ activesupport (= 4.2.7.1)
123	rake (>= 0.8.7)	148	rake (>= 0.8.7)
124	- rdoc (~> 3.4)	149	+ thor (>= 0.18.1, < 2.0)
125	- thor (>= 0.14.6, < 2.0)	150	+ rake (12.0.0)
126	- rake (11.2.2)	151	+ rdiscount (2.2.0.1)
127	- r~~discount (2.1.8~~)	152	+ rouge (2.0.7)
128	- rdoc (3.12.2)	153	+ ruby_parser (3.8.3)
129	- ~~json (~> 1.4~~)	154	+ sexp_processor (~> 4.1)
130	- rouge (1.8.0)	155	+ sass (3.4.23)
131	- rspec-collection_matchers (1.1.2)	156	+ sass-rails (5.0.6)
132	- rspec-expectations (>= 2.99.0.beta1)	157	+ railties (>= 4.0.0, < 6)
133	- rspec-core (2.99.2)	158	+ sass (~> 3.1)
134	- rspec-expectations (2.99.2)	159	+ sprockets (>= 2.8, < 4.0)
135	- ~~diff-lcs (>= 1.1.3, < 2~~.0)	160	+ sprockets-rails (>= 2.0, < 4.0)
136	- rspec-mocks (2.99.3)	161	+ tilt (>= 1.1, < 3)
137	- ~~rspec-rails (2.99.0~~)	162	+ select2-rails (4.0.3)
138	- actionpack (>= 3.0)
139	- activemodel (>= 3.0)
140	- activesupport (>= 3.0)
141	- railties (>= 3.0)
142	- rspec-collection_matchers
143	- rspec-core (~> 2.99.0)
144	- rspec-expectations (~> 2.99.0)
145	- rspec-mocks (~> 2.99.0)
146	- sass (3.4.11)
147	- sass-rails (3.2.6)
148	- railties (~> 3.2.0)
149	- sass (>= 3.1.10)
150	- tilt (~> 1.3)
151	- select2-rails (4.0.1)
152	thor (~> 0.14)	163	thor (~> 0.14)
153	- s~~prockets (2.2.3~~)	164	+ sexp_processor (4.7.0)
154	- hike (~> 1.2)	165	+ sprockets (3.7.1)
155	- ~~multi_json~~ (~> 1.0)	166	+ concurrent-ruby (~> 1.0)
156	- rack (~~~> 1.0~~)	167	+ rack (> 1, < 3)
157	- tilt (~> 1.1, != 1.3.0)	168	+ sprockets-rails (3.2.0)
158	- test-unit (3.0.9)	169	+ actionpack (>= 4.0)
		170	+ activesupport (>= 4.0)
		171	+ sprockets (>= 3.0.0)
		172	+ sqlite3 (1.3.12)
		173	+ test-unit (3.2.3)
159	power_assert	174	power_assert
160	- thor (0.19.1)	175	+ thor (0.19.4)
161	- tilt (1.4.1)	176	+ thread_safe (0.3.5)
162	- t~~reetop (1.4.1~~5)	177	+ tilt (2.0.5)
163	- polyglot	178	+ tzinfo (1.2.2)
164	- polyglot (>= 0.3.1)	179	+ thread_safe (~> 0.1)
165	- tzinfo (0.3.51)	180	+ uglifier (3.0.4)
166	- uglifier (2.7.0)	181	+ execjs (>= 0.3.0, < 3)
167	- execjs (>= 0.3.0)	182	+ will_paginate (3.0.12)
168	- json (>= 1.8.0)
169	- will_paginate (3.0.7)
170		183
171	PLATFORMS	184	PLATFORMS
172	ruby	185	ruby
173		186
174	DEPENDENCIES	187	DEPENDENCIES
175	ace-rails-ap	188	ace-rails-ap
		189	+ activerecord-session_store
176	autoprefixer-rails	190	autoprefixer-rails
177	best_in_place (~> 3.0.1)	191	best_in_place (~> 3.0.1)
178	bootstrap-sass (~> 3.2.0)	192	bootstrap-sass (~> 3.2.0)
179	bootstrap-switch-rails	193	bootstrap-switch-rails
180	bootstrap-toggle-rails	194	bootstrap-toggle-rails
181	- coffee-rails ~~(~> 3.2.2)~~	195	+ coffee-rails
182	dynamic_form	196	dynamic_form
183	haml	197	haml
184	haml-rails	198	haml-rails
185	in_place_editing	199	in_place_editing
186	jquery-countdown-rails	200	jquery-countdown-rails
187	jquery-rails	201	jquery-rails
188	jquery-tablesorter	202	jquery-tablesorter
189	jquery-timepicker-addon-rails	203	jquery-timepicker-addon-rails
190	- jquery-ui-~~sass-~~rails	204	+ jquery-ui-rails
191	mail	205	mail
192	momentjs-rails	206	momentjs-rails
193	mysql2	207	mysql2
194	- prototype-rails	208	+ rails (~> 4.2.0)
195	- rails (~> 3.2)
196	rails_bootstrap_sortable	209	rails_bootstrap_sortable
197	rdiscount	210	rdiscount
198	rouge	211	rouge
199	- rspec-rails (~> 2.99.0)	212	+ sass-rails
200	- sass-rails (~> 3.2.6)
201	select2-rails	213	select2-rails
		214	+ sqlite3
202	test-unit	215	test-unit
203	uglifier	216	uglifier
204	verification!	217	verification!
205	will_paginate (~> 3.0.7)	218	will_paginate (~> 3.0.7)
206		219
207	BUNDLED WITH	220	BUNDLED WITH
208	- 1.1~~2.5~~	221	+ 1.13.6

app/assets/javascripts/application.js ¶ +1 -4

               //
               // Any JavaScript/Coffee file within this directory, lib/assets/javascripts, vendor/assets/javascripts,
               // or vendor/assets/javascripts of plugins, if any, can be referenced here using a relative path.
               //
               // It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the
               // the compiled file.
               //
               // WARNING: THE FIRST BLANK LINE MARKS THE END OF WHAT'S TO BE PROCESSED, ANY BLANK LINE SHOULD
               // GO AFTER THE REQUIRES BELOW.
               //
               //= require jquery
               //= require jquery_ujs
-            - //= require jquery.ui.all
+            + //= require jquery-ui
               //= require bootstrap-sprockets
               //= require moment
               //= require bootstrap-sortable
               //= require select2
               //= require ace-rails-ap
               //= require ace/mode-c_cpp
               //= require ace/mode-python
               //= require ace/mode-ruby
               //= require ace/mode-pascal
               //= require ace/mode-javascript
               //= require ace/mode-java
               //= require ace/theme-merbivore
               //= require custom
               //= require jquery.countdown
               //-------------- addition from local_jquery -----------
-            - //= require jquery.ui.datepicker
-            - //= require jquery.ui.slider
-            - //= require jquery-ui-timepicker-addon
               //= require jquery-tablesorter
               //= require best_in_place
               //= require best_in_place.jquery-ui
               //= require brython
               // since this is after blank line, it is not downloaded
               //x= require prototype
               //x= require prototype_ujs
               //x= require effects
               //x= require dragdrop
               //x= require controls

app/assets/javascripts/local_jquery.js ¶ -10

@@ -1,14 +1,4
1	- //= require jquery
2	- //= require jquery_ujs
3	- //= require jquery.ui.all
4	- //= require jquery.ui.datepicker
5	- //= require jquery.ui.slider
6	- //= require jquery-ui-timepicker-addon
7	- //= require jquery-tablesorter
8	- //= require best_in_place
9	- //= require best_in_place.jquery-ui
10	-
11	$(document).ready(function() {	1	$(document).ready(function() {
12	/* Activating Best In Place */	2	/* Activating Best In Place */
13	jQuery(".best_in_place").best_in_place();	3	jQuery(".best_in_place").best_in_place();
14	});	4	});

app/assets/stylesheets/application.css.scss ¶ +5 -5

                * or any plugin's vendor/assets/stylesheets directory can be referenced here using a relative path.
                *
                * You're free to add application-wide styles to this file and they'll appear at the bottom of the
                * compiled file so the styles you add here take precedence over styles defined in any styles
                * defined in the other CSS/SCSS files in this directory. It is generally better to create a new
                * file per style scope.
                *
                * // bootstrap says that we should not do this, but @import each file instead
                * #   *= require_tree .
                * #   *= require_self
                */
-            - @import "jquery.ui.all";
+            + @import "jquery-ui";
-            - @import "jquery.ui.core";
+            + //@import "jquery.ui.core";
-            - @import "jquery.ui.theme";
+            + //@import "jquery.ui.theme";
-            - @import "jquery.ui.datepicker";
+            + //@import "jquery.ui.datepicker";
-            - @import "jquery.ui.slider";
+            + //@import "jquery.ui.slider";
               @import "jquery-ui-timepicker-addon";
               @import "jquery-tablesorter/theme.metro-dark";
               @import "jquery.countdown";
               @import "tablesorter-theme.cafe";
               //bootstrap
               @import "bootstrap-sprockets";
               @import "bootstrap";
               @import "select2";
               @import "select2-bootstrap";
               //@import bootstrap3-switch

app/controllers/announcements_controller.rb ¶ +8 -3

               class AnnouncementsController < ApplicationController
                 before_filter :admin_authorization
                 in_place_edit_for :announcement, :published
                 # GET /announcements
                 # GET /announcements.xml
                 def index
-            -     @announcements = Announcement.find(:all,
+            +     @announcements = Announcement.order(created_at: :desc)
-            -                                        :order => "created_at DESC")
                   respond_to do |format|
                     format.html # index.html.erb
                     format.xml  { render :xml => @announcements }
                   end
                 end
                 # GET /announcements/1
                 # GET /announcements/1.xml
                 def show
                   @announcement = Announcement.find(params[:id])
                       format.html { render :action => "new" }
                       format.xml  { render :xml => @announcement.errors, :status => :unprocessable_entity }
                     end
                   end
                 end
                 # PUT /announcements/1
                 # PUT /announcements/1.xml
                 def update
                   @announcement = Announcement.find(params[:id])
                   respond_to do |format|
-            -       if @announcement.update_attributes(params[:announcement])
+            +       if @announcement.update_attributes(announcement_params)
                       flash[:notice] = 'Announcement was successfully updated.'
                       format.html { redirect_to(@announcement) }
                       format.js   {}
                       format.xml  { head :ok }
                     else
                       format.html { render :action => "edit" }
                       format.js   {}
                       format.xml  { render :xml => @announcement.errors, :status => :unprocessable_entity }
                     end
                   end
                 end
                 # DELETE /announcements/1
                 # DELETE /announcements/1.xml
                 def destroy
                   @announcement = Announcement.find(params[:id])
                   @announcement.destroy
                   respond_to do |format|
                     format.html { redirect_to(announcements_url) }
                     format.xml  { head :ok }
                   end
                 end
+            +
+            +   private
+            +
+            +     def announcement_params
+            +       params.require(:announcement).permit(:author, :body, :published, :frontpage, :contest_only,:title, :note)
+            +     end
               end

app/controllers/application_controller.rb ¶ +1 -1

                   flash[:notice] = 'You are not authorized to view the page you requested'
                   redirect_to :controller => 'main', :action => 'login'
                 end
                 # Returns the current logged-in user (if any).
                 def current_user
                   return nil unless session[:user_id]
                   @current_user ||= User.find(session[:user_id])
                 end
                 def admin_authorization
                   return false unless authenticate
-            -     user = User.find(session[:user_id], :include => ['roles'])
+            +     user = User.includes(:roles).find(session[:user_id])
                   unless user.admin?
                     unauthorized_redirect
                     return false
                   end
                   return true
                 end
                 def authorization_by_roles(allowed_roles)
                   return false unless authenticate
                   user = User.find(session[:user_id])
                   unless user.roles.detect { |role| allowed_roles.member?(role.name) }
                     unauthorized_redirect

app/controllers/configurations_controller.rb ¶ +7 -3

               class ConfigurationsController < ApplicationController
                 before_filter :authenticate
                 before_filter { |controller| controller.authorization_by_roles(['admin'])}
                 def index
-            -     @configurations = GraderConfiguration.find(:all,
+            +     @configurations = GraderConfiguration.order(:key)
-            -                                          :order => '`key`')
                   @group = GraderConfiguration.pluck("grader_configurations.key").map{ |x| x[0...(x.index('.'))] }.uniq.sort
                 end
                 def reload
                   GraderConfiguration.reload
                   redirect_to :action => 'index'
                 end
                 def update
                   @config = GraderConfiguration.find(params[:id])
                   User.clear_last_login if @config.key == GraderConfiguration::MULTIPLE_IP_LOGIN_KEY and @config.value == 'true' and params[:grader_configuration][:value] == 'false'
                   respond_to do |format|
-            -       if @config.update_attributes(params[:grader_configuration])
+            +       if @config.update_attributes(configuration_params)
                       format.json { head :ok }
                     else
                       format.json { respond_with_bip(@config) }
                     end
                   end
                 end
+            + private
+            +   def configuration_params
+            +     params.require(:grader_configuration).permit(:key,:value_type,:value,:description)
+            +   end
+            +
               end

app/controllers/contest_management_controller.rb ¶ +2 -2

                 before_filter :admin_authorization
                 def index
                   @num_contests = Contest.count()
                 end
                 def user_stat
                   if not GraderConfiguration.indv_contest_mode?
                     redirect_to :action => 'index' and return
                   end
-            -     @users = User.find(:all)
+            +     @users = User.all
                   @start_times = {}
-            -     UserContestStat.find(:all).each do |stat|
+            +     UserContestStat.all.each do |stat|
                     @start_times[stat.user_id] = stat.started_at
                   end
                 end
                 def clear_stat
                   user = User.find(params[:id])
                   if user.contest_stat!=nil
                     user.contest_stat.destroy
                   end
                   redirect_to :action => 'user_stat'
                 end

app/controllers/contests_controller.rb ¶ +7 -1

                       format.html { render :action => "new" }
                       format.xml  { render :xml => @contest.errors, :status => :unprocessable_entity }
                     end
                   end
                 end
                 # PUT /contests/1
                 # PUT /contests/1.xml
                 def update
                   @contest = Contest.find(params[:id])
                   respond_to do |format|
-            -       if @contest.update_attributes(params[:contest])
+            +       if @contest.update_attributes(contests_params)
                       flash[:notice] = 'Contest was successfully updated.'
                       format.html { redirect_to(@contest) }
                       format.xml  { head :ok }
                     else
                       format.html { render :action => "edit" }
                       format.xml  { render :xml => @contest.errors, :status => :unprocessable_entity }
                     end
                   end
                 end
                 # DELETE /contests/1
                 # DELETE /contests/1.xml
                 def destroy
                   @contest = Contest.find(params[:id])
                   @contest.destroy
                   respond_to do |format|
                     format.html { redirect_to(contests_url) }
                     format.xml  { head :ok }
                   end
                 end
+            +   private
+            +
+            +     def contests_params
+            +       params.require(:contest).permit(:title,:enabled,:name)
+            +     end
+            +
               end

app/controllers/graders_controller.rb ¶ +3 -5

                        :redirect_to => {:action => 'index'}
                 def index
                   redirect_to :action => 'list'
                 end
                 def list
                   @grader_processes = GraderProcess.find_running_graders
                   @stalled_processes = GraderProcess.find_stalled_process
                   @terminated_processes = GraderProcess.find_terminated_graders
-            -     @last_task = Task.find(:first,
+            +     @last_task = Task.last
-            -                            :order => 'created_at DESC')
+            +     @last_test_request = TestRequest.last
-            -     @last_test_request = TestRequest.find(:first,
-            -                                           :order => 'created_at DESC')
                   @submission = Submission.order("id desc").limit(20)
                   @backlog_submission = Submission.where('graded_at is null')
                 end
                 def clear
                   grader_proc = GraderProcess.find(params[:id])
                   grader_proc.destroy if grader_proc!=nil
                   redirect_to :action => 'list'
                 end
                 def clear_terminated
                   GraderProcess.find_terminated_graders.each do |p|
                     p.destroy
                   end
                   redirect_to :action => 'list'
                 end
                 def clear_all
-            -     GraderProcess.find(:all).each do |p|
+            +     GraderProcess.all.each do |p|
                     p.destroy
                   end
                   redirect_to :action => 'list'
                 end
                 def view
                   if params[:type]=='Task'
                     redirect_to :action => 'task', :id => params[:id]
                   else
                     redirect_to :action => 'test_request', :id => params[:id]
                   end
                 end

app/controllers/main_controller.rb ¶ +3 -3

                   flash.now[:notice] = saved_notice
                   # EXPERIMENT:
                   # Hide login if in single user mode and the url does not
                   # explicitly specify /login
                   #
                   # logger.info "PATH: #{request.path}"
                   # if GraderConfiguration['system.single_user_mode'] and
                   #     request.path!='/main/login'
                   #   @hidelogin = true
                   # end
-            -     @announcements = Announcement.find_for_frontpage
+            +     @announcements = Announcement.frontpage
                   render :action => 'login', :layout => 'empty'
                 end
                 def list
                   prepare_list_information
                 end
                 def help
                   @user = User.find(session[:user_id])
                 end
                 def submit
                     user.update_start_time
                     redirect_to :action => 'list'
                   else
                     @contests = user.contests
                     @user = user
                   end
                 end
                 protected
                 def prepare_announcements(recent=nil)
                   if GraderConfiguration.show_tasks_to?(@user)
-            -       @announcements = Announcement.find_published(true)
+            +       @announcements = Announcement.published(true)
                   else
-            -       @announcements = Announcement.find_published
+            +       @announcements = Announcement.published
                   end
                   if recent!=nil
                     recent_id = recent.to_i
                     @announcements = @announcements.find_all { |a| a.id > recent_id }
                   end
                 end
                 def prepare_list_information
                   @user = User.find(session[:user_id])
                   if not GraderConfiguration.multicontests?
                     @problems = @user.available_problems
                   else

app/controllers/problems_controller.rb ¶ +4 -6

               class ProblemsController < ApplicationController
                 before_filter :authenticate, :authorization
                 in_place_edit_for :problem, :name
                 in_place_edit_for :problem, :full_name
                 in_place_edit_for :problem, :full_score
                 def index
-            -     @problems = Problem.find(:all, :order => 'date_added DESC')
+            +     @problems = Problem.order(date_added: :desc)
                 end
                 # GETs should be safe (see http://www.w3.org/2001/tag/doc/whenToUseGet.html)
                 verify :method => :post, :only => [ :create, :quick_create,
                                                     :do_manage,
                                                     :do_import,
                                                   ],
                        :redirect_to => { :action => :index }
                 def show
                   @problem = Problem.find(params[:id])
                 end
                   end
                 end
                 def toggle_test
                   @problem = Problem.find(params[:id])
                   @problem.update_attributes(test_allowed: !(@problem.test_allowed?) )
                   respond_to do |format|
                     format.js { }
                   end
                 end
                 def turn_all_off
-            -     Problem.find(:all,
+            +     Problem.available.all.each do |problem|
-            -                  :conditions => "available = 1").each do |problem|
                     problem.available = false
                     problem.save
                   end
                   redirect_to action: :index
                 end
                 def turn_all_on
-            -     Problem.find(:all,
+            +     Problem.where.not(available: true).each do |problem|
-            -                  :conditions => "available = 0").each do |problem|
                     problem.available = true
                     problem.save
                   end
                   redirect_to action: :index
                 end
                 def stat
                   @problem = Problem.find(params[:id])
                   unless @problem.available or session[:admin]
                     redirect_to :controller => 'main', :action => 'list'
                     return
                   end
                   @submissions.find_each do |sub|
                     d = (DateTime.now.in_time_zone - sub.submitted_at) / 24 / 60 / 60
                     @histogram[:data][d.to_i] += 1 if d < range
                     user[sub.user_id] = [user[sub.user_id], ((sub.try(:points) || 0) >= @problem.full_score) ? 1 : 0].max
                   end
                   @histogram[:summary][:max] = [@histogram[:data].max,1].max
                   @summary = { attempt: user.count, solve: 0 }
                   user.each_value { |v| @summary[:solve] += 1 if v == 1 }
                 end
                 def manage
-            -     @problems = Problem.find(:all, :order => 'date_added DESC')
+            +     @problems = Problem.order(date_added: :desc)
                 end
                 def do_manage
                   if params.has_key? 'change_date_added'
                     change_date_added
                   elsif params.has_key? 'add_to_contest'
                     add_to_contest
                   elsif params.has_key? 'enable_problem'
                     set_available(true)
                   elsif params.has_key? 'disable_problem'
                     set_available(false)
                   end

app/controllers/report_controller.rb ¶ +5 -9

               require 'csv'
               class ReportController < ApplicationController
                 before_filter :authenticate
                 before_filter :admin_authorization, only: [:login_stat,:submission_stat, :stuck, :cheat_report, :cheat_scruntinize, :show_max_score]
                 before_filter(only: [:problem_hof]) { |c|
                   return false unless authenticate
-            -     if GraderConfiguration["right.user_view_submission"]
+            +     admin_authorization unless GraderConfiguration["right.user_view_submission"]
-            -       return true;
-            -     end
-            -     admin_authorization
                 }
                 def max_score
                 end
                 def current_score
-            -     @problems = Problem.find_available_problems
+            +     @problems = Problem.available_problems
                   @users = User.includes(:contests).includes(:contest_stat).where(enabled: true)
                   @scorearray = calculate_max_score(@problems, @users,0,0,true)
                   #rencer accordingly
                   if params[:button] == 'download' then
                     csv = gen_csv_from_scorearray(@scorearray,@problems)
                     send_data csv, filename: 'max_score.csv'
                   else
                     #render template: 'user_admin/user_stat'
                     render 'current_score'
                   end
                 end
                 def show_max_score
                   #process parameters
                   #problems
                   @problems = []
                   params[:problem_id].each do |id|
                     next unless id.strip != ""
                     pid = Problem.find_by_id(id.to_i)
                     @problems << pid if pid
                   end
                   #users
                   @users = if params[:user] == "all" then
-            -                User.find(:all, :include => [:contests, :contest_stat])
+            +                User.includes(:contests).includes(:contest_stat)
                            else
                              User.includes(:contests).includes(:contest_stat).where(enabled: true)
                            end
                   #set up range from param
                   since_id = params.fetch(:from_id, 0).to_i
                   until_id = params.fetch(:to_id, 0).to_i
                   #calculate the routine
                   @scorearray = calculate_max_score(@problems, @users,since_id,until_id)
                   #rencer accordingly
                     send_data csv, filename: 'max_score.csv'
                   else
                     #render template: 'user_admin/user_stat'
                     render 'max_score'
                   end
                 end
                 def score
                   if params[:commit] == 'download csv'
                     @problems = Problem.all
                   else
-            -       @problems = Problem.find_available_problems
+            +       @problems = Problem.available_problems
                   end
-            -     @users = User.includes(:contests, :contest_stat).where(enabled: true) #find(:all, :include => [:contests, :contest_stat]).where(enabled: true)
+            +     @users = User.includes(:contests, :contest_stat).where(enabled: true)
                   @scorearray = Array.new
                   @users.each do |u|
                     ustat = Array.new
                     ustat[0] = u
                     @problems.each do |p|
                       sub = Submission.find_last_by_user_and_problem(u.id,p.id)
                       if (sub!=nil) and (sub.points!=nil) and p and p.full_score
                         ustat << [(sub.points.to_f*100/p.full_score).round, (sub.points>=p.full_score)]
                       else
                         ustat << [0,false]
                       end
                     end

app/controllers/site_controller.rb ¶ +6 -1

               class SiteController < ApplicationController
                 before_filter :site_admin_authorization, :except => 'login'
                 def login
                   # Site administrator login
-            -     @countries = Country.find(:all, :include => :sites)
+            +     @countries = Country.includes(:sites).all
                   @country_select = @countries.collect { |c| [c.name, c.id] }
                   @country_select_with_all = [['Any',0]]
                   @countries.each do |country|
                     @country_select_with_all << [country.name, country.id]
                   end
                   @site_select = []
                   @countries.each do |country|
                     country.sites.each do |site|
                       @site_select << ["#{site.name}, #{country.name}", site.id]
                     end
                     redirect_to :controller => 'site', :action => 'login' and return
                   end
                   begin
                     @site = Site.find(session[:site_id], :include => :country)
                   rescue ActiveRecord::RecordNotFound
                     @site = nil
                   end
                   if @site==nil
                     redirect_to :controller => 'site', :action => 'login' and return
                   end
                 end
+            +   private
+            +     def site_params
+            +       params.require(:site).permit()
+            +     end
+            +
               end

app/controllers/sites_controller.rb ¶ +8 -2

               class SitesController < ApplicationController
                 before_filter :admin_authorization
                 # GET /sites
                 # GET /sites.xml
                 def index
-            -     @sites = Site.find(:all, :order => 'country_id')
+            +     @sites = Site.order(:country_id)
                   respond_to do |format|
                     format.html # index.html.erb
                     format.xml  { render :xml => @sites }
                   end
                 end
                 # GET /sites/1
                 # GET /sites/1.xml
                 def show
                   @site = Site.find(params[:id])
                       format.xml  { render :xml => @site.errors, :status => :unprocessable_entity }
                     end
                   end
                 end
                 # PUT /sites/1
                 # PUT /sites/1.xml
                 def update
                   @site = Site.find(params[:id])
                   @site.clear_start_time_if_not_started
                   respond_to do |format|
-            -       if @site.update_attributes(params[:site])
+            +       if @site.update_attributes(site_params)
                       flash[:notice] = 'Site was successfully updated.'
                       format.html { redirect_to(@site) }
                       format.xml  { head :ok }
                     else
                       format.html { render :action => "edit" }
                       format.xml  { render :xml => @site.errors, :status => :unprocessable_entity }
                     end
                   end
                 end
                 # DELETE /sites/1
                 # DELETE /sites/1.xml
                 def destroy
                   @site = Site.find(params[:id])
                   @site.destroy
                   respond_to do |format|
                     format.html { redirect_to(sites_url) }
                     format.xml  { head :ok }
                   end
                 end
+            +   private
+            +
+            +     def site_params
+            +       params.require(:site).permit(:name,:started,:start_time,:country_id,:password)
+            +     end
+            +
               end

app/controllers/submissions_controller.rb ¶ +15 -56

               class SubmissionsController < ApplicationController
                 before_filter :authenticate
-            -   before_filter :submission_authorization, only: [:show, :direct_edit_submission]
+            +   before_filter :submission_authorization, only: [:show, :direct_edit_submission, :download]
                 # GET /submissions
                 # GET /submissions.json
                 # Show problem selection and user's submission of that problem
                 def index
                   @user = @current_user
                   @problems = @user.available_problems
                   if params[:problem_id]==nil
                     @problem = nil
                     @submissions = nil
                   else
                 end
                 # GET /submissions/1
                 # GET /submissions/1.json
                 def show
                   @submission = Submission.find(params[:id])
                   #log the viewing
                   user = User.find(session[:user_id])
                   SubmissionViewLog.create(user_id: session[:user_id],submission_id: @submission.id) unless user.admin?
                 end
+            +   def download
+            +     @submission = Submission.find(params[:id])
+            +     send_data(@submission.source, {:filename => @submission.download_filename, :type => 'text/plain'})
+            +   end
+            +
+            +   def compiler_msg
+            +     @submission = Submission.find(params[:id])
+            +     respond_to do |format|
+            +       format.js
+            +     end
+            +   end
+            +
                 #on-site new submission on specific problem
                 def direct_edit_problem
                   @problem = Problem.find(params[:problem_id])
                   @source = ''
                   render 'edit'
                 end
                 # GET /submissions/1/edit
                 def edit
                   @submission = Submission.find(params[:id])
                   @source = @submission.source.to_s
                   @problem = @submission.problem
                 def get_latest_submission_status
                   @problem = Problem.find(params[:pid])
                   @submission = Submission.find_last_by_user_and_problem(params[:uid],params[:pid])
                   puts User.find(params[:uid]).login
                   puts Problem.find(params[:pid]).name
                   puts 'nil' unless @submission
                   respond_to do |format|
                     format.js
                   end
                 end
-            - #  # GET /submissions/new
-            - #  # GET /submissions/new.json
-            - #  def new
-            - #    @submission = Submission.new
-            - #
-            - #    respond_to do |format|
-            - #      format.html # new.html.erb
-            - #      format.json { render json: @submission }
-            - #    end
-            - #  end
-            - #
-            - #
-            - #  # POST /submissions
-            - #  # POST /submissions.json
-            - #  def create
-            - #    @submission = Submission.new(params[:submission])
-            - #
-            - #    respond_to do |format|
-            - #      if @submission.save
-            - #        format.html { redirect_to @submission, notice: 'Submission was successfully created.' }
-            - #        format.json { render json: @submission, status: :created, location: @submission }
-            - #      else
-            - #        format.html { render action: "new" }
-            - #        format.json { render json: @submission.errors, status: :unprocessable_entity }
-            - #      end
-            - #    end
-            - #  end
-            - #
-            - #  # PUT /submissions/1
-            - #  # PUT /submissions/1.json
-            - #  def update
-            - #    @submission = Submission.find(params[:id])
-            - #
-            - #    respond_to do |format|
-            - #      if @submission.update_attributes(params[:submission])
-            - #        format.html { redirect_to @submission, notice: 'Submission was successfully updated.' }
-            - #        format.json { head :no_content }
-            - #      else
-            - #        format.html { render action: "edit" }
-            - #        format.json { render json: @submission.errors, status: :unprocessable_entity }
-            - #      end
-            - #    end
-            - #  end
-            - #
-            - #  # DELETE /submissions/1
-            - #  # DELETE /submissions/1.json
-            - #  def destroy
-            - #    @submission = Submission.find(params[:id])
-            - #    @submission.destroy
-            - #
-            - #    respond_to do |format|
-            - #      format.html { redirect_to submissions_url }
-            - #      format.json { head :no_content }
-            - #    end
-            - #  end
               protected
+            +
                 def submission_authorization
                   #admin always has privileged
                   if @current_user.admin?
                     return true
                   end
                   sub = Submission.find(params[:id])
                   if sub.problem.available?
                     puts "sub = #{sub.user.id}, current = #{@current_user.id}"
                     return true if GraderConfiguration["right.user_view_submission"] or sub.user == @current_user
                   end
                   #default to NO
                   unauthorized_redirect
                   return false
                 end
+            +
               end

app/controllers/user_admin_controller.rb ¶ +13 -8

                   if params[:page] == 'all'
                     @users = User.all
                     @paginated = false
                   else
                     @users = User.paginate :page => params[:page]
                     @paginated = true
                   end
                   @hidden_columns = ['hashed_password', 'salt', 'created_at', 'updated_at']
                   @contests = Contest.enabled
                 end
                 def active
-            -     sessions = ActiveRecord::SessionStore::Session.find(:all, :conditions => ["updated_at >= ?", 60.minutes.ago])
+            +     sessions = ActiveRecord::SessionStore::Session.where("updated_at >= ?", 60.minutes.ago)
                   @users = []
                   sessions.each do |session|
                     if session.data[:user_id]
                       @users << User.find(session.data[:user_id])
                     end
                   end
                 end
                 def show
                   @user = User.find(params[:id])
                 end
                   flash[:notice] = 'User(s) ' + note.join(', ') +
                     ' were successfully created.  ' +
                     '( (+) - created with random passwords.)'
                   redirect_to :action => 'index'
                 end
                 def edit
                   @user = User.find(params[:id])
                 end
                 def update
                   @user = User.find(params[:id])
-            -     if @user.update_attributes(params[:user])
+            +     if @user.update_attributes(user_params)
                     flash[:notice] = 'User was successfully updated.'
                     redirect_to :action => 'show', :id => @user
                   else
                     render :action => 'edit'
                   end
                 end
                 def destroy
                   User.find(params[:id]).destroy
                   redirect_to :action => 'index'
                 end
                 def user_stat
                   if params[:commit] == 'download csv'
                     @problems = Problem.all
                   else
-            -       @problems = Problem.find_available_problems
+            +       @problems = Problem.available_problems
                   end
-            -     @users = User.includes(:contests, :contest_stat).where(enabled: true) #find(:all, :include => [:contests, :contest_stat]).where(enabled: true)
+            +     @users = User.includes(:contests, :contest_stat).where(enabled: true)
                   @scorearray = Array.new
                   @users.each do |u|
                     ustat = Array.new
                     ustat[0] = u
                     @problems.each do |p|
                       sub = Submission.find_last_by_user_and_problem(u.id,p.id)
                       if (sub!=nil) and (sub.points!=nil) and p and p.full_score
                         ustat << [(sub.points.to_f*100/p.full_score).round, (sub.points>=p.full_score)]
                       else
                         ustat << [0,false]
                       end
                     end
                   if params[:commit] == 'download csv' then
                     csv = gen_csv_from_scorearray(@scorearray,@problems)
                     send_data csv, filename: 'last_score.csv'
                   else
                     render template: 'user_admin/user_stat'
                   end
                 end
                 def user_stat_max
                   if params[:commit] == 'download csv'
                     @problems = Problem.all
                   else
-            -       @problems = Problem.find_available_problems
+            +       @problems = Problem.available_problems
                   end
-            -     @users = User.find(:all, :include => [:contests, :contest_stat])
+            +     @users = User.includes(:contests).includes(:contest_stat).all
                   @scorearray = Array.new
                   #set up range from param
                   since_id = params.fetch(:since_id, 0).to_i
                   until_id = params.fetch(:until_id, 0).to_i
                   @users.each do |u|
                     ustat = Array.new
                     ustat[0] = u
                     @problems.each do |p|
                       max_points = 0
                       Submission.find_in_range_by_user_and_problem(u.id,p.id,since_id,until_id).each do |sub|
                         max_points = sub.points if sub and sub.points and (sub.points > max_points)
                       end
                   end
                 end
                 def import
                   if params[:file]==''
                     flash[:notice] = 'Error importing no file'
                     redirect_to :action => 'index' and return
                   end
                   import_from_file(params[:file])
                 end
                 def random_all_passwords
-            -     users = User.find(:all)
+            +     users = User.all
                   @prefix = params[:prefix] || ''
                   @non_admin_users = User.find_non_admin_with_prefix(@prefix)
                   @changed = false
                   if request.request_method == 'POST'
                     @non_admin_users.each do |user|
                       password = random_password
                       user.password = password
                       user.password_confirmation = password
                       user.save
                     end
                     @changed = true
                   end
                   if params[:reset_timer]
                     logout_users(users)
                   end
                   flash[:notice] = 'User(s) ' + note.join(', ') +
                     ' were successfully modified.  '
                   redirect_to :action => 'contest_management'
                 end
                 # admin management
                 def admin
-            -     @admins = User.find(:all).find_all {|user| user.admin? }
+            +     @admins = User.all.find_all {|user| user.admin? }
                 end
                 def grant_admin
                   login = params[:login]
                   user = User.find_by_login(login)
                   if user!=nil
                     admin_role = Role.find_by_name('admin')
                     user.roles << admin_role
                   else
                     flash[:notice] = 'Unknown user'
                   end
                   flash[:notice] = 'User added as admins'
                         else
                           row << sc[i][0]
                           total += sc[i][0]
                           num_passed += 1 if sc[i][1]
                         end
                       end
                       row << total
                       row << num_passed
                       csv << row
                     end
                   end
                 end
+            +
+            +   private
+            +     def user_params
+            +       params.require(:user).permit(:login,:full_name,:hashed_password,:salt,:alias,:email,:site_id,:country_id,:activated,:enabled,:remark,:last_ip,:section)
+            +     end
               end

app/models/announcement.rb ¶ +5 -11

               class Announcement < ActiveRecord::Base
-            -   def self.find_published(contest_started=false)
+            +   def self.published(contest_started=false)
                   if contest_started
-            -       Announcement.find(:all,
+            +       where(published: true).where(frontpage: false).order(created_at: :desc)
-            -                         :conditions => "(published = 1) AND (frontpage = 0)",
-            -                         :order => "created_at DESC")
                   else
-            -       Announcement.find(:all,
+            +       where(published: true).where(frontpage: false).where(contest_only: false).order(created_at: :desc)
-            -                         :conditions => "(published = 1) AND (frontpage = 0) AND (contest_only = 0)",
-            -                         :order => "created_at DESC")
                   end
                 end
-            -   def self.find_for_frontpage
+            +   def self.frontpage
-            -     Announcement.find(:all,
+            +     where(published: 1).where(frontpage: 1).order(created_at: :desc)
-            -                       :conditions => "(published = 1) AND (frontpage = 1)",
-            -                       :order => "created_at DESC")
                 end
               end

app/models/contest.rb ¶ +1 -1

               class Contest < ActiveRecord::Base
                 has_and_belongs_to_many :users
                 has_and_belongs_to_many :problems
-            -   scope :enabled, :conditions => {:enabled => true}
+            +   scope :enabled, -> { where(enabled: true) }
               end

app/models/grader_configuration.rb ¶ +1 -1

                     return val
                   when 'integer'
                     return val.to_i
                   when 'boolean'
                     return (val=='true')
                   end
                 end
                 def self.read_config
                   GraderConfiguration.config_cache = {}
-            -     GraderConfiguration.find(:all).each do |conf|
+            +     GraderConfiguration.all.each do |conf|
                     key = conf.key
                     val = conf.value
                     GraderConfiguration.config_cache[key] = GraderConfiguration.convert_type(val,conf.value_type)
                   end
                 end
                 def self.read_one_key(key)
                   conf = GraderConfiguration.find_by_key(key)
                   if conf
                     return GraderConfiguration.convert_type(conf.value,conf.value_type)
                   else
                     return nil

app/models/grader_process.rb ¶ +4 -13

               class GraderProcess < ActiveRecord::Base
                 def self.find_by_host_and_pid(host,pid)
-            -     return GraderProcess.find(:first,
+            +     return GraderProcess.where(host:host).where(pid: pid).first
-            -                               :conditions => {
-            -                                 :host => host,
-            -                                 :pid => pid
-            -                               })
                 end
                 def self.register(host,pid,mode)
                   grader = GraderProcess.find_by_host_and_pid(host,pid)
                   if grader
                     grader.mode = mode
                     grader.active = nil
                     grader.task_id = nil
                     grader.task_type = nil
                     grader.terminated = false
                     grader.save
                   else
                     grader = GraderProcess.create(:host => host,
                                                   :pid => pid,
                                                   :mode => mode,
                                                   :terminated => false)
                   end
                   grader
                 end
                 def self.find_running_graders
-            -     GraderProcess.find(:all,
+            +     where(terminated: false)
-            -                        :conditions => {:terminated => 0})
                 end
                 def self.find_terminated_graders
-            -     GraderProcess.find(:all,
+            +     where(terminated: true)
-            -                        :conditions => "`terminated`")
                 end
                 def self.find_stalled_process
-            -     GraderProcess.find(:all,
+            +     where(terminated: false).where(active: true).where("updated_at < ?",Time.now.gmtime - GraderProcess.stalled_time)
-            -                        :conditions => ["(`terminated` = 0) AND active AND " +
-            -                                        "(updated_at < ?)",
-            -                                        Time.now.gmtime - GraderProcess.stalled_time])
                 end
                 def report_active(task=nil)
                   self.active = true
                   if task!=nil
                     self.task_id = task.id
                     self.task_type = task.class.to_s
                   else
                     self.task_id = nil
                     self.task_type = nil
                   end
                   self.save

app/models/language.rb ¶ +1 -1

               class Language < ActiveRecord::Base
                 @@languages_by_ext = {}
                 def self.cache_ext_hash
                   @@languages_by_ext = {}
-            -     Language.find(:all).each do |language|
+            +     Language.all.each do |language|
                     language.common_ext.split(',').each do |ext|
                       @@languages_by_ext[ext] = language
                     end
                   end
                 end
                 def self.find_by_extension(ext)
                   if @@languages_by_ext.length == 0
                     Language.cache_ext_hash
                   end
                   if @@languages_by_ext.has_key? ext
                     return @@languages_by_ext[ext]

app/models/login.rb ¶ -1

               class Login < ActiveRecord::Base
                 belongs_to :user
-            -   attr_accessible :ip_address, :logged_in_at, :user_id
               end

app/models/message.rb ¶ +2 -4

                 #
                 attr_accessor :replied_messages
                 def self.find_all_sent_by_user(user)
                   messages = user.messages
                   replied_messages = user.replied_messages
                   Message.build_replying_message_hierarchy messages, replied_messages
                   return messages
                 end
                 def self.find_all_system_unreplied_messages
-            -     self.find(:all,
+            +     where('ISNULL(receiver_id) ' +
-            -               :conditions => 'ISNULL(receiver_id) ' +
+            +           'AND (ISNULL(replied) OR replied=0)')
-            -                              'AND (ISNULL(replied) OR replied=0)',
-            -               :order => 'created_at')
                 end
                 def self.build_replying_message_hierarchy(*args)
                   # manually build replies hierarchy (to improve efficiency)
                   all_messages = {}
                   args.each do |collection|
                     collection.each do |m|
                       all_messages[m.id] = m
                       m.replied_messages = []
                     end
                   end

app/models/problem.rb ¶ +5 -4

               class Problem < ActiveRecord::Base
                 belongs_to :description
                 has_and_belongs_to_many :contests, :uniq => true
                 has_many :test_pairs, :dependent => :delete_all
                 has_many :testcases, :dependent => :destroy
                 validates_presence_of :name
-            -   validates_format_of :name, :with => /^\w+$/
+            +   validates_format_of :name, :with => /\A\w+\z/
                 validates_presence_of :full_name
-            -   scope :available, :conditions => {:available => true}
+            +   scope :available, -> { where(available: true) }
                 DEFAULT_TIME_LIMIT = 1
                 DEFAULT_MEMORY_LIMIT = 32
-            -   def self.find_available_problems
+            +   def self.available_problems
-            -     Problem.available.all(:order => "date_added DESC, name ASC")
+            +     available.order(date_added: :desc).order(:name)
+            +     #Problem.available.all(:order => "date_added DESC, name ASC")
                 end
                 def self.create_from_import_form_params(params, old_problem=nil)
                   org_problem = old_problem || Problem.new
                   import_params, problem = Problem.extract_params_and_check(params,
                                                                             org_problem)
                   if !problem.errors.empty?
                     return problem, 'Error importing'
                   end
                   problem.full_score = 100

app/models/submission.rb ¶ +4 -17

                 before_validation :assign_problem
                 before_validation :assign_language
                 validates_presence_of :source
                 validates_length_of :source, :maximum => 100_000, :allow_blank => true, :message => 'too long'
                 validates_length_of :source, :minimum => 1, :allow_blank => true, :message => 'too short'
                 validate :must_have_valid_problem
                 validate :must_specify_language
                 before_save :assign_latest_number_if_new_recond
                 def self.find_last_by_user_and_problem(user_id, problem_id)
-            -     last_sub = find(:first,
+            +     where("user_id = ? AND problem_id = ?",user_id,problem_id).last
-            -                     :conditions => {:user_id => user_id,
-            -                       :problem_id => problem_id},
-            -                     :order => 'number DESC')
-            -     return last_sub
                 end
                 def self.find_all_last_by_problem(problem_id)
                   # need to put in SQL command, maybe there's a better way
                   Submission.includes(:user).find_by_sql("SELECT * FROM submissions " +
               			   "WHERE id = " +
               			   "(SELECT MAX(id) FROM submissions AS subs " +
               			   "WHERE subs.user_id = submissions.user_id AND " +
                                          "problem_id = " + problem_id.to_s + " " +
               			   "GROUP BY user_id) " +
                                          "ORDER BY user_id")
                 end
                 def self.find_in_range_by_user_and_problem(user_id, problem_id,since_id,until_id)
                   records = Submission.where(problem_id: problem_id,user_id: user_id)
                   records = records.where('id >= ?',since_id) if since_id > 0
                   records = records.where('id <= ?',until_id) if until_id > 0
                   records.all
                 end
                 def self.find_last_for_all_available_problems(user_id)
                   submissions = Array.new
-            -     problems = Problem.find_available_problems
+            +     problems = Problem.available_problems
                   problems.each do |problem|
                     sub = Submission.find_last_by_user_and_problem(user_id, problem.id)
                     submissions << sub if sub!=nil
                   end
                   submissions
                 end
                 def self.find_by_user_problem_number(user_id, problem_id, number)
-            -     Submission.find(:first,
+            +     where("user_id = ? AND problem_id = ? AND number = ?",user_id,problem_id,number).first
-            -                     :conditions => {
-            -                       :user_id => user_id,
-            -                       :problem_id => problem_id,
-            -                       :number => number
-            -                     })
                 end
                 def self.find_all_by_user_problem(user_id, problem_id)
-            -     Submission.find(:all,
+            +     where("user_id = ? AND problem_id = ?",user_id,problem_id)
-            -                     :conditions => {
-            -                       :user_id => user_id,
-            -                       :problem_id => problem_id,
-            -                     })
                 end
                 def download_filename
                   if self.problem.output_only
                     return self.source_filename
                   else
                     timestamp = self.submitted_at.localtime.strftime("%H%M%S")
                     return "#{self.problem.name}-#{timestamp}.#{self.language.ext}"
                   end
                 end
                 protected

app/models/submission_view_log.rb ¶ +1 -1

               class SubmissionViewLog < ActiveRecord::Base
-            -   attr_accessible :submission_id, :user_id
+            +   #attr_accessible :submission_id, :user_id
               end

app/models/task.rb ¶ +1 -4

                     "inqueue"
                   when Task::STATUS_GRADING
                     "grading"
                   when Task::STATUS_COMPLETE
                     "complete"
                   end
                 end
                 def self.get_inqueue_and_change_status(status)
                   task = nil
                   begin
                     Task.transaction do
-            -         task = Task.find(:first,
+            +         task = Task.where(status: Task::STATUS_INQUEUE).where(lock: true).first
-            -                          :order => "created_at",
-            -                          :conditions => {:status=> Task::STATUS_INQUEUE},
-            -                          :lock => true)
                       if task!=nil
                         task.status = status
                         task.save!
                       end
                     end
                   rescue
                     task = nil
                   end
                   task
                 end

app/models/test_request.rb ¶ +2 -5

               #   it works as well with problem=nil.  In this case, we shall provide
               #   a "default" execution environment for it.  This can be done
               #   seamlessly by using TestRequest#problem_name or
               #   TestRequest#name_of(problem) when retrieving the name of the
               #   problem: #name_of would return problem.name when problem!=nil and
               #   it would return "default" when problem=nil, #problem_name just
               #   call #name_of.
               #
               require 'fileutils'
               class TestRequest < Task
+            +   self.table_name = "test_requests"
-            -   set_table_name "test_requests"
                 belongs_to :user
                 belongs_to :problem
                 belongs_to :submission
                 validates_presence_of :submission
                 validate :must_have_valid_problem
                 def problem_name
                   TestRequest.name_of(self.problem)
                 end
                 def language
                   self.submission.language
                 end
                 def self.get_inqueue_and_change_status(status)
                   # since there will be only one grader grading TestRequest
                   # we do not need locking (hopefully)
-            -     test_request = TestRequest.find(:first,
+            +     test_request = TestRequest.where(status: Task::STATUS_INQUEUE).first
-            -                                     :order => "created_at",
-            -                                     :conditions => {:status=> Task::STATUS_INQUEUE})
                   if test_request!=nil
                     test_request.status = status
                     test_request.save!
                   end
                   test_request
                 end
                 # interfacing with form
                 def self.new_from_form_params(user,params)
                   test_request = TestRequest.new
                   test_request.user = user

app/models/testcase.rb ¶ +1 -1

               class Testcase < ActiveRecord::Base
                 belongs_to :problem
-            -   attr_accessible :group, :input, :num, :score, :sol
+            +   #attr_accessible :group, :input, :num, :score, :sol
               end

app/models/user.rb ¶ +11 -13

               require 'digest/sha1'
               require 'net/pop'
               require 'net/https'
               require 'net/http'
               require 'json'
               class User < ActiveRecord::Base
                 has_and_belongs_to_many :roles
-            -   has_many :test_requests, :order => "submitted_at DESC"
+            +   has_many :test_requests, -> {order(submitted_at: DESC)}
-            -   has_many :messages,
+            +   has_many :messages, -> { order(created_at: DESC) },
                          :class_name => "Message",
-            -            :foreign_key => "sender_id",
+            +            :foreign_key => "sender_id"
-            -            :order => 'created_at DESC'
-            -   has_many :replied_messages,
+            +   has_many :replied_messages, -> { order(created_at: DESC) },
                          :class_name => "Message",
-            -            :foreign_key => "receiver_id",
+            +            :foreign_key => "receiver_id"
-            -            :order => 'created_at DESC'
                 has_one :contest_stat, :class_name => "UserContestStat", :dependent => :destroy
                 belongs_to :site
                 belongs_to :country
-            -   has_and_belongs_to_many :contests, :uniq => true, :order => 'name'
+            +   has_and_belongs_to_many :contests, -> { order(:name); uniq}
-            -   scope :activated_users, :conditions => {:activated => true}
+            +   scope :activated_users, -> {where activated: true}
                 validates_presence_of :login
                 validates_uniqueness_of :login
-            -   validates_format_of :login, :with => /^[\_A-Za-z0-9]+$/
+            +   validates_format_of :login, :with => /\A[\_A-Za-z0-9]+\z/
                 validates_length_of :login, :within => 3..30
                 validates_presence_of :full_name
                 validates_length_of :full_name, :minimum => 1
                 validates_presence_of :password, :if => :password_required?
                 validates_length_of :password, :within => 4..20, :if => :password_required?
                 validates_confirmation_of :password, :if => :password_required?
                 validates_format_of :email,
                                     :with => /\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\Z/i,
                                     :if => :email_validation?
                 def verify_activation_key(key)
                   key == activation_key
                 end
                 def self.random_password(length=5)
                   chars = 'abcdefghjkmnopqrstuvwxyz'
                   password = ''
                   length.times { password << chars[rand(chars.length - 1)] }
                   password
                 end
                 def self.find_non_admin_with_prefix(prefix='')
-            -     users = User.find(:all)
+            +     users = User.all
                   return users.find_all { |u| !(u.admin?) and u.login.index(prefix)==0 }
                 end
                 # Contest information
                 def self.find_users_with_no_contest()
-            -     users = User.find(:all)
+            +     users = User.all
                   return users.find_all { |u| u.contests.length == 0 }
                 end
                 def contest_time_left
                   if GraderConfiguration.contest_mode?
                     return nil if site==nil
                     return site.time_left
                   elsif GraderConfiguration.indv_contest_mode?
                     time_limit = GraderConfiguration.contest_time_limit
                     if time_limit == nil
                       return nil
                     available_problems.each {|p| pin[p.id] = true}
                   end
                   other_avaiable_problems = Problem.available.find_all {|p| pin[p.id]==nil and p.contests.length==0}
                   contest_problems << {
                     :contest => nil,
                     :problems => other_avaiable_problems
                   }
                   return contest_problems
                 end
                 def available_problems
                   if not GraderConfiguration.multicontests?
-            -       return Problem.find_available_problems
+            +       return Problem.available_problems
                   else
                     contest_problems = []
                     pin = {}
                     contests.enabled.each do |contest|
                       contest.problems.available.each do |problem|
                         if not pin.has_key? problem.id
                           contest_problems << problem
                         end
                         pin[problem.id] = true
                       end
                     end
                     other_avaiable_problems = Problem.available.find_all {|p| pin[p.id]==nil and p.contests.length==0}

app/views/application/_submission_short.html.haml ¶ +10 -10

               - if submission.nil?
                 = "-"
               - else
                 - unless submission.graded_at
                   = t 'main.submitted_at'
                   = format_short_time(submission.submitted_at.localtime)
                 - else
-            -     = t 'main.graded_at'
+            +     %strong= t 'main.graded_at'
-            -     = "#{format_short_time(submission.graded_at.localtime)}, "
+            +     = "#{format_short_time(submission.graded_at.localtime)} "
+            +     %br
                   - if GraderConfiguration['ui.show_score']
-            -       = t 'main.score'
+            +       %strong=t 'main.score'
                     = "#{(submission.points*100/submission.problem.full_score).to_i} "
                   = " ["
                   %tt
                     = submission.grader_comment
                   = "]"
+            +     %br
+            +     %strong View:
                   - if GraderConfiguration.show_grading_result
-            -       = " | "
                     = link_to '[detailed result]', :action => 'result', :id => submission.id
-            -     = " | "
+            +     = link_to "#{t 'main.cmp_msg'}", {:action => 'compiler_msg', :id => submission.id}, {popup: true,class: 'btn btn-xs btn-info'}
-            -     = link_to("[#{t 'main.cmp_msg'}]", {:action => 'compiler_msg', :id => submission.id}, {:popup => true})
+            +   = link_to "#{t 'main.src_link'}", download_submission_path(submission.id), class: 'btn btn-xs btn-info'
-            -   = " | "
+            +   = link_to "#{t 'main.submissions_link'}", problem_submissions_path(problem_id), class: 'btn btn-xs btn-info'
-            -   = link_to("[#{t 'main.src_link'}]",{:action => 'source', :id => submission.id})
-            -   //= " | "
-            -   //= link_to "[#{t 'main.submissions_link'}]", main_submission_path(submission.problem.id)

app/views/main/_submission_short.html.haml ¶ +2 -1

                   %br
                   - if GraderConfiguration['ui.show_score']
                     %strong=t 'main.score'
                     = "#{(submission.points*100/submission.problem.full_score).to_i} "
                   = " ["
                   %tt
                     = submission.grader_comment
                   = "]"
                   %br
                   %strong View:
                   - if GraderConfiguration.show_grading_result
                     = link_to '[detailed result]', :action => 'result', :id => submission.id
-            -     = link_to "#{t 'main.cmp_msg'}", {:action => 'compiler_msg', :id => submission.id}, {popup: true,class: 'btn btn-xs btn-info'}
+            +     /= link_to "#{t 'main.cmp_msg'}", {:action => 'compiler_msg', :id => submission.id}, {popup: true,class: 'btn btn-xs btn-info'}
+            +     = link_to "#{t 'main.cmp_msg'}", compiler_msg_submission_path(submission.id), {popup: true,remote: true,class: 'btn btn-xs btn-info'}
                 = link_to "#{t 'main.src_link'}",{:action => 'source', :id => submission.id}, class: 'btn btn-xs btn-info'
                 = link_to "#{t 'main.submissions_link'}", problem_submissions_path(problem_id), class: 'btn btn-xs btn-info'

app/views/report/_score_table.html.haml ¶ +1 -1

                     / %th Contest(s)
                     %th Remark
                     - @problems.each do |p|
                       %th.text-right= p.name.gsub('_',' ')
                     %th.text-right Total
                     %th.text-right Passed
                 %tbody
                   - @scorearray.each do |sc|
                     %tr
                       - total,num_passed = 0,0
                       - sc.each_index do |i|
                         - if i == 0
-            -             %td= link_to sc[i].login, controller: 'users', action: 'profile', id: sc[i]
+            +             %td= link_to sc[i].login, stat_user_path(sc[i])
                           %td= sc[i].full_name
                           / %td= sc[i].activated
                           / %td= sc[i].try(:contest_stat).try(:started_at) ? 'yes' : 'no'
                           / %td= sc[i].contests.collect {|c| c.name}.join(', ')
                           %td= sc[i].remark
                         - else
                           %td.text-right= sc[i][0]
                           - total += sc[i][0]
                           - num_passed += 1 if sc[i][1]
                       %td.text-right= total
                       %td.text-right= num_passed

app/views/submissions/edit.html.haml ¶ +2 -1

                         = label_tag "Task:"
                         = text_field_tag 'asdf', "#{@problem.long_name}", class: 'form-control', disabled: true
                       .form-group
                         = label_tag 'Language'
                         = select_tag 'language_id', options_from_collection_for_select(Language.all, 'id', 'pretty_name', @lang_id || Language.find_by_pretty_name("Python").id || Language.first.id), class: 'form-control select', style: "width: 100px"
                       .form-group
                         = submit_tag 'Submit', class: 'btn btn-success', id: 'live_submit',
                           data: {confirm: "Submitting this source code for task #{@problem.long_name}?"}
                     .panel.panel-info
                       .panel-heading
                         Latest Submission Status
+            +           = link_to "Refresh",get_latest_submission_status_submissions_path(@submission.user,@problem), class: "btn btn-default btn-sm", remote: true
                       .panel-body
                         - if @submission
                           = render :partial => 'submission_short',
-            -               :locals => {:submission => @submission, :problem_name => @problem.name }
+            +               :locals => {submission: @submission, problem_name: @problem.name, problem_id: @problem.id }
                 .row
                   .col-md-12
                     %h2 Console
                     %textarea#console{style: 'height: 100%; width: 100%;background-color:#000;color:#fff;font-family: consolas, monaco, "Droid Sans Mono";',rows: 20}
               :javascript
                 $(document).ready(function() {
                   e = ace.edit("editor")
                   e.setValue($("#text_haha").val());
                   e.gotoLine(1);
                   $("#language_id").trigger('change');
                   brython();

app/views/submissions/show.html.haml ¶ +12 -11

                           %strong Runtime (s)
                         %td #{@submission.max_runtime}
                       %tr
                         %td.text-right
                           %strong Memory (kb)
                         %td #{@submission.peak_memory}
                       %tr
                         %td.text-right
                           %strong Compiler result
                         %td
                           %button.btn.btn-info.btn-xs{type: 'button', data: {toggle: 'modal', target: '#compiler'}}
                             view
-            -             .modal.fade#compiler{tabindex: -1,role: 'dialog'}
-            -               .modal-dialog.modal-lg{role:'document'}
-            -                 .modal-content
-            -                   .modal-header
-            -                     %button.close{type: 'button', data: {dismissed: :modal}, aria: {label: 'close'}}
-            -                       %span{aria: {hidden: 'true'}, data: {dismiss: 'modal'}} &times;
-            -                     %h4 Compiler message
-            -                   .modal-body
-            -                     %pre= @submission.compiler_message
-            -                   .modal-footer
-            -                     %button.btn.btn-default{type: 'button', data: {dismiss: 'modal'}} Close
                       - if session[:admin]
                         %tr
                           %td.text-right
                             %strong IP
                           %td #{@submission.ip_address}
+            +
+            + .modal.fade#compiler{tabindex: -1,role: 'dialog'}
+            +   .modal-dialog.modal-lg{role:'document'}
+            +     .modal-content
+            +       .modal-header
+            +         %button.close{type: 'button', data: {dismissed: :modal}, aria: {label: 'close'}}
+            +           %span{aria: {hidden: 'true'}, data: {dismiss: 'modal'}} &times;
+            +         %h4 Compiler message
+            +       .modal-body
+            +         %pre#compiler_msg= @submission.compiler_message
+            +       .modal-footer
+            +         %button.btn.btn-default{type: 'button', data: {dismiss: 'modal'}} Close

config/environments/development.rb ¶ +9 -7

               CafeGrader::Application.configure do
                 # Settings specified here will take precedence over those in config/application.rb
                 # In the development environment your application's code is reloaded on
                 # every request. This slows down response time but is perfect for development
                 # since you don't have to restart the web server when you make code changes.
                 config.cache_classes = false
-            -   # Log error messages when you accidentally call methods on nil.
+            +   # Log error messages when you accidentally call methods on nil.  //DEPRICATED
-            -   config.whiny_nils = true
+            +   # config.whiny_nils = true // DEPRICATED
                 # Show full error reports and disable caching
                 config.consider_all_requests_local       = true
                 config.action_controller.perform_caching = false
                 # Don't care if the mailer can't send
                 config.action_mailer.raise_delivery_errors = false
                 # Print deprecation notices to the Rails logger
                 config.active_support.deprecation = :log
                 # Only use best-standards-support built into browsers
                 config.action_dispatch.best_standards_support = :builtin
                 # Raise exception on mass assignment protection for Active Record models
-            -   config.active_record.mass_assignment_sanitizer = :strict
+            +   # config.active_record.mass_assignment_sanitizer = :strict //DEPRICATED
-            -   # Log the query plan for queries taking more than this (works
+            +   # Log the query plan for queries taking more than this (works // DEPRICATED
-            -   # with SQLite, MySQL, and PostgreSQL)
+            +   # with SQLite, MySQL, and PostgreSQL) // DEPRICATED
-            -   config.active_record.auto_explain_threshold_in_seconds = 0.5
+            +   # config.active_record.auto_explain_threshold_in_seconds = 0.5 // DEPRICATED
                 # Do not compress assets
                 config.assets.compress = false
                 # Expands the lines which load the assets
                 config.assets.debug = true
                 # Prevents assets from rendering twice
-            -   config.serve_static_assets = true
+            +   config.serve_static_files = true
+            +
+            +   config.eager_load = false
               end

config/environments/production.rb ¶ +3 -1

               CafeGrader::Application.configure do
                 # Settings specified here will take precedence over those in config/application.rb
                 # Code is not reloaded between requests
                 config.cache_classes = true
                 # Full error reports are disabled and caching is turned on
                 config.consider_all_requests_local       = false
                 config.action_controller.perform_caching = true
                 # Disable Rails's static asset server (Apache or nginx will already do this)
-            -   config.serve_static_assets = false
+            +   config.serve_static_files = false
                 # Compress JavaScripts and CSS
                 config.assets.compress = true
                 # Don't fallback to assets pipeline if a precompiled asset is missed
                 config.assets.compile = false
                 # Generate digests for assets URLs
                 config.assets.digest = true
                 # Defaults to nil and saved in location specified by config.assets.prefix
                 # config.assets.manifest = YOUR_PATH
                 # config.threadsafe!
                 # Enable locale fallbacks for I18n (makes lookups for any locale fall back to
                 # the I18n.default_locale when a translation can not be found)
                 config.i18n.fallbacks = true
                 # Send deprecation notices to registered listeners
                 config.active_support.deprecation = :notify
                 # Log the query plan for queries taking more than this (works
                 # with SQLite, MySQL, and PostgreSQL)
                 # config.active_record.auto_explain_threshold_in_seconds = 0.5
+            +
+            +   config.eager_load = true
               end

config/environments/test.rb ¶ +8 -2

               CafeGrader::Application.configure do
                 # Settings specified here will take precedence over those in config/application.rb
                 # The test environment is used exclusively to run your application's
                 # test suite. You never need to work with it otherwise. Remember that
                 # your test database is "scratch space" for the test suite and is wiped
                 # and recreated between test runs. Don't rely on the data there!
                 config.cache_classes = true
                 # Configure static asset server for tests with Cache-Control for performance
-            -   config.serve_static_assets = true
+            +   config.serve_static_files = true
                 config.static_cache_control = "public, max-age=3600"
                 # Log error messages when you accidentally call methods on nil
                 config.whiny_nils = true
                 # Show full error reports and disable caching
                 config.consider_all_requests_local       = true
                 config.action_controller.perform_caching = false
                 # Raise exceptions instead of rendering exception templates
                 config.action_dispatch.show_exceptions = false
                 # Disable request forgery protection in test environment
                 config.action_controller.allow_forgery_protection    = false
                 # Tell Action Mailer not to deliver emails to the real world.
                 # The :test delivery method accumulates sent emails in the
                 # ActionMailer::Base.deliveries array.
                 config.action_mailer.delivery_method = :test
                 # Raise exception on mass assignment protection for Active Record models
-            -   config.active_record.mass_assignment_sanitizer = :strict
+            +   #config.active_record.mass_assignment_sanitizer = :strict // DEPRICATED
                 # Print deprecation notices to the stderr
                 config.active_support.deprecation = :stderr
+            +
+            +   config.eager_load = false
+            +
+            +   #test order
+            +   config.active_support.test_order = :sorted
+            +
               end

config/initializers/mime_types.rb ¶ -1

               # Be sure to restart your server when you modify this file.
               # Add new mime types for use in respond_to blocks:
               # Mime::Type.register "text/richtext", :rtf
               # Mime::Type.register_alias "text/html", :iphone
-            - Mime::Type.register 'application/pdf', :pdf

config/routes.rb ¶ +9 -5

                 end
                 resources :grader_configuration, controller: 'configurations'
                 resources :users do
                   member do
                     get 'toggle_activate', 'toggle_enable'
                     get 'stat'
                   end
                 end
                 resources :submissions do
+            +     member do
+            +       get 'download'
+            +       get 'compiler_msg'
+            +     end
                   collection do
                     get 'prob/:problem_id', to: 'submissions#index', as: 'problem'
                     get 'direct_edit_problem/:problem_id', to: 'submissions#direct_edit_problem', as: 'direct_edit_problem'
                     get 'get_latest_submission_status/:uid/:pid', to: 'submissions#get_latest_submission_status', as: 'get_latest_submission_status'
                   end
                 end
-            -   match 'tasks/view/:file.:ext' => 'tasks#view'
+            +   get 'tasks/view/:file.:ext' => 'tasks#view'
-            -   match 'tasks/download/:id/:file.:ext' => 'tasks#download'
+            +   get 'tasks/download/:id/:file.:ext' => 'tasks#download'
-            -   match 'heartbeat/:id/edit' => 'heartbeat#edit'
+            +   get 'heartbeat/:id/edit' => 'heartbeat#edit'
                 #main
                 get "main/list"
                 get 'main/submission(/:id)', to: 'main#submission', as: 'main_submission'
                 #report
                 get 'report/current_score', to: 'report#current_score', as: 'report_current_score'
                 get 'report/problem_hof(/:id)', to: 'report#problem_hof', as: 'report_problem_hof'
                 get "report/login"
                 get 'report/max_score', to: 'report#max_score', as: 'report_max_score'
                 post 'report/show_max_score', to: 'report#show_max_score', as: 'report_show_max_score'
                 #grader
                 get 'graders/list', to: 'graders#list', as: 'grader_list'
-            -   match 'heartbeat/:id/edit' => 'heartbeat#edit'
+            +   get 'heartbeat/:id/edit' => 'heartbeat#edit'
                 # See how all your routes lay out with "rake routes"
                 # This is a legacy wild controller route that's not recommended for RESTful applications.
                 # Note: This route will make all actions in every controller accessible via GET requests.
-            -   match ':controller(/:action(/:id))(.:format)'
+            +   match ':controller(/:action(/:id))(.:format)', via:  [:get, :post]
               end

db/schema.rb ¶ +81 -81

               # encoding: UTF-8
               # This file is auto-generated from the current state of the database. Instead
               # of editing this file, please use the migrations feature of Active Record to
               # incrementally modify your database, and then regenerate this schema definition.
               #
               # Note that this schema.rb definition is the authoritative source for your
               # database schema. If you need to create the application database on another
               # system, you should be using db:schema:load, not running all the migrations
               # from scratch. The latter is a flawed and unsustainable approach (the more migrations
               # you'll amass, the slower it'll run and the greater likelihood for issues).
               #
-            - # It's strongly recommended to check this file into your version control system.
+            + # It's strongly recommended that you check this file into your version control system.
-            - ActiveRecord::Schema.define(:version => 20161031063337) do
+            + ActiveRecord::Schema.define(version: 20161031063337) do
-            -   create_table "announcements", :force => true do |t|
+            +   create_table "announcements", force: :cascade do |t|
                   t.string   "author"
                   t.text     "body"
                   t.boolean  "published"
-            -     t.datetime "created_at",                      :null => false
+            +     t.datetime "created_at",                   null: false
-            -     t.datetime "updated_at",                      :null => false
+            +     t.datetime "updated_at",                   null: false
-            -     t.boolean  "frontpage",    :default => false
+            +     t.boolean  "frontpage",    default: false
-            -     t.boolean  "contest_only", :default => false
+            +     t.boolean  "contest_only", default: false
                   t.string   "title"
                   t.string   "notes"
                 end
-            -   create_table "contests", :force => true do |t|
+            +   create_table "contests", force: :cascade do |t|
                   t.string   "title"
                   t.boolean  "enabled"
-            -     t.datetime "created_at", :null => false
+            +     t.datetime "created_at", null: false
-            -     t.datetime "updated_at", :null => false
+            +     t.datetime "updated_at", null: false
                   t.string   "name"
                 end
-            -   create_table "contests_problems", :id => false, :force => true do |t|
+            +   create_table "contests_problems", id: false, force: :cascade do |t|
                   t.integer "contest_id"
                   t.integer "problem_id"
                 end
-            -   create_table "contests_users", :id => false, :force => true do |t|
+            +   create_table "contests_users", id: false, force: :cascade do |t|
                   t.integer "contest_id"
                   t.integer "user_id"
                 end
-            -   create_table "countries", :force => true do |t|
+            +   create_table "countries", force: :cascade do |t|
                   t.string   "name"
-            -     t.datetime "created_at", :null => false
+            +     t.datetime "created_at", null: false
-            -     t.datetime "updated_at", :null => false
+            +     t.datetime "updated_at", null: false
                 end
-            -   create_table "descriptions", :force => true do |t|
+            +   create_table "descriptions", force: :cascade do |t|
                   t.text     "body"
                   t.boolean  "markdowned"
-            -     t.datetime "created_at", :null => false
+            +     t.datetime "created_at", null: false
-            -     t.datetime "updated_at", :null => false
+            +     t.datetime "updated_at", null: false
                 end
-            -   create_table "grader_configurations", :force => true do |t|
+            +   create_table "grader_configurations", force: :cascade do |t|
                   t.string   "key"
                   t.string   "value_type"
                   t.string   "value"
-            -     t.datetime "created_at",  :null => false
+            +     t.datetime "created_at",  null: false
-            -     t.datetime "updated_at",  :null => false
+            +     t.datetime "updated_at",  null: false
                   t.text     "description"
                 end
-            -   create_table "grader_processes", :force => true do |t|
+            +   create_table "grader_processes", force: :cascade do |t|
                   t.string   "host"
                   t.integer  "pid"
                   t.string   "mode"
                   t.boolean  "active"
-            -     t.datetime "created_at", :null => false
+            +     t.datetime "created_at", null: false
-            -     t.datetime "updated_at", :null => false
+            +     t.datetime "updated_at", null: false
                   t.integer  "task_id"
                   t.string   "task_type"
                   t.boolean  "terminated"
                 end
-            -   add_index "grader_processes", ["host", "pid"], :name => "index_grader_processes_on_ip_and_pid"
+            +   add_index "grader_processes", ["host", "pid"], name: "index_grader_processes_on_ip_and_pid"
-            -   create_table "heart_beats", :force => true do |t|
+            +   create_table "heart_beats", force: :cascade do |t|
                   t.integer  "user_id"
                   t.string   "ip_address"
-            -     t.datetime "created_at", :null => false
+            +     t.datetime "created_at", null: false
-            -     t.datetime "updated_at", :null => false
+            +     t.datetime "updated_at", null: false
                   t.string   "status"
                 end
-            -   add_index "heart_beats", ["updated_at"], :name => "index_heart_beats_on_updated_at"
+            +   add_index "heart_beats", ["updated_at"], name: "index_heart_beats_on_updated_at"
-            -   create_table "languages", :force => true do |t|
+            +   create_table "languages", force: :cascade do |t|
-            -     t.string "name",        :limit => 10
+            +     t.string "name",        limit: 10
                   t.string "pretty_name"
-            -     t.string "ext",         :limit => 10
+            +     t.string "ext",         limit: 10
                   t.string "common_ext"
                 end
-            -   create_table "logins", :force => true do |t|
+            +   create_table "logins", force: :cascade do |t|
                   t.integer  "user_id"
                   t.string   "ip_address"
-            -     t.datetime "created_at", :null => false
+            +     t.datetime "created_at", null: false
-            -     t.datetime "updated_at", :null => false
+            +     t.datetime "updated_at", null: false
                 end
-            -   create_table "messages", :force => true do |t|
+            +   create_table "messages", force: :cascade do |t|
                   t.integer  "sender_id"
                   t.integer  "receiver_id"
                   t.integer  "replying_message_id"
                   t.text     "body"
                   t.boolean  "replied"
-            -     t.datetime "created_at",          :null => false
+            +     t.datetime "created_at",          null: false
-            -     t.datetime "updated_at",          :null => false
+            +     t.datetime "updated_at",          null: false
                 end
-            -   create_table "problems", :force => true do |t|
+            +   create_table "problems", force: :cascade do |t|
-            -     t.string  "name",                 :limit => 30
+            +     t.string  "name",                 limit: 30
                   t.string  "full_name"
                   t.integer "full_score"
                   t.date    "date_added"
                   t.boolean "available"
                   t.string  "url"
                   t.integer "description_id"
                   t.boolean "test_allowed"
                   t.boolean "output_only"
                   t.string  "description_filename"
                 end
-            -   create_table "rights", :force => true do |t|
+            +   create_table "rights", force: :cascade do |t|
                   t.string "name"
                   t.string "controller"
                   t.string "action"
                 end
-            -   create_table "rights_roles", :id => false, :force => true do |t|
+            +   create_table "rights_roles", id: false, force: :cascade do |t|
                   t.integer "right_id"
                   t.integer "role_id"
                 end
-            -   add_index "rights_roles", ["role_id"], :name => "index_rights_roles_on_role_id"
+            +   add_index "rights_roles", ["role_id"], name: "index_rights_roles_on_role_id"
-            -   create_table "roles", :force => true do |t|
+            +   create_table "roles", force: :cascade do |t|
                   t.string "name"
                 end
-            -   create_table "roles_users", :id => false, :force => true do |t|
+            +   create_table "roles_users", id: false, force: :cascade do |t|
                   t.integer "role_id"
                   t.integer "user_id"
                 end
-            -   add_index "roles_users", ["user_id"], :name => "index_roles_users_on_user_id"
+            +   add_index "roles_users", ["user_id"], name: "index_roles_users_on_user_id"
-            -   create_table "sessions", :force => true do |t|
+            +   create_table "sessions", force: :cascade do |t|
                   t.string   "session_id"
                   t.text     "data"
                   t.datetime "updated_at"
                 end
-            -   add_index "sessions", ["session_id"], :name => "index_sessions_on_session_id"
+            +   add_index "sessions", ["session_id"], name: "index_sessions_on_session_id"
-            -   add_index "sessions", ["updated_at"], :name => "index_sessions_on_updated_at"
+            +   add_index "sessions", ["updated_at"], name: "index_sessions_on_updated_at"
-            -   create_table "sites", :force => true do |t|
+            +   create_table "sites", force: :cascade do |t|
                   t.string   "name"
                   t.boolean  "started"
                   t.datetime "start_time"
-            -     t.datetime "created_at", :null => false
+            +     t.datetime "created_at", null: false
-            -     t.datetime "updated_at", :null => false
+            +     t.datetime "updated_at", null: false
                   t.integer  "country_id"
                   t.string   "password"
                 end
-            -   create_table "submission_view_logs", :force => true do |t|
+            +   create_table "submission_view_logs", force: :cascade do |t|
                   t.integer  "user_id"
                   t.integer  "submission_id"
-            -     t.datetime "created_at",    :null => false
+            +     t.datetime "created_at",    null: false
-            -     t.datetime "updated_at",    :null => false
+            +     t.datetime "updated_at",    null: false
                 end
-            -   create_table "submissions", :force => true do |t|
+            +   create_table "submissions", force: :cascade do |t|
                   t.integer  "user_id"
                   t.integer  "problem_id"
                   t.integer  "language_id"
                   t.text     "source"
                   t.binary   "binary"
                   t.datetime "submitted_at"
                   t.datetime "compiled_at"
                   t.text     "compiler_message"
                   t.datetime "graded_at"
                   t.integer  "points"
                   t.text     "grader_comment"
                   t.integer  "number"
                   t.string   "source_filename"
                   t.float    "max_runtime"
                   t.integer  "peak_memory"
                   t.integer  "effective_code_length"
                   t.string   "ip_address"
                 end
-            -   add_index "submissions", ["user_id", "problem_id", "number"], :name => "index_submissions_on_user_id_and_problem_id_and_number", :unique => true
+            +   add_index "submissions", ["user_id", "problem_id", "number"], name: "index_submissions_on_user_id_and_problem_id_and_number", unique: true
-            -   add_index "submissions", ["user_id", "problem_id"], :name => "index_submissions_on_user_id_and_problem_id"
+            +   add_index "submissions", ["user_id", "problem_id"], name: "index_submissions_on_user_id_and_problem_id"
-            -   create_table "tasks", :force => true do |t|
+            +   create_table "tasks", force: :cascade do |t|
                   t.integer  "submission_id"
                   t.datetime "created_at"
                   t.integer  "status"
                   t.datetime "updated_at"
                 end
-            -   create_table "test_pairs", :force => true do |t|
+            +   create_table "test_pairs", force: :cascade do |t|
                   t.integer  "problem_id"
-            -     t.text     "input",      :limit => 16777215
+            +     t.text     "input",      limit: 16777215
-            -     t.text     "solution",   :limit => 16777215
+            +     t.text     "solution",   limit: 16777215
-            -     t.datetime "created_at",                     :null => false
+            +     t.datetime "created_at",                  null: false
-            -     t.datetime "updated_at",                     :null => false
+            +     t.datetime "updated_at",                  null: false
                 end
-            -   create_table "test_requests", :force => true do |t|
+            +   create_table "test_requests", force: :cascade do |t|
                   t.integer  "user_id"
                   t.integer  "problem_id"
                   t.integer  "submission_id"
                   t.string   "input_file_name"
                   t.string   "output_file_name"
                   t.string   "running_stat"
                   t.integer  "status"
-            -     t.datetime "updated_at",       :null => false
+            +     t.datetime "updated_at",       null: false
                   t.datetime "submitted_at"
                   t.datetime "compiled_at"
                   t.text     "compiler_message"
                   t.datetime "graded_at"
                   t.string   "grader_comment"
-            -     t.datetime "created_at",       :null => false
+            +     t.datetime "created_at",       null: false
                   t.float    "running_time"
                   t.string   "exit_status"
                   t.integer  "memory_usage"
                 end
-            -   add_index "test_requests", ["user_id", "problem_id"], :name => "index_test_requests_on_user_id_and_problem_id"
+            +   add_index "test_requests", ["user_id", "problem_id"], name: "index_test_requests_on_user_id_and_problem_id"
-            -   create_table "testcases", :force => true do |t|
+            +   create_table "testcases", force: :cascade do |t|
                   t.integer  "problem_id"
                   t.integer  "num"
                   t.integer  "group"
                   t.integer  "score"
                   t.text     "input"
                   t.text     "sol"
-            -     t.datetime "created_at", :null => false
+            +     t.datetime "created_at", null: false
-            -     t.datetime "updated_at", :null => false
+            +     t.datetime "updated_at", null: false
                 end
-            -   add_index "testcases", ["problem_id"], :name => "index_testcases_on_problem_id"
+            +   add_index "testcases", ["problem_id"], name: "index_testcases_on_problem_id"
-            -   create_table "user_contest_stats", :force => true do |t|
+            +   create_table "user_contest_stats", force: :cascade do |t|
                   t.integer  "user_id"
                   t.datetime "started_at"
-            -     t.datetime "created_at",    :null => false
+            +     t.datetime "created_at",    null: false
-            -     t.datetime "updated_at",    :null => false
+            +     t.datetime "updated_at",    null: false
                   t.boolean  "forced_logout"
                 end
-            -   create_table "users", :force => true do |t|
+            +   create_table "users", force: :cascade do |t|
-            -     t.string   "login",           :limit => 50
+            +     t.string   "login",           limit: 50
                   t.string   "full_name"
                   t.string   "hashed_password"
-            -     t.string   "salt",            :limit => 5
+            +     t.string   "salt",            limit: 5
                   t.string   "alias"
                   t.string   "email"
                   t.integer  "site_id"
                   t.integer  "country_id"
-            -     t.boolean  "activated",                     :default => false
+            +     t.boolean  "activated",                  default: false
                   t.datetime "created_at"
                   t.datetime "updated_at"
-            -     t.boolean  "enabled",                       :default => true
+            +     t.boolean  "enabled",                    default: true
                   t.string   "remark"
                   t.string   "last_ip"
                   t.string   "section"
                 end
-            -   add_index "users", ["login"], :name => "index_users_on_login", :unique => true
+            +   add_index "users", ["login"], name: "index_users_on_login", unique: true
               end

db/seeds.rb ¶ +15

                    :value_type => 'string',
                    :default_value => 'Grader',
                    :description => 'This name will be shown on the user header bar.'
                  },
                  {
                    :key => 'contest.multisites',
                    :value_type => 'boolean',
                    :default_value => 'false',
                    :description => 'If the server is in contest mode and this option is true, on the log in of the admin a menu for site selections is shown.'
                  },
+            +    #---------------------------- right --------------------------------
                  {
                    :key => 'right.user_hall_of_fame',
                    :value_type => 'boolean',
                    :default_value => 'false',
                    :description => 'If true, any user can access hall of fame page.'
                  },
                  {
                    :key => 'right.multiple_ip_login',
                    :value_type => 'boolean',
                    :default_value => 'true',
                    :description => 'When change from true to false, a user can login from the first IP they logged into afterward.'
                  },
                  {
                    :key => 'right.user_view_submission',
                    :value_type => 'boolean',
                    :default_value => 'false',
                    :description => 'If true, any user can view submissions of every one.'
                  },
+            +    {
+            +      :key => 'right.bypass_agreement',
+            +      :value_type => 'boolean',
+            +      :default_value => 'true',
+            +      :description => 'When false, a user must accept usage agreement before login'
+            +    },
+            +
+            +    {
+            +      :key => 'right.heartbeat_response',
+            +      :value_type => 'string',
+            +      :default_value => 'OK',
+            +      :description => 'Heart beat response text'
+            +    },
+            +
                  # If Configuration['system.online_registration'] is true, the
                  # system allows online registration, and will use these
                  # information for sending confirmation emails.
                  {
                    :key => 'system.online_registration.smtp',
                    :value_type => 'string',
                    :default_value => 'smtp.somehost.com'
                  },
                  {
                    :key => 'system.online_registration.from',
                    :value_type => 'string',

test/concurrent/task_test_setup.rb ¶ +1 -1

               ENV["RAILS_ENV"] = "test"
               require File.expand_path(File.dirname(__FILE__) + "/../../config/environment")
               def clear_all_tasks
-            -   Task.find(:all).each do |task|
+            +   Task.all.each do |task|
                   task.destroy
                 end
               end
               clear_all_tasks
               (1..1000).each do |i|
                 Task.create(:id => i,
                             :submission_id => i,
                             :status => Task::STATUS_INQUEUE)
               end

test/concurrent/task_test_teardown.rb ¶ +2 -3

               ENV["RAILS_ENV"] = "test"
               require File.expand_path(File.dirname(__FILE__) + "/../../config/environment")
               def clear_all_tasks
-            -   Task.find(:all).each do |task|
+            +   Task.all.each do |task|
                   task.destroy
                 end
               end
-            - puts Task.find(:all,
+            + puts Task.where(status: Task::STATUS_COMPLETE).length
-            -                :conditions => {:status => Task::STATUS_COMPLETE}).length
               clear_all_tasks

config/initializers/secret_token.rb removed ¶ -7

deleted file

spec/config_spec_helper.rb removed ¶ -38

deleted file

spec/controllers/main_controller_spec.rb removed ¶ -193

deleted file

spec/controllers/sources_controller_spec.rb removed ¶ -12

deleted file

spec/controllers/submissions_controller_spec.rb removed ¶ -160

deleted file

spec/controllers/test_controller_spec.rb removed ¶ -28

deleted file

spec/controllers/user_admin_controller_spec.rb removed ¶ -73

deleted file

spec/controllers/users_controller_spec.rb removed ¶ -100

deleted file

spec/helpers/sources_helper_spec.rb removed ¶ -15

deleted file

spec/helpers/submissions_helper_spec.rb removed ¶ -15

deleted file

spec/integration/contest_managements_spec.rb removed ¶ -136

deleted file

spec/models/configuration_spec.rb removed ¶ -95

deleted file

spec/models/login_spec.rb removed ¶ -5

deleted file

spec/models/site_spec.rb removed ¶ -48

deleted file

spec/models/submission_spec.rb removed ¶ -37

deleted file

spec/models/submission_view_logs_spec.rb removed ¶ -5

deleted file

spec/models/test_request_spec.rb removed ¶ -39

deleted file

spec/models/testcases_spec.rb removed ¶ -5

deleted file

spec/models/user_spec.rb removed ¶ -163

deleted file

spec/rcov.opts removed ¶ -2

deleted file

spec/requests/submissions_spec.rb removed ¶ -11

deleted file

spec/routing/submissions_routing_spec.rb removed ¶ -35

deleted file

spec/spec.opts removed ¶ -4

deleted file

spec/spec_helper.rb removed ¶ -38

deleted file

spec/views/sources/direct_edit.html.haml_spec.rb removed ¶ -5

deleted file

spec/views/submissions/edit.html.haml_spec.rb removed ¶ -15

deleted file

spec/views/submissions/index.html.haml_spec.rb removed ¶ -15

deleted file

spec/views/submissions/new.html.haml_spec.rb removed ¶ -15

deleted file

spec/views/submissions/show.html.haml_spec.rb removed ¶ -12

deleted file

test/fixtures/configurations.yml removed ¶ -7

deleted file

test/performance/browsing_test.rb removed ¶ -12

deleted file

test/unit/.gitkeep removed ¶

deleted file

test/unit/announcement_test.rb removed ¶ -8

deleted file

test/unit/configuration_test.rb removed ¶ -8

deleted file

test/unit/contest_test.rb removed ¶ -8

deleted file

test/unit/country_test.rb removed ¶ -8

deleted file

test/unit/description_test.rb removed ¶ -8

deleted file

test/unit/grader_process_test.rb removed ¶ -8

deleted file

test/unit/helpers/contest_management_helper_test.rb removed ¶ -4

deleted file

test/unit/helpers/contests_helper_test.rb removed ¶ -4

deleted file

test/unit/language_test.rb removed ¶ -10

deleted file

test/unit/message_test.rb removed ¶ -8

deleted file

test/unit/problem_test.rb removed ¶ -10

deleted file

test/unit/right_test.rb removed ¶ -10

deleted file

test/unit/role_test.rb removed ¶ -10

deleted file

test/unit/site_test.rb removed ¶ -8

deleted file

test/unit/submission_test.rb removed ¶ -10

deleted file

test/unit/task_test.rb removed ¶ -41

deleted file

test/unit/test_pair_test.rb removed ¶ -8

deleted file

test/unit/test_request_test.rb removed ¶ -8

deleted file

test/unit/user_contest_stat_test.rb removed ¶ -8

deleted file

test/unit/user_test.rb removed ¶ -10

deleted file

Write
Preview

You need to be logged in to leave comments. Login now

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository permissions settings

Sign in to your account

Author

r623:0e5f52b4f443 - Mon, 02 Jan 2017 04:42:18 - 101 files changed: 467 inserted, 2013 deleted

Sign in to your account

Commit r623:0e5f52b4f443 public

Author

r623:0e5f52b4f443 - Mon, 02 Jan 2017 04:42:18 - 101 files changed: 467 inserted, 2013 deleted

Commit `r623:0e5f52b4f443` public