cafe-grader-judge-scripts Commit

cafe-grader-judge-scripts

Commit `r181:5c6f0b732e70` public

parent | child

Description:

handle the case when problem id or submission id is null. Grader will simply skip such request. Add more report on console (for command line grading) (mercurial grafted from d233105d3965c5368c9b33125f390e39b25f910e)

Commit status:

[Not Reviewed]

References:

default

Diff options:

| | | |

Comments:

0 Commit comments 0 Inline Comments

Unresolved TODOs:

There are no unresolved TODOs

Add another comment

r181:5c6f0b732e70 - Tue, 12 Aug 2014 08:44:55 - 2 files changed: 6 inserted, 6 deleted

grader ¶ +1 -1

                   begin
                     submission = Submission.find(sub_id.to_i)
                   rescue ActiveRecord::RecordNotFound
-            -       puts "Record not found"
+            +       puts "Submission #{sub_id} not found"
                     submission = nil
                   end

lib/engine.rb ¶ +5 -5

                     user = submission.user
                     problem = submission.problem
+            +       begin
                       # TODO: will have to create real exception for this
                       if user==nil or problem == nil
                         @reporter.report_error(submission,"Grading error: problem with submission")
-            -         #raise "engine: user or problem is nil"
+            +           raise "engine: user or problem is nil"
                       end
                       # TODO: this is another hack so that output only task can be judged
                         source_name = "source.#{lang_ext}"
                       end
-            -       begin
                       grading_dir = @room_maker.produce_grading_room(submission)
                       @room_maker.save_source(submission,source_name)
                       problem_home = @room_maker.find_problem_home(submission)
                       if !FileTest.exist?(problem_home)
                         puts "PROBLEM DIR: #{problem_home}"
-            -           puts "No test data. (check problem dir)"
+            +           raise "engine: No test data."
-            -           raise "No test data."
                       end
                       dinit = DirInit::Manager.new(problem_home)
                     rescue RuntimeError => msg
                       @reporter.report_error(submission, msg)
+            +         puts "ERROR: #{msg}"
                     ensure
                       @room_maker.clean_up(submission)
                     script_dir = "#{problem_home}/script"
                     std_script_dir = get_std_script_dir
-            -       raise "std-script directory not found" if !FileTest.exist?(std_script_dir)
+            +       raise "engine: std-script directory not found" if !FileTest.exist?(std_script_dir)
                     scripts = Dir[std_script_dir + '/*']

Write
Preview

You need to be logged in to leave comments. Login now

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository permissions settings

Sign in to your account

Author

r181:5c6f0b732e70 - Tue, 12 Aug 2014 08:44:55 - 2 files changed: 6 inserted, 6 deleted

Sign in to your account

Commit r181:5c6f0b732e70 public

Author

r181:5c6f0b732e70 - Tue, 12 Aug 2014 08:44:55 - 2 files changed: 6 inserted, 6 deleted

Commit `r181:5c6f0b732e70` public