Description:
Merge pull request #3 from nattee/master
Quick fix for grader crash problem
Commit status:
[Not Reviewed]
References:
Diff options:
Comments:
0 Commit comments
0 Inline Comments
Unresolved TODOs:
There are no unresolved TODOs
r195:3eff00360356 - - 3 files changed: 33 inserted, 31 deleted
@@ -313,97 +313,97 | |||
|
313 | 313 | contest = Contest.find_by_name(contest_name) |
|
314 | 314 | if contest==nil |
|
315 | 315 | puts "cannot find contest: #{contest_name}" |
|
316 | 316 | exit(0) |
|
317 | 317 | end |
|
318 | 318 | |
|
319 | 319 | if options[:report] |
|
320 | 320 | result_collector = ResultCollector.new |
|
321 | 321 | else |
|
322 | 322 | result_collector = nil |
|
323 | 323 | end |
|
324 | 324 | |
|
325 | 325 | if options[:dry_run] |
|
326 | 326 | puts "Running in dry mode" |
|
327 | 327 | end |
|
328 | 328 | |
|
329 | 329 | prob_reporter = Grader::SubmissionReporter.new(:dry_run => dry_run, |
|
330 | 330 | :result_collector => result_collector) |
|
331 | 331 | engine = Grader::Engine.new(:reporter => prob_reporter) |
|
332 | 332 | runner = Grader::Runner.new(engine, grader_proc) |
|
333 | 333 | |
|
334 | 334 | grader_proc.report_active if grader_proc!=nil |
|
335 | 335 | |
|
336 | 336 | contest.problems.each do |problem| |
|
337 | 337 | puts "Grading: #{problem.name}" |
|
338 | 338 | runner.grade_problem(problem, |
|
339 | 339 | :user_conditions => lambda do |u| |
|
340 | 340 | u.contest_finished? and |
|
341 | 341 | u.contest_ids.include?(contest.id) |
|
342 | 342 | end) |
|
343 | 343 | end |
|
344 | 344 | |
|
345 | 345 | if options[:report] |
|
346 | 346 | result_collector.print_report_by_user |
|
347 | 347 | end |
|
348 | 348 | end |
|
349 | 349 | |
|
350 | 350 | def grader_grade_submissions(grader_proc, options) |
|
351 | 351 | engine = Grader::Engine.new |
|
352 | 352 | runner = Grader::Runner.new(engine, grader_proc) |
|
353 | 353 | |
|
354 | 354 | grader_proc.report_active if grader_proc!=nil |
|
355 | 355 | |
|
356 | 356 | ARGV.each do |sub_id| |
|
357 | 357 | puts "Grading #{sub_id}" |
|
358 | 358 | begin |
|
359 | 359 | submission = Submission.find(sub_id.to_i) |
|
360 | 360 | rescue ActiveRecord::RecordNotFound |
|
361 |
- puts " |
|
|
361 | + puts "Submission #{sub_id} not found" | |
|
362 | 362 | submission = nil |
|
363 | 363 | end |
|
364 | 364 | |
|
365 | 365 | if submission!=nil |
|
366 | 366 | runner.grade_submission(submission) |
|
367 | 367 | end |
|
368 | 368 | end |
|
369 | 369 | end |
|
370 | 370 | |
|
371 | 371 | ######################################### |
|
372 | 372 | # main program |
|
373 | 373 | ######################################### |
|
374 | 374 | |
|
375 | 375 | options = process_options_and_stop_file |
|
376 | 376 | GRADER_ENV = options[:environment] |
|
377 | 377 | grader_mode = options[:mode] |
|
378 | 378 | dry_run = options[:dry_run] |
|
379 | 379 | |
|
380 | 380 | puts "environment: #{GRADER_ENV}" |
|
381 | 381 | require File.join(File.dirname(__FILE__),'config/environment') |
|
382 | 382 | |
|
383 | 383 | # add grader_mode to config |
|
384 | 384 | # this is needed because method log needs it. TODO: clean this up |
|
385 | 385 | class << config |
|
386 | 386 | attr_accessor :grader_mode |
|
387 | 387 | end |
|
388 | 388 | config.grader_mode = grader_mode |
|
389 | 389 | |
|
390 | 390 | # reading rails environment |
|
391 | 391 | log 'Reading rails environment' |
|
392 | 392 | |
|
393 | 393 | RAILS_ENV = config.rails_env |
|
394 | 394 | require RAILS_ROOT + '/config/environment' |
|
395 | 395 | |
|
396 | 396 | # register grader process |
|
397 | 397 | if config.report_grader |
|
398 | 398 | grader_proc = GraderProcess.register(config.grader_hostname, |
|
399 | 399 | Process.pid, |
|
400 | 400 | grader_mode) |
|
401 | 401 | else |
|
402 | 402 | grader_proc = nil |
|
403 | 403 | end |
|
404 | 404 | |
|
405 | 405 | #set loggin environment |
|
406 | 406 | ENV['GRADER_LOGGING'] = log_file_name |
|
407 | 407 | |
|
408 | 408 | # register exit handler to report inactive, and terminated |
|
409 | 409 | at_exit do |
@@ -1,180 +1,182 | |||
|
1 | 1 | require 'fileutils' |
|
2 | 2 | require File.join(File.dirname(__FILE__),'dir_init') |
|
3 | 3 | |
|
4 | 4 | module Grader |
|
5 | 5 | |
|
6 | 6 | # |
|
7 | 7 | # A grader engine grades a submission, against anything: a test |
|
8 | 8 | # data, or a user submitted test data. It uses two helpers objects: |
|
9 | 9 | # room_maker and reporter. |
|
10 | 10 | # |
|
11 | 11 | class Engine |
|
12 | 12 | |
|
13 | 13 | attr_writer :room_maker |
|
14 | 14 | attr_writer :reporter |
|
15 | 15 | |
|
16 | 16 | def initialize(options={}) |
|
17 | 17 | # default options |
|
18 | 18 | if not options.include? :room_maker |
|
19 | 19 | options[:room_maker] = Grader::SubmissionRoomMaker.new |
|
20 | 20 | end |
|
21 | 21 | if not options.include? :reporter |
|
22 | 22 | options[:reporter] = Grader::SubmissionReporter.new |
|
23 | 23 | end |
|
24 | 24 | |
|
25 | 25 | @config = Grader::Configuration.get_instance |
|
26 | 26 | |
|
27 | 27 | @room_maker = options[:room_maker] |
|
28 | 28 | @reporter = options[:reporter] |
|
29 | 29 | end |
|
30 | 30 | |
|
31 | 31 | # takes a submission, asks room_maker to produce grading directories, |
|
32 | 32 | # calls grader scripts, and asks reporter to save the result |
|
33 | 33 | def grade(submission) |
|
34 | 34 | current_dir = FileUtils.pwd |
|
35 | 35 | |
|
36 | 36 | user = submission.user |
|
37 | 37 | problem = submission.problem |
|
38 | 38 | |
|
39 | - # TODO: will have to create real exception for this | |
|
40 | - if user==nil or problem == nil | |
|
41 | - @reporter.report_error(submission,"Grading error: problem with submission") | |
|
42 | - #raise "engine: user or problem is nil" | |
|
43 | - end | |
|
44 | - | |
|
45 | - # TODO: this is another hack so that output only task can be judged | |
|
46 | - if submission.language!=nil | |
|
47 | - language = submission.language.name | |
|
48 | - lang_ext = submission.language.ext | |
|
49 | - else | |
|
50 | - language = 'c' | |
|
51 | - lang_ext = 'c' | |
|
52 | - end | |
|
39 | + begin | |
|
40 | + # TODO: will have to create real exception for this | |
|
41 | + if user==nil or problem == nil | |
|
42 | + @reporter.report_error(submission,"Grading error: problem with submission") | |
|
43 | + raise "engine: user or problem is nil" | |
|
44 | + end | |
|
53 | 45 | |
|
54 | - # This is needed because older version of std-scripts/compile | |
|
55 | - # only look for c++. | |
|
56 | - if language == 'cpp' | |
|
57 | - language = 'c++' | |
|
58 |
- |
|
|
46 | + # TODO: this is another hack so that output only task can be judged | |
|
47 | + if submission.language!=nil | |
|
48 | + language = submission.language.name | |
|
49 | + lang_ext = submission.language.ext | |
|
50 | + else | |
|
51 | + language = 'c' | |
|
52 | + lang_ext = 'c' | |
|
53 | + end | |
|
59 | 54 | |
|
60 | - # COMMENT: should it be only source.ext? | |
|
61 | - if problem!=nil | |
|
62 | - source_name = "#{problem.name}.#{lang_ext}" | |
|
63 | - else | |
|
64 | - source_name = "source.#{lang_ext}" | |
|
65 | - end | |
|
55 | + # This is needed because older version of std-scripts/compile | |
|
56 | + # only look for c++. | |
|
57 | + if language == 'cpp' | |
|
58 | + language = 'c++' | |
|
59 | + end | |
|
66 | 60 | |
|
67 | - begin | |
|
61 | + # COMMENT: should it be only source.ext? | |
|
62 | + if problem!=nil | |
|
63 | + source_name = "#{problem.name}.#{lang_ext}" | |
|
64 | + else | |
|
65 | + source_name = "source.#{lang_ext}" | |
|
66 | + end | |
|
67 | + | |
|
68 | 68 | grading_dir = @room_maker.produce_grading_room(submission) |
|
69 | 69 | @room_maker.save_source(submission,source_name) |
|
70 | 70 | problem_home = @room_maker.find_problem_home(submission) |
|
71 | 71 | |
|
72 | 72 | # puts "GRADING DIR: #{grading_dir}" |
|
73 | 73 | # puts "PROBLEM DIR: #{problem_home}" |
|
74 | 74 | |
|
75 | 75 | if !FileTest.exist?(problem_home) |
|
76 | - raise "No test data." | |
|
76 | + puts "PROBLEM DIR: #{problem_home}" | |
|
77 | + raise "engine: No test data." | |
|
77 | 78 | end |
|
78 | 79 | |
|
79 | 80 | dinit = DirInit::Manager.new(problem_home) |
|
80 | 81 | |
|
81 | 82 | dinit.setup do |
|
82 | 83 | copy_log = copy_script(problem_home) |
|
83 | 84 | save_copy_log(problem_home,copy_log) |
|
84 | 85 | end |
|
85 | 86 | |
|
86 | 87 | call_judge(problem_home,language,grading_dir,source_name) |
|
87 | 88 | |
|
88 | 89 | @reporter.report(submission,"#{grading_dir}/test-result") |
|
89 | 90 | |
|
90 | 91 | dinit.teardown do |
|
91 | 92 | copy_log = load_copy_log(problem_home) |
|
92 | 93 | clear_copy_log(problem_home) |
|
93 | 94 | clear_script(copy_log,problem_home) |
|
94 | 95 | end |
|
95 | 96 | |
|
96 | 97 | rescue RuntimeError => msg |
|
97 | 98 | @reporter.report_error(submission, msg) |
|
99 | + puts "ERROR: #{msg}" | |
|
98 | 100 | |
|
99 | 101 | ensure |
|
100 | 102 | @room_maker.clean_up(submission) |
|
101 | 103 | Dir.chdir(current_dir) # this is really important |
|
102 | 104 | end |
|
103 | 105 | end |
|
104 | 106 | |
|
105 | 107 | protected |
|
106 | 108 | |
|
107 | 109 | def talk(str) |
|
108 | 110 | if @config.talkative |
|
109 | 111 | puts str |
|
110 | 112 | end |
|
111 | 113 | end |
|
112 | 114 | |
|
113 | 115 | def call_judge(problem_home,language,grading_dir,fname) |
|
114 | 116 | ENV['PROBLEM_HOME'] = problem_home |
|
115 | 117 | ENV['RUBYOPT'] = '' |
|
116 | 118 | |
|
117 | 119 | talk grading_dir |
|
118 | 120 | Dir.chdir grading_dir |
|
119 | 121 | cmd = "#{problem_home}/script/judge #{language} #{fname}" |
|
120 | 122 | talk "CMD: #{cmd}" |
|
121 | 123 | system(cmd) |
|
122 | 124 | end |
|
123 | 125 | |
|
124 | 126 | def get_std_script_dir |
|
125 | 127 | GRADER_ROOT + '/std-script' |
|
126 | 128 | end |
|
127 | 129 | |
|
128 | 130 | def copy_script(problem_home) |
|
129 | 131 | script_dir = "#{problem_home}/script" |
|
130 | 132 | std_script_dir = get_std_script_dir |
|
131 | 133 | |
|
132 | - raise "std-script directory not found" if !FileTest.exist?(std_script_dir) | |
|
134 | + raise "engine: std-script directory not found" if !FileTest.exist?(std_script_dir) | |
|
133 | 135 | |
|
134 | 136 | scripts = Dir[std_script_dir + '/*'] |
|
135 | 137 | |
|
136 | 138 | copied = [] |
|
137 | 139 | |
|
138 | 140 | scripts.each do |s| |
|
139 | 141 | fname = File.basename(s) |
|
140 | 142 | next if FileTest.directory?(s) |
|
141 | 143 | if !FileTest.exist?("#{script_dir}/#{fname}") |
|
142 | 144 | copied << fname |
|
143 | 145 | FileUtils.cp(s, "#{script_dir}", :preserve => true) |
|
144 | 146 | end |
|
145 | 147 | end |
|
146 | 148 | |
|
147 | 149 | return copied |
|
148 | 150 | end |
|
149 | 151 | |
|
150 | 152 | def copy_log_filename(problem_home) |
|
151 | 153 | return File.join(problem_home, '.scripts_copied') |
|
152 | 154 | end |
|
153 | 155 | |
|
154 | 156 | def save_copy_log(problem_home, log) |
|
155 | 157 | f = File.new(copy_log_filename(problem_home),"w") |
|
156 | 158 | log.each do |fname| |
|
157 | 159 | f.write("#{fname}\n") |
|
158 | 160 | end |
|
159 | 161 | f.close |
|
160 | 162 | end |
|
161 | 163 | |
|
162 | 164 | def load_copy_log(problem_home) |
|
163 | 165 | f = File.new(copy_log_filename(problem_home),"r") |
|
164 | 166 | log = [] |
|
165 | 167 | f.readlines.each do |line| |
|
166 | 168 | log << line.strip |
|
167 | 169 | end |
|
168 | 170 | f.close |
|
169 | 171 | log |
|
170 | 172 | end |
|
171 | 173 | |
|
172 | 174 | def clear_copy_log(problem_home) |
|
173 | 175 | File.delete(copy_log_filename(problem_home)) |
|
174 | 176 | end |
|
175 | 177 | |
|
176 | 178 | def clear_script(log,problem_home) |
|
177 | 179 | log.each do |s| |
|
178 | 180 | FileUtils.rm("#{problem_home}/script/#{s}") |
|
179 | 181 | end |
|
180 | 182 | end |
@@ -1,69 +1,69 | |||
|
1 | 1 | #!/usr/bin/env ruby |
|
2 | 2 | |
|
3 | 3 | require 'fileutils' |
|
4 | 4 | |
|
5 | 5 | ############################## |
|
6 | 6 | # |
|
7 | 7 | # Standard Compile Script |
|
8 | 8 | # |
|
9 | 9 | # Supported compilers: |
|
10 | 10 | # gcc, g++, and fpc. |
|
11 | 11 | # |
|
12 | 12 | ############################## |
|
13 | 13 | |
|
14 |
- def talk( |
|
|
14 | + def talk(str='') | |
|
15 | 15 | if ENV['TALKATIVE']!=nil |
|
16 | 16 | puts str |
|
17 | 17 | end |
|
18 | 18 | if ENV['GRADER_LOGGING']!=nil |
|
19 | 19 | log_fname = ENV['GRADER_LOGGING'] |
|
20 | 20 | fp = File.open(log_fname,"a") |
|
21 |
- fp.puts("run: #{Time.new.strftime("%H:%M")} #{ |
|
|
21 | + fp.puts("run: #{Time.new.strftime("%H:%M")} #{str}") | |
|
22 | 22 | fp.close |
|
23 | 23 | end |
|
24 | 24 | end |
|
25 | 25 | |
|
26 | 26 | C_COMPILER = "/usr/bin/gcc" |
|
27 | 27 | CPLUSPLUS_COMPILER = "/usr/bin/g++" |
|
28 | 28 | PASCAL_COMPILER = "/usr/bin/fpc" |
|
29 | 29 | |
|
30 | 30 | C_OPTIONS = "-O2 -s -static -std=c99 -DCONTEST -lm -Wall" |
|
31 | 31 | CPLUSPLUS_OPTIONS = "-O2 -s -static -DCONTEST -lm -Wall" |
|
32 | 32 | PASCAL_OPTIONS = "-O1 -XS -dCONTEST" |
|
33 | 33 | |
|
34 | 34 | # Check for the correct number of arguments. Otherwise, print usage. |
|
35 | 35 | if ARGV.length == 0 or ARGV.length > 4 |
|
36 | 36 | puts "Usage: compile <language> [<source-file>] [<output-file>] [<message-file>]" |
|
37 | 37 | puts |
|
38 | 38 | puts "<source-file> is defaulted to \"source\"." |
|
39 | 39 | puts "<output-file> is defaulted to \"a.out\"." |
|
40 | 40 | puts "<message-file> is defaulted to \"compiler_message\"." |
|
41 | 41 | puts |
|
42 | 42 | exit(127) |
|
43 | 43 | end |
|
44 | 44 | |
|
45 | 45 | PARAMS = { |
|
46 | 46 | :source_file => [1,'source'], |
|
47 | 47 | :output_file => [2,'a.out'], |
|
48 | 48 | :message_file => [3,'compiler_message'] |
|
49 | 49 | } |
|
50 | 50 | |
|
51 | 51 | params = {} |
|
52 | 52 | params[:prog_lang] = ARGV[0] |
|
53 | 53 | PARAMS.each_key do |param_name| |
|
54 | 54 | index, default = PARAMS[param_name] |
|
55 | 55 | if ARGV.length > index |
|
56 | 56 | params[param_name] = ARGV[index] |
|
57 | 57 | else |
|
58 | 58 | params[param_name] = default |
|
59 | 59 | end |
|
60 | 60 | talk "#{param_name}: #{params[param_name]}" |
|
61 | 61 | end |
|
62 | 62 | |
|
63 | 63 | # Remove any remaining output files or message files. |
|
64 | 64 | if FileTest.exists? params[:output_file] |
|
65 | 65 | FileUtils.rm(params[:output_file]) |
|
66 | 66 | end |
|
67 | 67 | if FileTest.exists? params[:message_file] |
|
68 | 68 | FileUtils.rm(params[:message_file]) |
|
69 | 69 | end |
You need to be logged in to leave comments.
Login now